* [PATCH] rootfs.py: introduce USE_DEVFS check
@ 2014-04-02 15:15 Matthieu Crapet
2014-04-02 15:52 ` Phil Blundell
2014-04-02 16:01 ` [PATCH v2] " Matthieu Crapet
0 siblings, 2 replies; 6+ messages in thread
From: Matthieu Crapet @ 2014-04-02 15:15 UTC (permalink / raw)
To: openembedded-core
Since commit a83144bac8d67704ff66f5dc0fc56f5b63979694 (2014-02-11), USE_DEVFS is not considered anymore.
For compatibility, let's restore USE_DEVFS semantic.
Also add USE_DEVFS to documentation.conf.
Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
---
meta/conf/documentation.conf | 1 +
meta/lib/oe/rootfs.py | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf
index 4d49a02..ced646b 100644
--- a/meta/conf/documentation.conf
+++ b/meta/conf/documentation.conf
@@ -436,6 +436,7 @@ UBOOT_MACHINE[doc] = "Specifies the value passed on the make command line when b
UBOOT_MAKE_TARGET[doc] = "Specifies the target called in the Makefile."
UBOOT_SUFFIX[doc] = "Points to the generated U-Boot extension."
UBOOT_TARGET[doc] = "Specifies the target used for building U-Boot."
+USE_DEVFS[doc] = "When building images, specifies to populate or not ${sysconfdir}. This variable defaults to '0' (leave directory empty, surely because devtmpfs do the job). Set it to '1' to use makedevs (or consider using a custom file with IMAGE_DEVICE_TABLES)."
USER_CLASSES[doc] = "List of additional classes to use when building images that enable extra features."
USERADD_PACKAGES[doc] = "When a recipe inherits the useradd class, this variable specifies the individual packages within the recipe that require users and/or groups to be added."
USERADD_PARAM[doc] = "When a recipe inherits the useradd class, this variable specifies for a package what parameters should be passed to the useradd command if you wish to add a user to the system when the package is installed."
diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
index 3eac3c9..dddbef4 100644
--- a/meta/lib/oe/rootfs.py
+++ b/meta/lib/oe/rootfs.py
@@ -116,7 +116,8 @@ class Rootfs(object):
"offline and rootfs is read-only: %s" %
delayed_postinsts)
- self._create_devfs()
+ if self.d.getVar('USE_DEVFS', True) != "1":
+ self._create_devfs()
self._uninstall_uneeded()
--
1.8.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] rootfs.py: introduce USE_DEVFS check
2014-04-02 15:15 [PATCH] rootfs.py: introduce USE_DEVFS check Matthieu Crapet
@ 2014-04-02 15:52 ` Phil Blundell
2014-04-02 15:55 ` Matthieu CRAPET
2014-04-02 16:01 ` [PATCH v2] " Matthieu Crapet
1 sibling, 1 reply; 6+ messages in thread
From: Phil Blundell @ 2014-04-02 15:52 UTC (permalink / raw)
To: Matthieu Crapet; +Cc: openembedded-core
On Wed, 2014-04-02 at 17:15 +0200, Matthieu Crapet wrote:
> +USE_DEVFS[doc] = "When building images, specifies to populate or not ${sysconfdir}. This variable defaults to '0' (leave directory empty, surely because devtmpfs do the job). Set it to '1' to use makedevs (or consider using a custom file with IMAGE_DEVICE_TABLES)."
That's backwards, isn't it?
p.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] rootfs.py: introduce USE_DEVFS check
2014-04-02 15:52 ` Phil Blundell
@ 2014-04-02 15:55 ` Matthieu CRAPET
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu CRAPET @ 2014-04-02 15:55 UTC (permalink / raw)
To: openembedded-core@lists.openembedded.org
Ooops!
-----Message d'origine-----
De : Phil Blundell [mailto:pb@pbcl.net]
Envoyé : mercredi 2 avril 2014 17:53
À : Matthieu CRAPET
Cc : openembedded-core@lists.openembedded.org
Objet : Re: [OE-core] [PATCH] rootfs.py: introduce USE_DEVFS check
On Wed, 2014-04-02 at 17:15 +0200, Matthieu Crapet wrote:
> +USE_DEVFS[doc] = "When building images, specifies to populate or not ${sysconfdir}. This variable defaults to '0' (leave directory empty, surely because devtmpfs do the job). Set it to '1' to use makedevs (or consider using a custom file with IMAGE_DEVICE_TABLES)."
That's backwards, isn't it?
p.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] rootfs.py: introduce USE_DEVFS check
2014-04-02 15:15 [PATCH] rootfs.py: introduce USE_DEVFS check Matthieu Crapet
2014-04-02 15:52 ` Phil Blundell
@ 2014-04-02 16:01 ` Matthieu Crapet
2014-04-02 20:04 ` Andreas Oberritter
1 sibling, 1 reply; 6+ messages in thread
From: Matthieu Crapet @ 2014-04-02 16:01 UTC (permalink / raw)
To: openembedded-core
Since commit a83144bac8d67704ff66f5dc0fc56f5b63979694 (2014-02-11), USE_DEVFS is not considered anymore.
For compatibility, let's restore USE_DEVFS semantic.
Also add USE_DEVFS to documentation.conf.
Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
---
meta/conf/documentation.conf | 1 +
meta/lib/oe/rootfs.py | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf
index 4d49a02..315e1b5 100644
--- a/meta/conf/documentation.conf
+++ b/meta/conf/documentation.conf
@@ -436,6 +436,7 @@ UBOOT_MACHINE[doc] = "Specifies the value passed on the make command line when b
UBOOT_MAKE_TARGET[doc] = "Specifies the target called in the Makefile."
UBOOT_SUFFIX[doc] = "Points to the generated U-Boot extension."
UBOOT_TARGET[doc] = "Specifies the target used for building U-Boot."
+USE_DEVFS[doc] = "When building images, specifies to populate or not ${sysconfdir}. This variable defaults to '1' (leave directory empty, surely because devtmpfs do the job). Set it to '0' to use makedevs (or consider using a custom file with IMAGE_DEVICE_TABLES)."
USER_CLASSES[doc] = "List of additional classes to use when building images that enable extra features."
USERADD_PACKAGES[doc] = "When a recipe inherits the useradd class, this variable specifies the individual packages within the recipe that require users and/or groups to be added."
USERADD_PARAM[doc] = "When a recipe inherits the useradd class, this variable specifies for a package what parameters should be passed to the useradd command if you wish to add a user to the system when the package is installed."
diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
index 3eac3c9..dddbef4 100644
--- a/meta/lib/oe/rootfs.py
+++ b/meta/lib/oe/rootfs.py
@@ -116,7 +116,8 @@ class Rootfs(object):
"offline and rootfs is read-only: %s" %
delayed_postinsts)
- self._create_devfs()
+ if self.d.getVar('USE_DEVFS', True) != "1":
+ self._create_devfs()
self._uninstall_uneeded()
--
1.8.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] rootfs.py: introduce USE_DEVFS check
2014-04-02 16:01 ` [PATCH v2] " Matthieu Crapet
@ 2014-04-02 20:04 ` Andreas Oberritter
2014-04-03 7:05 ` [PATCH v3] " Matthieu Crapet
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Oberritter @ 2014-04-02 20:04 UTC (permalink / raw)
To: openembedded-core
Hello Matthieu,
On 02.04.2014 18:01, Matthieu Crapet wrote:
> Since commit a83144bac8d67704ff66f5dc0fc56f5b63979694 (2014-02-11), USE_DEVFS is not considered anymore.
> For compatibility, let's restore USE_DEVFS semantic.
> Also add USE_DEVFS to documentation.conf.
>
> Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
> ---
> meta/conf/documentation.conf | 1 +
> meta/lib/oe/rootfs.py | 3 ++-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf
> index 4d49a02..315e1b5 100644
> --- a/meta/conf/documentation.conf
> +++ b/meta/conf/documentation.conf
> @@ -436,6 +436,7 @@ UBOOT_MACHINE[doc] = "Specifies the value passed on the make command line when b
> UBOOT_MAKE_TARGET[doc] = "Specifies the target called in the Makefile."
> UBOOT_SUFFIX[doc] = "Points to the generated U-Boot extension."
> UBOOT_TARGET[doc] = "Specifies the target used for building U-Boot."
> +USE_DEVFS[doc] = "When building images, specifies to populate or not ${sysconfdir}. This variable defaults to '1' (leave directory empty, surely because devtmpfs do the job). Set it to '0' to use makedevs (or consider using a custom file with IMAGE_DEVICE_TABLES)."
${sysconfdir} usually contains /etc, not /dev.
Regards,
Andreas
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] rootfs.py: introduce USE_DEVFS check
2014-04-02 20:04 ` Andreas Oberritter
@ 2014-04-03 7:05 ` Matthieu Crapet
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Crapet @ 2014-04-03 7:05 UTC (permalink / raw)
To: openembedded-core
Since commit a83144bac8d67704ff66f5dc0fc56f5b63979694 (2014-02-11), USE_DEVFS is not considered anymore.
For compatibility, let's restore USE_DEVFS semantic.
Also add USE_DEVFS to documentation.conf.
Signed-off-by: Matthieu Crapet <Matthieu.Crapet@ingenico.com>
---
meta/conf/documentation.conf | 1 +
meta/lib/oe/rootfs.py | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/meta/conf/documentation.conf b/meta/conf/documentation.conf
index 4d49a02..9d6e78f 100644
--- a/meta/conf/documentation.conf
+++ b/meta/conf/documentation.conf
@@ -436,6 +436,7 @@ UBOOT_MACHINE[doc] = "Specifies the value passed on the make command line when b
UBOOT_MAKE_TARGET[doc] = "Specifies the target called in the Makefile."
UBOOT_SUFFIX[doc] = "Points to the generated U-Boot extension."
UBOOT_TARGET[doc] = "Specifies the target used for building U-Boot."
+USE_DEVFS[doc] = "When building images, specifies to populate or not /dev. This variable defaults to '1' (leave directory empty, surely because devtmpfs do the job). Set it to '0' to use makedevs (or consider using a custom file with IMAGE_DEVICE_TABLES)."
USER_CLASSES[doc] = "List of additional classes to use when building images that enable extra features."
USERADD_PACKAGES[doc] = "When a recipe inherits the useradd class, this variable specifies the individual packages within the recipe that require users and/or groups to be added."
USERADD_PARAM[doc] = "When a recipe inherits the useradd class, this variable specifies for a package what parameters should be passed to the useradd command if you wish to add a user to the system when the package is installed."
diff --git a/meta/lib/oe/rootfs.py b/meta/lib/oe/rootfs.py
index 3eac3c9..dddbef4 100644
--- a/meta/lib/oe/rootfs.py
+++ b/meta/lib/oe/rootfs.py
@@ -116,7 +116,8 @@ class Rootfs(object):
"offline and rootfs is read-only: %s" %
delayed_postinsts)
- self._create_devfs()
+ if self.d.getVar('USE_DEVFS', True) != "1":
+ self._create_devfs()
self._uninstall_uneeded()
--
1.8.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-03 7:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 15:15 [PATCH] rootfs.py: introduce USE_DEVFS check Matthieu Crapet
2014-04-02 15:52 ` Phil Blundell
2014-04-02 15:55 ` Matthieu CRAPET
2014-04-02 16:01 ` [PATCH v2] " Matthieu Crapet
2014-04-02 20:04 ` Andreas Oberritter
2014-04-03 7:05 ` [PATCH v3] " Matthieu Crapet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox