[dora][PATCH] e2fsprogs: Fix populate-extfs.sh

Openembedded Core Discussions
 help / color / mirror / Atom feed

* [dora][PATCH] e2fsprogs: Fix populate-extfs.sh
@ 2014-06-30 14:18 Stéphane Cerveau
  2014-06-30 14:20 ` Stephane Cerveau
  0 siblings, 1 reply; 6+ messages in thread
From: Stéphane Cerveau @ 2014-06-30 14:18 UTC (permalink / raw)
  To: openembedded-core

Fix the use of command dirname on ubuntu 12.04.
dirname does not accept space in file name.

Signed-off-by: Stéphane Cerveau <scerveau@connected-labs.com>
---
 .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
index 26a8d89..47f5b5b 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
@@ -28,7 +28,7 @@ DEBUGFS="debugfs"
 		[ ! -z "$DIR" ] || continue
 		[ ! -z "$TGT" ] || continue
 
-                DIR="$(dirname $DIR)"
+                DIR="$(dirname "$DIR")"
 
 		if [ "$DIR" != "$CWD" ]; then
 			echo "cd $DIR"
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [dora][PATCH] e2fsprogs: Fix populate-extfs.sh
  2014-06-30 14:18 [dora][PATCH] e2fsprogs: Fix populate-extfs.sh Stéphane Cerveau
@ 2014-06-30 14:20 ` Stephane Cerveau
  2014-06-30 14:51   ` Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Stephane Cerveau @ 2014-06-30 14:20 UTC (permalink / raw)
  To: Stéphane Cerveau, openembedded-core

This patch applies to master and daisy branches too.

On 06/30/2014 04:18 PM, Stéphane Cerveau wrote:
> Fix the use of command dirname on ubuntu 12.04.
> dirname does not accept space in file name.
>
> Signed-off-by: Stéphane Cerveau <scerveau@connected-labs.com>
> ---
>   .../e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh   |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
> index 26a8d89..47f5b5b 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs-1.42.8/populate-extfs.sh
> @@ -28,7 +28,7 @@ DEBUGFS="debugfs"
>   		[ ! -z "$DIR" ] || continue
>   		[ ! -z "$TGT" ] || continue
>   
> -                DIR="$(dirname $DIR)"
> +                DIR="$(dirname "$DIR")"
>   
>   		if [ "$DIR" != "$CWD" ]; then
>   			echo "cd $DIR"



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dora][PATCH] e2fsprogs: Fix populate-extfs.sh
  2014-06-30 14:20 ` Stephane Cerveau
@ 2014-06-30 14:51   ` Richard Purdie
  2014-06-30 15:06     ` Stephane Cerveau
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2014-06-30 14:51 UTC (permalink / raw)
  To: Stephane Cerveau; +Cc: openembedded-core

On Mon, 2014-06-30 at 16:20 +0200, Stephane Cerveau wrote:
> This patch applies to master and daisy branches too.

Really? 

That is a little odd since populate-extfs.sh was removed in them?

Cheers,

Richard



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dora][PATCH] e2fsprogs: Fix populate-extfs.sh
  2014-06-30 14:51   ` Richard Purdie
@ 2014-06-30 15:06     ` Stephane Cerveau
  2014-06-30 15:08       ` Otavio Salvador
  0 siblings, 1 reply; 6+ messages in thread
From: Stephane Cerveau @ 2014-06-30 15:06 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

Sorry i have been fooled by the poky web interface :(
Anyway the bug is real on dora branch.
Cheers

Stéphane

On 06/30/2014 04:51 PM, Richard Purdie wrote:
> On Mon, 2014-06-30 at 16:20 +0200, Stephane Cerveau wrote:
>> This patch applies to master and daisy branches too.
> Really?
>
> That is a little odd since populate-extfs.sh was removed in them?
>
> Cheers,
>
> Richard
>



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dora][PATCH] e2fsprogs: Fix populate-extfs.sh
  2014-06-30 15:06     ` Stephane Cerveau
@ 2014-06-30 15:08       ` Otavio Salvador
  2014-06-30 15:11         ` Stephane Cerveau
  0 siblings, 1 reply; 6+ messages in thread
From: Otavio Salvador @ 2014-06-30 15:08 UTC (permalink / raw)
  To: Stephane Cerveau; +Cc: Patches and discussions about the oe-core layer

On Mon, Jun 30, 2014 at 12:06 PM, Stephane Cerveau
<scerveau@connected-labs.com> wrote:
> Sorry i have been fooled by the poky web interface :(
> Anyway the bug is real on dora branch.

Which branch did you test it?

You shouldn't say for backport something you didn't test.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dora][PATCH] e2fsprogs: Fix populate-extfs.sh
  2014-06-30 15:08       ` Otavio Salvador
@ 2014-06-30 15:11         ` Stephane Cerveau
  0 siblings, 0 replies; 6+ messages in thread
From: Stephane Cerveau @ 2014-06-30 15:11 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: Patches and discussions about the oe-core layer

Dear Otavio,

I have been testing on dora branch.
I havent been testing on master and daisy, my mistake :(

On 06/30/2014 05:08 PM, Otavio Salvador wrote:
> On Mon, Jun 30, 2014 at 12:06 PM, Stephane Cerveau
> <scerveau@connected-labs.com> wrote:
>> Sorry i have been fooled by the poky web interface :(
>> Anyway the bug is real on dora branch.
> Which branch did you test it?
>
> You shouldn't say for backport something you didn't test.
>



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-06-30 15:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-30 14:18 [dora][PATCH] e2fsprogs: Fix populate-extfs.sh Stéphane Cerveau
2014-06-30 14:20 ` Stephane Cerveau
2014-06-30 14:51   ` Richard Purdie
2014-06-30 15:06     ` Stephane Cerveau
2014-06-30 15:08       ` Otavio Salvador
2014-06-30 15:11         ` Stephane Cerveau

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox