From: Saul Wold <sgw@linux.intel.com>
To: Sujith H <sujith.h@gmail.com>, openembedded-core@lists.openembedded.org
Cc: Sujith H <Sujith_Haridasan@mentor.com>
Subject: Re: [PATCH] opkg-utils: allow disabling update-alternatives
Date: Fri, 08 Aug 2014 11:11:34 -0700 [thread overview]
Message-ID: <53E512D6.2070103@linux.intel.com> (raw)
In-Reply-To: <1407490645-15678-1-git-send-email-sujith.h@gmail.com>
On 08/08/2014 02:37 AM, Sujith H wrote:
> From: Sujith H <Sujith_Haridasan@mentor.com>
>
> This is needed to deal with the situation where we're using ipk packaging, so
> opkg-utils must be built regardless of what update-alternatives provider we
> prefer. The downside to the current implementation is the need to adjust
> PACKAGECONFIG as well as PREFERRED_PROVIDER, but it is more explicit that way.
>
> Signed-off-by: Christopher Larson <kergoth@gmail.com>
> Signed-off-by: Sujith H <Sujith_Haridasan@mentor.com>
> ---
> meta/recipes-devtools/opkg-utils/opkg-utils_git.bb | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/opkg-utils/opkg-utils_git.bb b/meta/recipes-devtools/opkg-utils/opkg-utils_git.bb
> index 693c216..287bf53 100644
> --- a/meta/recipes-devtools/opkg-utils/opkg-utils_git.bb
> +++ b/meta/recipes-devtools/opkg-utils/opkg-utils_git.bb
> @@ -19,11 +19,15 @@ TARGET_CC_ARCH += "${LDFLAGS}"
> PYTHONRDEPS = "python python-shell python-io python-math python-crypt python-logging python-fcntl python-subprocess python-pickle python-compression python-textutils python-stringold"
> PYTHONRDEPS_class-native = ""
>
> -PACKAGECONFIG = "python"
> +PACKAGECONFIG = "python update-alternatives"
> PACKAGECONFIG[python] = ",,,${PYTHONRDEPS}"
> +PACKAGECONFIG[update-alternatives] = ",,,"
>
> do_install() {
> oe_runmake PREFIX=${prefix} DESTDIR=${D} install
> + if ${@'true' if 'update-alternatives' not in PACKAGECONFIG.split() else 'false'}; then
> + rm -f "${D}${bindir}/update-alternatives"
> + fi
Would @bb.utils.contains() be better here? I think that is the correct
thing to use.
Sau!
> }
>
> PACKAGES =+ "update-alternatives-opkg"
>
next prev parent reply other threads:[~2014-08-08 18:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 9:37 [PATCH] opkg-utils: allow disabling update-alternatives Sujith H
2014-08-08 18:11 ` Saul Wold [this message]
2014-08-11 10:16 ` sujith h
-- strict thread matches above, loose matches on Subject: below --
2014-08-11 10:12 Sujith H
2014-08-07 9:24 Sujith H
2014-08-07 9:31 ` sujith h
2014-08-07 19:36 ` Saul Wold
2014-08-06 12:04 Sujith H
2014-08-06 12:38 ` Paul Eggleton
2014-08-06 13:28 ` sujith h
2014-08-06 13:53 ` Paul Eggleton
2014-08-06 12:00 Sujith H
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E512D6.2070103@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=Sujith_Haridasan@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sujith.h@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox