Re: [OE-core] [meta][dunfell][PATCH] busybox: Make high ASCII chars printable

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2023-03-29 at 12:17 +0530, nikhil wrote:
> Currently busybox utilty "ls" fails to display filenames contains
> UTF-8 characters and replaces with "?".
> 
> Steps to reproduce:
> bin/busybox touch utf_test-Ü
> bin/busybox ls utf_test-* > sample.log
> bin/busybox cat sample.log
> utf_test-??
> bin/busybox hexdump -C sample.log | grep "c3 9c"
> 
> Therefore, above hexdump command is unable to find matching hex value
> for the umlaute character.
> Hence, change the libbb's printable_string() function to allow high ASCII
> characters so that unicode filenames are displayed correctly.
> This issue is not observed in upstream busybox.
> 
> Signed-off-by: Sana Kazi <Sana.Kazi@kpit.com>
> Signed-off-by: Sana Kazi <sanakazisk19@gmail.com>
> Signed-off-by: Nikhil R <nikhilar2410@gmail.com>
> ---
>  .../270-libbb_make_unicode_printable.patch    | 39 +++++++++++++++++++
>  meta/recipes-core/busybox/busybox_1.31.1.bb   |  1 +
>  2 files changed, 40 insertions(+)
>  create mode 100644 meta/recipes-core/busybox/busybox/270-libbb_make_unicode_printable.patch
> 
> diff --git a/meta/recipes-core/busybox/busybox/270-libbb_make_unicode_printable.patch b/meta/recipes-core/busybox/busybox/270-libbb_make_unicode_printable.patch
> new file mode 100644
> index 0000000000..001d2847fe
> --- /dev/null
> +++ b/meta/recipes-core/busybox/busybox/270-libbb_make_unicode_printable.patch
> @@ -0,0 +1,39 @@
> +busybox: make high ASCII chars printable (#7993)
> +
> +Currently busybox utils like "ls" fail to display filenames containing UTF-8
> +characters, replacing any special characters with "?".
> +
> +Change libbb's printable_string() function to allow high ASCII characters so
> +that unicode filenames are displayed correctls.
> +
> +Signed-off-by: Jo-Philipp Wich <jow@openwrt.org>
> +Upstream-Status: Pending [https://git.openwrt.org/?p=openwrt/svn-archive/archive.git;a=patch;h=bbca780ca657d894fc457cac8eaaaec9d414bfc8]
> +

Has the patch been submitted to busybox? The upstream we refer to here
is really busybox. The link to openwrt is helpful but we should limit
to any submission to busybox itself for the purposes of upstream-
status.

Cheers,

Richard