public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Michael Opdenacker <michael.opdenacker@bootlin.com>
To: nikhil <nikhilar2410@gmail.com>,
	openembedded-core@lists.openembedded.org, sanak@kpit.com
Cc: ranjitsinh.rathod@kpit.com, Sana Kazi <Sana.Kazi@kpit.com>,
	Sana Kazi <sanakazisk19@gmail.com>
Subject: Re: [OE-core] [meta][dunfell][PATCH] busybox: Make high ASCII chars printable
Date: Thu, 30 Mar 2023 10:48:16 +0200	[thread overview]
Message-ID: <67ba133e-e51e-f586-4134-96ab921b7230@bootlin.com> (raw)
In-Reply-To: <20230329064717.2486576-1-nikhilar2410@gmail.com>

Hi Nikhil,

On 29.03.23 at 08:47, nikhil wrote:
> Currently busybox utilty "ls" fails to display filenames contains
> UTF-8 characters and replaces with "?".
>
> Steps to reproduce:
> bin/busybox touch utf_test-Ü
> bin/busybox ls utf_test-* > sample.log
> bin/busybox cat sample.log
> utf_test-??
> bin/busybox hexdump -C sample.log | grep "c3 9c"
>
> Therefore, above hexdump command is unable to find matching hex value
> for the umlaute character.
> Hence, change the libbb's printable_string() function to allow high ASCII
> characters so that unicode filenames are displayed correctly.
> This issue is not observed in upstream busybox.
>
> Signed-off-by: Sana Kazi <Sana.Kazi@kpit.com>
> Signed-off-by: Sana Kazi <sanakazisk19@gmail.com>
> Signed-off-by: Nikhil R <nikhilar2410@gmail.com>
> ---
>   .../270-libbb_make_unicode_printable.patch    | 39 +++++++++++++++++++
>   meta/recipes-core/busybox/busybox_1.31.1.bb   |  1 +
>   2 files changed, 40 insertions(+)
>   create mode 100644 meta/recipes-core/busybox/busybox/270-libbb_make_unicode_printable.patch


Thanks for the patch!

There's an issue with your e-mail identity. You should add one thing to 
your git configuration, so that your patches are given an "Author" field 
which matches your "Signed-off-by" information. See 
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Fixing_your_From_identity 
for details.

Thanks in advance
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



      parent reply	other threads:[~2023-03-30  8:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29  6:47 [meta][dunfell][PATCH] busybox: Make high ASCII chars printable Nikhil R
2023-03-29  7:20 ` [OE-core] " Richard Purdie
2023-03-29 18:07   ` Khem Raj
2023-03-30  8:48 ` Michael Opdenacker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67ba133e-e51e-f586-4134-96ab921b7230@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=Sana.Kazi@kpit.com \
    --cc=nikhilar2410@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ranjitsinh.rathod@kpit.com \
    --cc=sanak@kpit.com \
    --cc=sanakazisk19@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox