Re: [PATCH 8/9] bootchart2: no bashism in bootchartd.in

[Robert Yang <liezhi.yang@windriver.com>]

On 08/30/2014 01:01 AM, Max Eliaser wrote:
> Would you be okay with me sending this one upstream? I think it's a
> worthwhile modification.


Yes, of course, thanks for sending.

// Robert

>
> -Max
>
> On Wed, 2014-08-27 at 08:57 -0700, Robert Yang wrote:
>> So use /bin/sh
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   .../bootchart2/bootchartd-no-bashism.patch         |   27 ++++++++++++++++++++
>>   meta/recipes-devtools/bootchart2/bootchart2_git.bb |    6 +++--
>>   2 files changed, 31 insertions(+), 2 deletions(-)
>>   create mode 100644 meta/recipes-devtools/bootchart2/bootchart2/bootchartd-no-bashism.patch
>>
>> diff --git a/meta/recipes-devtools/bootchart2/bootchart2/bootchartd-no-bashism.patch b/meta/recipes-devtools/bootchart2/bootchart2/bootchartd-no-bashism.patch
>> new file mode 100644
>> index 0000000..b013995
>> --- /dev/null
>> +++ b/meta/recipes-devtools/bootchart2/bootchart2/bootchartd-no-bashism.patch
>> @@ -0,0 +1,27 @@
>> +From ffb5bae5d588aaea6325623462a8070a04767196 Mon Sep 17 00:00:00 2001
>> +From: Robert Yang <liezhi.yang@windriver.com>
>> +Date: Thu, 14 Aug 2014 08:33:28 -0700
>> +Subject: [PATCH] bootchartd.in: no bashism
>> +
>> +No bashism in bootchartd.in, so use /bin/sh.
>> +
>> +Upstream-Status: Pending
>> +
>> +Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> +---
>> + bootchartd.in |    2 +-
>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>> +
>> +diff --git a/bootchartd.in b/bootchartd.in
>> +index a408bab..064f6a4 100755
>> +--- a/bootchartd.in
>> ++++ b/bootchartd.in
>> +@@ -1,4 +1,4 @@
>> +-#!/bin/bash
>> ++#!/bin/sh
>> + #
>> + # Bootchart logger script
>> + # Ziga Mahkovec  <ziga.mahkovec@klika.si>
>> +--
>> +1.7.9.5
>> +
>> diff --git a/meta/recipes-devtools/bootchart2/bootchart2_git.bb b/meta/recipes-devtools/bootchart2/bootchart2_git.bb
>> index 4116304..04fb901 100644
>> --- a/meta/recipes-devtools/bootchart2/bootchart2_git.bb
>> +++ b/meta/recipes-devtools/bootchart2/bootchart2_git.bb
>> @@ -91,8 +91,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=44ac4678311254db62edf8fd39cb8124"
>>   # one commit beyond 1.14.6 for a systemd-related bugfix
>>   PV = "0.14.6+git${SRCPV}"
>>
>> -SRC_URI = "git://github.com/mmeeks/bootchart.git"
>> -SRC_URI += "file://bootchartd_stop.sh"
>> +SRC_URI = "git://github.com/mmeeks/bootchart.git \
>> +           file://bootchartd_stop.sh \
>> +           file://bootchartd-no-bashism.patch \
>> +          "
>>
>>   SRCREV = "b65ed43b0ae832080fb728245de9ef1a4b48d8b5"
>>
>> --
>> 1.7.9.5
>>
>
>
>
>