* [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP
@ 2014-09-15 8:27 rongqing.li
2014-09-15 14:32 ` Burton, Ross
2014-09-16 9:46 ` Burton, Ross
0 siblings, 2 replies; 8+ messages in thread
From: rongqing.li @ 2014-09-15 8:27 UTC (permalink / raw)
To: openembedded-core, tudor.florea
From: Roy Li <rongqing.li@windriver.com>
Setting INHIBIT_PACKAGE_STRIP is added by 61cb45869c[kmod: ptest fixes], but I
can not reproduce the described issue, and seems it make wrong logical [
when enable ptest, INHIBIT_PACKAGE_STRIP is always 1; and when disable ptest,
INHIBIT_PACKAGE_STRIP is always 0]
Cc: Tudor Florea <tudor.florea@enea.com>
Signed-off-by: Roy Li <rongqing.li@windriver.com>
---
meta/recipes-kernel/kmod/kmod_git.bb | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/recipes-kernel/kmod/kmod_git.bb b/meta/recipes-kernel/kmod/kmod_git.bb
index d4c21a4..9dd5867 100644
--- a/meta/recipes-kernel/kmod/kmod_git.bb
+++ b/meta/recipes-kernel/kmod/kmod_git.bb
@@ -44,7 +44,6 @@ do_compile_ptest () {
oe_runmake buildtest-TESTS rootfs
}
-INHIBIT_PACKAGE_STRIP = "${@bb.utils.contains("DISTRO_FEATURES", "ptest", "1", "0", d)}"
INSANE_SKIP_${PN}-ptest = "arch"
inherit update-alternatives
--
1.7.10.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP
2014-09-15 8:27 [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP rongqing.li
@ 2014-09-15 14:32 ` Burton, Ross
2014-09-17 10:11 ` Tudor Florea
2014-09-16 9:46 ` Burton, Ross
1 sibling, 1 reply; 8+ messages in thread
From: Burton, Ross @ 2014-09-15 14:32 UTC (permalink / raw)
To: rongqing.li@windriver.com; +Cc: OE-core
On 15 September 2014 09:27, <rongqing.li@windriver.com> wrote:
> From: Roy Li <rongqing.li@windriver.com>
>
> Setting INHIBIT_PACKAGE_STRIP is added by 61cb45869c[kmod: ptest fixes], but I
> can not reproduce the described issue, and seems it make wrong logical [
> when enable ptest, INHIBIT_PACKAGE_STRIP is always 1; and when disable ptest,
> INHIBIT_PACKAGE_STRIP is always 0]
>
> Cc: Tudor Florea <tudor.florea@enea.com>
As Tudor added this I'd love to hear from them about this, but I can
confirm that this patch doesn't cause warnings with ptest enabled.
Ross
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP
2014-09-15 14:32 ` Burton, Ross
@ 2014-09-17 10:11 ` Tudor Florea
2014-09-17 23:11 ` Khem Raj
0 siblings, 1 reply; 8+ messages in thread
From: Tudor Florea @ 2014-09-17 10:11 UTC (permalink / raw)
To: Burton, Ross, rongqing.li@windriver.com; +Cc: OE-core
Hi
> -----Original Message-----
> From: Burton, Ross [mailto:ross.burton@intel.com]
> Sent: Monday, September 15, 2014 17:32
> To: rongqing.li@windriver.com
> Cc: OE-core; Tudor Florea
> Subject: Re: [OE-core] [PATCH] kmod: remove the setting of
> INHIBIT_PACKAGE_STRIP
>
> On 15 September 2014 09:27, <rongqing.li@windriver.com> wrote:
> > From: Roy Li <rongqing.li@windriver.com>
> >
> > Setting INHIBIT_PACKAGE_STRIP is added by 61cb45869c[kmod: ptest
> fixes], but I
> > can not reproduce the described issue, and seems it make wrong logical [
> > when enable ptest, INHIBIT_PACKAGE_STRIP is always 1; and when disable
> ptest,
> > INHIBIT_PACKAGE_STRIP is always 0]
> >
> > Cc: Tudor Florea <tudor.florea@enea.com>
>
> As Tudor added this I'd love to hear from them about this, but I can
> confirm that this patch doesn't cause warnings with ptest enabled.
>
[Tudor Florea] It is hard to remember the exact rationale at this moment that the comment should be self-explanatory:
"Since kmod test files contain kernel modules for many different architectures, strip and arch gets confused and throws errors"
It means nothing if a specific platform doesn't exhibit the behavior. Kmod ptest attempts to load a precompiled (and unstripped for that matter) inappropriate module and verify this is not possible. I still think we should not remove the line (e.g. we should not alter kmod precompiled modules from ptest).
Regards,
Tudor.
> Ross
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP
2014-09-17 10:11 ` Tudor Florea
@ 2014-09-17 23:11 ` Khem Raj
0 siblings, 0 replies; 8+ messages in thread
From: Khem Raj @ 2014-09-17 23:11 UTC (permalink / raw)
To: Tudor Florea; +Cc: OE-core
On Wed, Sep 17, 2014 at 3:11 AM, Tudor Florea <Tudor.Florea@enea.com> wrote:
> "Since kmod test files contain kernel modules for many different architectures, strip and arch gets confused and throws errors"
> It means nothing if a specific platform doesn't exhibit the behavior. Kmod ptest attempts to load a precompiled (and unstripped for that matter) inappropriate module and verify this is not possible. I still think we should not remove the line (e.g. we should not alter kmod precompiled modules from ptest).
kmod should use strip and not cross-strip then
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP
2014-09-15 8:27 [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP rongqing.li
2014-09-15 14:32 ` Burton, Ross
@ 2014-09-16 9:46 ` Burton, Ross
2014-09-17 0:25 ` Rongqing Li
1 sibling, 1 reply; 8+ messages in thread
From: Burton, Ross @ 2014-09-16 9:46 UTC (permalink / raw)
To: rongqing.li@windriver.com; +Cc: OE-core
On 15 September 2014 09:27, <rongqing.li@windriver.com> wrote:
> Setting INHIBIT_PACKAGE_STRIP is added by 61cb45869c[kmod: ptest fixes], but I
> can not reproduce the described issue, and seems it make wrong logical [
> when enable ptest, INHIBIT_PACKAGE_STRIP is always 1; and when disable ptest,
> INHIBIT_PACKAGE_STRIP is always 0]
I take my comment back:
ERROR: runstrip: ''arm-poky-linux-gnueabi-strip' --strip-debug
--remove-section=.comment --remove-section=.note --preserve-dates
'/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm/build/build/tmp/work/armv5te-poky-linux-gnueabi/kmod/18+gitAUTOINC+ae58de0fcb-r0/package/usr/lib/kmod/ptest/testsuite/rootfs/test-dependencies/lib/modules/4.0.20-kmod/kernel/fs/mbcache.ko''
strip command failed
The autobuilder failed dramatically on this.
Instead of inhibiting the strip globally, I wonder if there's a way to
avoid stripping the test suite.
Ross
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP
2014-09-16 9:46 ` Burton, Ross
@ 2014-09-17 0:25 ` Rongqing Li
2014-09-17 7:23 ` Richard Purdie
0 siblings, 1 reply; 8+ messages in thread
From: Rongqing Li @ 2014-09-17 0:25 UTC (permalink / raw)
To: Burton, Ross; +Cc: OE-core
On 09/16/2014 05:46 PM, Burton, Ross wrote:
> On 15 September 2014 09:27, <rongqing.li@windriver.com> wrote:
>> Setting INHIBIT_PACKAGE_STRIP is added by 61cb45869c[kmod: ptest fixes], but I
>> can not reproduce the described issue, and seems it make wrong logical [
>> when enable ptest, INHIBIT_PACKAGE_STRIP is always 1; and when disable ptest,
>> INHIBIT_PACKAGE_STRIP is always 0]
>
> I take my comment back:
>
> ERROR: runstrip: ''arm-poky-linux-gnueabi-strip' --strip-debug
> --remove-section=.comment --remove-section=.note --preserve-dates
> '/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm/build/build/tmp/work/armv5te-poky-linux-gnueabi/kmod/18+gitAUTOINC+ae58de0fcb-r0/package/usr/lib/kmod/ptest/testsuite/rootfs/test-dependencies/lib/modules/4.0.20-kmod/kernel/fs/mbcache.ko''
> strip command failed
>
> The autobuilder failed dramatically on this.
>
> Instead of inhibiting the strip globally, I wonder if there's a way to
> avoid stripping the test suite.
>
> Ross
>
OK, I will see it
-Roy
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP
2014-09-17 0:25 ` Rongqing Li
@ 2014-09-17 7:23 ` Richard Purdie
2014-09-17 7:32 ` Rongqing Li
0 siblings, 1 reply; 8+ messages in thread
From: Richard Purdie @ 2014-09-17 7:23 UTC (permalink / raw)
To: Rongqing Li; +Cc: OE-core
On Wed, 2014-09-17 at 08:25 +0800, Rongqing Li wrote:
>
> On 09/16/2014 05:46 PM, Burton, Ross wrote:
> > On 15 September 2014 09:27, <rongqing.li@windriver.com> wrote:
> >> Setting INHIBIT_PACKAGE_STRIP is added by 61cb45869c[kmod: ptest fixes], but I
> >> can not reproduce the described issue, and seems it make wrong logical [
> >> when enable ptest, INHIBIT_PACKAGE_STRIP is always 1; and when disable ptest,
> >> INHIBIT_PACKAGE_STRIP is always 0]
> >
> > I take my comment back:
> >
> > ERROR: runstrip: ''arm-poky-linux-gnueabi-strip' --strip-debug
> > --remove-section=.comment --remove-section=.note --preserve-dates
> > '/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm/build/build/tmp/work/armv5te-poky-linux-gnueabi/kmod/18+gitAUTOINC+ae58de0fcb-r0/package/usr/lib/kmod/ptest/testsuite/rootfs/test-dependencies/lib/modules/4.0.20-kmod/kernel/fs/mbcache.ko''
> > strip command failed
> >
> > The autobuilder failed dramatically on this.
> >
> > Instead of inhibiting the strip globally, I wonder if there's a way to
> > avoid stripping the test suite.
> >
> > Ross
> >
>
> OK, I will see it
If there isn't, we should perhaps add something...
Cheers,
Richard
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP
2014-09-17 7:23 ` Richard Purdie
@ 2014-09-17 7:32 ` Rongqing Li
0 siblings, 0 replies; 8+ messages in thread
From: Rongqing Li @ 2014-09-17 7:32 UTC (permalink / raw)
To: Richard Purdie; +Cc: OE-core
On 09/17/2014 03:23 PM, Richard Purdie wrote:
> On Wed, 2014-09-17 at 08:25 +0800, Rongqing Li wrote:
>>
>> On 09/16/2014 05:46 PM, Burton, Ross wrote:
>>> On 15 September 2014 09:27, <rongqing.li@windriver.com> wrote:
>>>> Setting INHIBIT_PACKAGE_STRIP is added by 61cb45869c[kmod: ptest fixes], but I
>>>> can not reproduce the described issue, and seems it make wrong logical [
>>>> when enable ptest, INHIBIT_PACKAGE_STRIP is always 1; and when disable ptest,
>>>> INHIBIT_PACKAGE_STRIP is always 0]
>>>
>>> I take my comment back:
>>>
>>> ERROR: runstrip: ''arm-poky-linux-gnueabi-strip' --strip-debug
>>> --remove-section=.comment --remove-section=.note --preserve-dates
>>> '/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm/build/build/tmp/work/armv5te-poky-linux-gnueabi/kmod/18+gitAUTOINC+ae58de0fcb-r0/package/usr/lib/kmod/ptest/testsuite/rootfs/test-dependencies/lib/modules/4.0.20-kmod/kernel/fs/mbcache.ko''
>>> strip command failed
>>>
>>> The autobuilder failed dramatically on this.
>>>
>>> Instead of inhibiting the strip globally, I wonder if there's a way to
>>> avoid stripping the test suite.
>>>
>>> Ross
>>>
>>
>> OK, I will see it
>
> If there isn't, we should perhaps add something...
>
Could you send a patch to fix/implement it? thanks.
-Roy
> Cheers,
>
> Richard
>
>
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-09-17 23:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-15 8:27 [PATCH] kmod: remove the setting of INHIBIT_PACKAGE_STRIP rongqing.li
2014-09-15 14:32 ` Burton, Ross
2014-09-17 10:11 ` Tudor Florea
2014-09-17 23:11 ` Khem Raj
2014-09-16 9:46 ` Burton, Ross
2014-09-17 0:25 ` Rongqing Li
2014-09-17 7:23 ` Richard Purdie
2014-09-17 7:32 ` Rongqing Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox