Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Peter A. Bigot" <pab@pabigot.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kernel.bbclass: use one package split for all firmware filename extensions
Date: Tue, 23 Sep 2014 12:06:07 -0500	[thread overview]
Message-ID: <5421A87F.1080000@pabigot.com> (raw)
In-Reply-To: <20140923163827.GB2480@denix.org>

On 09/23/2014 11:38 AM, Denys Dmytriyenko wrote:
> On Sun, Sep 21, 2014 at 01:08:55PM +0200, Carlos Rafael Giani wrote:
>> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
>> ---
>>   meta/classes/kernel.bbclass | 5 +----
>>   1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 4710719..78b33ce 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -384,10 +384,7 @@ pkg_postrm_kernel-image () {
>>   PACKAGESPLITFUNCS_prepend = "split_kernel_packages "
>>   
>>   python split_kernel_packages () {
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> +    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.(bin|fw|cis|dsp)$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> Can we also add .elf to the list? Thanks!

Related to that: I noticed that the meta-ti kernel adds a firmware blob 
am335x-pm-firmware.elf.  This causes QA errors when building that kernel 
with linux-yocto because the .elf file is stripped and the unstripped 
debug version isn't packaged.

The existing linux-firmware repository doesn't include any elf format 
files.  Perhaps the TI module could be updated to load the .bin version 
of the file instead.

Peter



      reply	other threads:[~2014-09-23 17:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-21 11:08 [PATCH] kernel.bbclass: use one package split for all firmware filename extensions Carlos Rafael Giani
2014-09-23 16:38 ` Denys Dmytriyenko
2014-09-23 17:06   ` Peter A. Bigot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5421A87F.1080000@pabigot.com \
    --to=pab@pabigot.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox