Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] kernel.bbclass: use one package split for all firmware filename extensions
@ 2014-09-21 11:08 Carlos Rafael Giani
  2014-09-23 16:38 ` Denys Dmytriyenko
  0 siblings, 1 reply; 3+ messages in thread
From: Carlos Rafael Giani @ 2014-09-21 11:08 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
 meta/classes/kernel.bbclass | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 4710719..78b33ce 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -384,10 +384,7 @@ pkg_postrm_kernel-image () {
 PACKAGESPLITFUNCS_prepend = "split_kernel_packages "
 
 python split_kernel_packages () {
-    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
-    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
-    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
-    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
+    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.(bin|fw|cis|dsp)$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
 }
 
 do_strip() {
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] kernel.bbclass: use one package split for all firmware filename extensions
  2014-09-21 11:08 [PATCH] kernel.bbclass: use one package split for all firmware filename extensions Carlos Rafael Giani
@ 2014-09-23 16:38 ` Denys Dmytriyenko
  2014-09-23 17:06   ` Peter A. Bigot
  0 siblings, 1 reply; 3+ messages in thread
From: Denys Dmytriyenko @ 2014-09-23 16:38 UTC (permalink / raw)
  To: Carlos Rafael Giani; +Cc: openembedded-core

On Sun, Sep 21, 2014 at 01:08:55PM +0200, Carlos Rafael Giani wrote:
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> ---
>  meta/classes/kernel.bbclass | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 4710719..78b33ce 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -384,10 +384,7 @@ pkg_postrm_kernel-image () {
>  PACKAGESPLITFUNCS_prepend = "split_kernel_packages "
>  
>  python split_kernel_packages () {
> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> +    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.(bin|fw|cis|dsp)$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')

Can we also add .elf to the list? Thanks!


>  }
>  
>  do_strip() {
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kernel.bbclass: use one package split for all firmware filename extensions
  2014-09-23 16:38 ` Denys Dmytriyenko
@ 2014-09-23 17:06   ` Peter A. Bigot
  0 siblings, 0 replies; 3+ messages in thread
From: Peter A. Bigot @ 2014-09-23 17:06 UTC (permalink / raw)
  To: openembedded-core

On 09/23/2014 11:38 AM, Denys Dmytriyenko wrote:
> On Sun, Sep 21, 2014 at 01:08:55PM +0200, Carlos Rafael Giani wrote:
>> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
>> ---
>>   meta/classes/kernel.bbclass | 5 +----
>>   1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 4710719..78b33ce 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -384,10 +384,7 @@ pkg_postrm_kernel-image () {
>>   PACKAGESPLITFUNCS_prepend = "split_kernel_packages "
>>   
>>   python split_kernel_packages () {
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.bin$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.fw$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.cis$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> -    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.dsp$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
>> +    do_split_packages(d, root='/lib/firmware', file_regex='^(.*)\.(bin|fw|cis|dsp)$', output_pattern='kernel-firmware-%s', description='Firmware for %s', recursive=True, extra_depends='')
> Can we also add .elf to the list? Thanks!

Related to that: I noticed that the meta-ti kernel adds a firmware blob 
am335x-pm-firmware.elf.  This causes QA errors when building that kernel 
with linux-yocto because the .elf file is stripped and the unstripped 
debug version isn't packaged.

The existing linux-firmware repository doesn't include any elf format 
files.  Perhaps the TI module could be updated to load the .bin version 
of the file instead.

Peter



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-09-23 17:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-21 11:08 [PATCH] kernel.bbclass: use one package split for all firmware filename extensions Carlos Rafael Giani
2014-09-23 16:38 ` Denys Dmytriyenko
2014-09-23 17:06   ` Peter A. Bigot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox