* [PATCH] kernel-yocto.bbclass: Fixup shell condition test syntax error
@ 2014-09-26 19:04 Darren Hart
2014-09-26 19:06 ` Bruce Ashfield
0 siblings, 1 reply; 2+ messages in thread
From: Darren Hart @ 2014-09-26 19:04 UTC (permalink / raw)
To: openembedded-core; +Cc: Darren Hart
A warning is issued when run about an unexpected operator due to a
syntax error with an extra if empedded in the shell conditional. Remove
the extra if.
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Cc: Bruce Ashfield <bruce.ashfield@windriver.com>
---
meta/classes/kernel-yocto.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index 929d64a..7718f9a 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -296,7 +296,7 @@ do_validate_branches() {
force_srcrev="${SRCREV}"
else
git cat-file -t ${machine_srcrev} > /dev/null
- if [ if $? -ne 0 ]; then
+ if [ $? -ne 0 ]; then
bberror "${machine_srcrev} is not a valid commit ID."
bbfatal "The kernel source tree may be out of sync"
fi
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel-yocto.bbclass: Fixup shell condition test syntax error
2014-09-26 19:04 [PATCH] kernel-yocto.bbclass: Fixup shell condition test syntax error Darren Hart
@ 2014-09-26 19:06 ` Bruce Ashfield
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Ashfield @ 2014-09-26 19:06 UTC (permalink / raw)
To: Darren Hart, openembedded-core
On 14-09-26 03:04 PM, Darren Hart wrote:
> A warning is issued when run about an unexpected operator due to a
> syntax error with an extra if empedded in the shell conditional. Remove
> the extra if.
ouch. How on earth did that survive ?
Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> Cc: Bruce Ashfield <bruce.ashfield@windriver.com>
> ---
> meta/classes/kernel-yocto.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> index 929d64a..7718f9a 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -296,7 +296,7 @@ do_validate_branches() {
> force_srcrev="${SRCREV}"
> else
> git cat-file -t ${machine_srcrev} > /dev/null
> - if [ if $? -ne 0 ]; then
> + if [ $? -ne 0 ]; then
> bberror "${machine_srcrev} is not a valid commit ID."
> bbfatal "The kernel source tree may be out of sync"
> fi
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-26 19:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-26 19:04 [PATCH] kernel-yocto.bbclass: Fixup shell condition test syntax error Darren Hart
2014-09-26 19:06 ` Bruce Ashfield
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox