From: Darren Hart <dvhart@linux.intel.com>
To: Drew Moseley <drew_moseley@mentor.com>,
openembedded-core@lists.openembedded.org
Cc: arindam.nath@amd.com, Ravikiran_Polepalli@mentor.com
Subject: Re: [PATCH] poky: daisy: grub: add cmdpath to grub configuration file
Date: Wed, 22 Oct 2014 14:26:44 -0700 [thread overview]
Message-ID: <54482114.40108@linux.intel.com> (raw)
In-Reply-To: <1413554888-31319-1-git-send-email-drew_moseley@mentor.com>
On 10/17/14 7:08, Drew Moseley wrote:
> From: Arindam Nath <arindam.nath@amd.com>
>
> An issue was found where when yocto is installed to a hard disk
> from a live USB key, no matter what boot order was selected in
> the BIOS menu, the grub menu of the USB key would always show
> up. The issue was narrowed down to the way grub configuration
> file gets embedded into the standalone bootx64.efi image.
>
> The commit prepends ($cmdpath) to the search path for grub.cfg,
> thus making sure the UEFI environment itself sets this to the
> correct device path. This in-turn lets the grub.cfg of the boot
> device to be loaded.
>
> Signed-off-by: Arindam Nath <arindam.nath@amd.com>
> Reviewed-by: Drew Moseley <drew_moseley@mentor.com>
> Tested-by: Ravikiran Polepalli <Ravikiran_Polepalli@mentor.com>
This looks appropriate to me, and solves a problem I've heard echo'd
elsewhere. Thanks!
Acked-by: Darren Hart <dvhart@linux.intel.com>
> ---
> meta/recipes-bsp/grub/files/cfg | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-bsp/grub/files/cfg b/meta/recipes-bsp/grub/files/cfg
> index ffffe47..8ca53d2 100644
> --- a/meta/recipes-bsp/grub/files/cfg
> +++ b/meta/recipes-bsp/grub/files/cfg
> @@ -1,2 +1,2 @@
> -search.file /EFI/BOOT/grub.cfg root
> +search.file ($cmdpath)/EFI/BOOT/grub.cfg root
> set prefix=($root)/EFI/BOOT
>
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2014-10-22 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 14:08 [PATCH] poky: daisy: grub: add cmdpath to grub configuration file Drew Moseley
2014-10-20 14:30 ` Burton, Ross
2014-10-20 14:47 ` Moseley, Drew
2014-10-22 21:26 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54482114.40108@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=Ravikiran_Polepalli@mentor.com \
--cc=arindam.nath@amd.com \
--cc=drew_moseley@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox