[PATCH] poky: daisy: grub: add cmdpath to grub configuration file

[PATCH] poky: daisy: grub: add cmdpath to grub configuration file

[Drew Moseley]

From: Arindam Nath <arindam.nath@amd.com>

An issue was found where when yocto is installed to a hard disk
from a live USB key, no matter what boot order was selected in
the BIOS menu, the grub menu of the USB key would always show
up. The issue was narrowed down to the way grub configuration
file gets embedded into the standalone bootx64.efi image.

The commit prepends ($cmdpath) to the search path for grub.cfg,
thus making sure the UEFI environment itself sets this to the
correct device path. This in-turn lets the grub.cfg of the boot
device to be loaded.

Signed-off-by: Arindam Nath <arindam.nath@amd.com>
Reviewed-by: Drew Moseley <drew_moseley@mentor.com>
Tested-by: Ravikiran Polepalli <Ravikiran_Polepalli@mentor.com>
---
 meta/recipes-bsp/grub/files/cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-bsp/grub/files/cfg b/meta/recipes-bsp/grub/files/cfg
index ffffe47..8ca53d2 100644
--- a/meta/recipes-bsp/grub/files/cfg
+++ b/meta/recipes-bsp/grub/files/cfg
@@ -1,2 +1,2 @@
-search.file /EFI/BOOT/grub.cfg root
+search.file ($cmdpath)/EFI/BOOT/grub.cfg root
 set prefix=($root)/EFI/BOOT
-- 
1.9.1

Re: [PATCH] poky: daisy: grub: add cmdpath to grub configuration file

[Burton, Ross]

On 17 October 2014 15:08, Drew Moseley <drew_moseley@mentor.com> wrote:
> An issue was found where when yocto is installed to a hard disk
> from a live USB key, no matter what boot order was selected in
> the BIOS menu, the grub menu of the USB key would always show
> up. The issue was narrowed down to the way grub configuration
> file gets embedded into the standalone bootx64.efi image.
>
> The commit prepends ($cmdpath) to the search path for grub.cfg,
> thus making sure the UEFI environment itself sets this to the
> correct device path. This in-turn lets the grub.cfg of the boot
> device to be loaded.

Presumably this needs to go to master too?

Ross

Re: [PATCH] poky: daisy: grub: add cmdpath to grub configuration file

[Moseley, Drew]

On Oct 20, 2014, at 10:30 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 17 October 2014 15:08, Drew Moseley <drew_moseley@mentor.com> wrote:
>> An issue was found where when yocto is installed to a hard disk
>> from a live USB key, no matter what boot order was selected in
>> the BIOS menu, the grub menu of the USB key would always show
>> up. The issue was narrowed down to the way grub configuration
>> file gets embedded into the standalone bootx64.efi image.
>> 
>> The commit prepends ($cmdpath) to the search path for grub.cfg,
>> thus making sure the UEFI environment itself sets this to the
>> correct device path. This in-turn lets the grub.cfg of the boot
>> device to be loaded.
> 
> Presumably this needs to go to master too?
> 
> Ross

Yes, that would be best.  I guess the original subject was a bit misleading.  Apologies for that.  The intent is mainly to get this into master and, if possible, dizzy.  Getting it into daisy would be nice but I'm not sure it's a critical enough fix for that.

Thanks,
Drew

Re: [PATCH] poky: daisy: grub: add cmdpath to grub configuration file

[Darren Hart]

On 10/17/14 7:08, Drew Moseley wrote:
> From: Arindam Nath <arindam.nath@amd.com>
> 
> An issue was found where when yocto is installed to a hard disk
> from a live USB key, no matter what boot order was selected in
> the BIOS menu, the grub menu of the USB key would always show
> up. The issue was narrowed down to the way grub configuration
> file gets embedded into the standalone bootx64.efi image.
> 
> The commit prepends ($cmdpath) to the search path for grub.cfg,
> thus making sure the UEFI environment itself sets this to the
> correct device path. This in-turn lets the grub.cfg of the boot
> device to be loaded.
> 
> Signed-off-by: Arindam Nath <arindam.nath@amd.com>
> Reviewed-by: Drew Moseley <drew_moseley@mentor.com>
> Tested-by: Ravikiran Polepalli <Ravikiran_Polepalli@mentor.com>

This looks appropriate to me, and solves a problem I've heard echo'd
elsewhere. Thanks!

Acked-by: Darren Hart <dvhart@linux.intel.com>


> ---
>  meta/recipes-bsp/grub/files/cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/grub/files/cfg b/meta/recipes-bsp/grub/files/cfg
> index ffffe47..8ca53d2 100644
> --- a/meta/recipes-bsp/grub/files/cfg
> +++ b/meta/recipes-bsp/grub/files/cfg
> @@ -1,2 +1,2 @@
> -search.file /EFI/BOOT/grub.cfg root
> +search.file ($cmdpath)/EFI/BOOT/grub.cfg root
>  set prefix=($root)/EFI/BOOT
> 

-- 
Darren Hart
Intel Open Source Technology Center