Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] kmod: fix debuginfo is missing in shared library
@ 2014-10-21  8:16 Chong Lu
  2014-10-21  8:16 ` [PATCH 1/1] " Chong Lu
  0 siblings, 1 reply; 6+ messages in thread
From: Chong Lu @ 2014-10-21  8:16 UTC (permalink / raw)
  To: openembedded-core

The following changes since commit 924da20c6f2f183fa7e930e4c3c6b14c090acbe5:

  build-appliance-image: Update to dizzy head revision (2014-10-18 16:16:38 +0200)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib chonglu/kmod
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/kmod

Chong Lu (1):
  kmod: fix debuginfo is missing in shared library

 meta/recipes-kernel/kmod/kmod_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] kmod: fix debuginfo is missing in shared library
  2014-10-21  8:16 [PATCH 0/1] kmod: fix debuginfo is missing in shared library Chong Lu
@ 2014-10-21  8:16 ` Chong Lu
  2014-10-23 14:21   ` Burton, Ross
  0 siblings, 1 reply; 6+ messages in thread
From: Chong Lu @ 2014-10-21  8:16 UTC (permalink / raw)
  To: openembedded-core

The INHIBIT_PACKAGE_STRIP should be only for ptest package, else debuginfo will
be missing in shared library.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
 meta/recipes-kernel/kmod/kmod_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/kmod/kmod_git.bb b/meta/recipes-kernel/kmod/kmod_git.bb
index d4c21a4..ff58153 100644
--- a/meta/recipes-kernel/kmod/kmod_git.bb
+++ b/meta/recipes-kernel/kmod/kmod_git.bb
@@ -44,7 +44,7 @@ do_compile_ptest () {
         oe_runmake buildtest-TESTS rootfs
 }
 
-INHIBIT_PACKAGE_STRIP = "${@bb.utils.contains("DISTRO_FEATURES", "ptest", "1", "0", d)}"
+INHIBIT_PACKAGE_STRIP_${PN}-ptest = "${@bb.utils.contains("DISTRO_FEATURES", "ptest", "1", "0", d)}"
 INSANE_SKIP_${PN}-ptest = "arch"
 
 inherit update-alternatives
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] kmod: fix debuginfo is missing in shared library
  2014-10-21  8:16 ` [PATCH 1/1] " Chong Lu
@ 2014-10-23 14:21   ` Burton, Ross
  2014-10-23 17:02     ` Tudor Florea
  2014-10-24  6:28     ` Chong Lu
  0 siblings, 2 replies; 6+ messages in thread
From: Burton, Ross @ 2014-10-23 14:21 UTC (permalink / raw)
  To: Chong Lu; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On 21 October 2014 09:16, Chong Lu <Chong.Lu@windriver.com> wrote:

> -INHIBIT_PACKAGE_STRIP = "${@bb.utils.contains("DISTRO_FEATURES", "ptest",
> "1", "0", d)}"
> +INHIBIT_PACKAGE_STRIP_${PN}-ptest =
> "${@bb.utils.contains("DISTRO_FEATURES", "ptest", "1", "0", d)}"
>

Was this actually tested?

ERROR: runstrip: ''arm-poky-linux-gnueabi-strip' --strip-debug
--remove-section=.comment --remove-section=.note --preserve-dates
'/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm/build/build/tmp/work/armv5te-poky-linux-gnueabi/kmod/18+gitAUTOINC+ae58de0fcb-r0/package/usr/lib/kmod/ptest/testsuite/rootfs/test-depmod/detect-loop/lib/modules/4.4.4/kernel/moduleA.ko''
strip command failed

INHIBIT_PACKAGE_STRIP isn't a per-package variable as stripping happens
before the package-splitting.   Moving it to happen after splitting won't
be trivial as you'd need to know what package to put the resultant files
into.  Maybe we need a strip blacklist?

Ross

[-- Attachment #2: Type: text/html, Size: 1629 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] kmod: fix debuginfo is missing in shared library
  2014-10-23 14:21   ` Burton, Ross
@ 2014-10-23 17:02     ` Tudor Florea
  2014-10-24  6:30       ` Chong Lu
  2014-10-24  6:28     ` Chong Lu
  1 sibling, 1 reply; 6+ messages in thread
From: Tudor Florea @ 2014-10-23 17:02 UTC (permalink / raw)
  To: Burton, Ross, Chong Lu; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]

Hi,

From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Burton, Ross
Sent: Thursday, October 23, 2014 17:21
To: Chong Lu
Cc: OE-core
Subject: Re: [OE-core] [PATCH 1/1] kmod: fix debuginfo is missing in shared library


On 21 October 2014 09:16, Chong Lu <Chong.Lu@windriver.com<mailto:Chong.Lu@windriver.com>> wrote:
-INHIBIT_PACKAGE_STRIP = "${@bb.utils.contains(<mailto:$%7b@bb.utils.contains(>"DISTRO_FEATURES", "ptest", "1", "0", d)}"
+INHIBIT_PACKAGE_STRIP_${PN}-ptest = "${@bb.utils.contains(<mailto:$%7b@bb.utils.contains(>"DISTRO_FEATURES", "ptest", "1", "0", d)}"

Was this actually tested?

ERROR: runstrip: ''arm-poky-linux-gnueabi-strip' --strip-debug --remove-section=.comment --remove-section=.note --preserve-dates '/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm/build/build/tmp/work/armv5te-poky-linux-gnueabi/kmod/18+gitAUTOINC+ae58de0fcb-r0/package/usr/lib/kmod/ptest/testsuite/rootfs/test-depmod/detect-loop/lib/modules/4.4.4/kernel/moduleA.ko'' strip command failed

INHIBIT_PACKAGE_STRIP isn't a per-package variable as stripping happens before the package-splitting.   Moving it to happen after splitting won't be trivial as you'd need to know what package to put the resultant files into.  Maybe we need a strip blacklist?

Ross

One way to solve this is to pack the ptest “sample” files during install (in do_install_append) and unpack back when running ptest on target (in run-ptest). The downside of this is we add a dependency on tar.
Please let me know if it is acceptable and I’ll come with a patch for this.
Regards,
Tudor.


[-- Attachment #2: Type: text/html, Size: 6139 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] kmod: fix debuginfo is missing in shared library
  2014-10-23 14:21   ` Burton, Ross
  2014-10-23 17:02     ` Tudor Florea
@ 2014-10-24  6:28     ` Chong Lu
  1 sibling, 0 replies; 6+ messages in thread
From: Chong Lu @ 2014-10-24  6:28 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core


On 10/23/2014 10:21 PM, Burton, Ross wrote:
>
> On 21 October 2014 09:16, Chong Lu <Chong.Lu@windriver.com 
> <mailto:Chong.Lu@windriver.com>> wrote:
>
>     -INHIBIT_PACKAGE_STRIP = "${@bb.utils.contains("DISTRO_FEATURES",
>     "ptest", "1", "0", d)}"
>     +INHIBIT_PACKAGE_STRIP_${PN}-ptest =
>     "${@bb.utils.contains("DISTRO_FEATURES", "ptest", "1", "0", d)}"
>
>
> Was this actually tested?
>
> ERROR: runstrip: ''arm-poky-linux-gnueabi-strip' --strip-debug 
> --remove-section=.comment --remove-section=.note --preserve-dates 
> '/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm/build/build/tmp/work/armv5te-poky-linux-gnueabi/kmod/18+gitAUTOINC+ae58de0fcb-r0/package/usr/lib/kmod/ptest/testsuite/rootfs/test-depmod/detect-loop/lib/modules/4.4.4/kernel/moduleA.ko'' 
> strip command failed
>
> INHIBIT_PACKAGE_STRIP isn't a per-package variable as stripping 
> happens before the package-splitting.   Moving it to happen after 
> splitting won't be trivial as you'd need to know what package to put 
> the resultant files into.  Maybe we need a strip blacklist?
>
> Ross

Drop this one, I have send a v2.

Best Regards
Chong


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] kmod: fix debuginfo is missing in shared library
  2014-10-23 17:02     ` Tudor Florea
@ 2014-10-24  6:30       ` Chong Lu
  0 siblings, 0 replies; 6+ messages in thread
From: Chong Lu @ 2014-10-24  6:30 UTC (permalink / raw)
  To: Tudor Florea; +Cc: OE-core


On 10/24/2014 01:02 AM, Tudor Florea wrote:
>
> Hi,
>
> *From:*openembedded-core-bounces@lists.openembedded.org 
> [mailto:openembedded-core-bounces@lists.openembedded.org] *On Behalf 
> Of *Burton, Ross
> *Sent:* Thursday, October 23, 2014 17:21
> *To:* Chong Lu
> *Cc:* OE-core
> *Subject:* Re: [OE-core] [PATCH 1/1] kmod: fix debuginfo is missing in 
> shared library
>
> On 21 October 2014 09:16, Chong Lu <Chong.Lu@windriver.com 
> <mailto:Chong.Lu@windriver.com>> wrote:
>
>     -INHIBIT_PACKAGE_STRIP = "${@bb.utils.contains(
>     <mailto:$%7b@bb.utils.contains%28>"DISTRO_FEATURES", "ptest", "1",
>     "0", d)}"
>     +INHIBIT_PACKAGE_STRIP_${PN}-ptest = "${@bb.utils.contains(
>     <mailto:$%7b@bb.utils.contains%28>"DISTRO_FEATURES", "ptest", "1",
>     "0", d)}"
>
>
> Was this actually tested?
>
> ERROR: runstrip: ''arm-poky-linux-gnueabi-strip' --strip-debug 
> --remove-section=.comment --remove-section=.note --preserve-dates 
> '/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-arm/build/build/tmp/work/armv5te-poky-linux-gnueabi/kmod/18+gitAUTOINC+ae58de0fcb-r0/package/usr/lib/kmod/ptest/testsuite/rootfs/test-depmod/detect-loop/lib/modules/4.4.4/kernel/moduleA.ko'' 
> strip command failed
>
> INHIBIT_PACKAGE_STRIP isn't a per-package variable as stripping 
> happens before the package-splitting.   Moving it to happen after 
> splitting won't be trivial as you'd need to know what package to put 
> the resultant files into.  Maybe we need a strip blacklist?
>
> Ross
>
> *//*
>
> */One way to solve this is to pack the ptest “sample” files during 
> install (in do_install_append) and unpack back when running ptest on 
> target (in run-ptest). The downside of this is we add a dependency on 
> tar./*
>
> */Please let me know if it is acceptable and I’ll come with a patch 
> for this./*
>
> */Regards,/*
>
> */Tudor./*
>

Thanks for your suggestion, I have sent a v2.

Best Regards
Chong



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-10-24  6:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-21  8:16 [PATCH 0/1] kmod: fix debuginfo is missing in shared library Chong Lu
2014-10-21  8:16 ` [PATCH 1/1] " Chong Lu
2014-10-23 14:21   ` Burton, Ross
2014-10-23 17:02     ` Tudor Florea
2014-10-24  6:30       ` Chong Lu
2014-10-24  6:28     ` Chong Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox