[PATCH v2 0/1] kmod: fix debuginfo is missing in shared library

[PATCH v2 0/1] kmod: fix debuginfo is missing in shared library

[Chong Lu]

Change since v2:
pack kernel modules in test cases to avoid strip command failed

The following changes since commit ad065f94acb0bfb81e33935890a1db251d6e2979:

  ref-manual: Minor edits to variables. (2014-10-23 15:20:20 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib chonglu/kmod
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/kmod

Chong Lu (1):
  kmod: fix debuginfo is missing in shared library

 meta/recipes-kernel/kmod/kmod/run-ptest | 1 +
 meta/recipes-kernel/kmod/kmod_git.bb    | 9 ++++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

-- 
1.9.1

[PATCH V2 1/1] kmod: fix debuginfo is missing in shared library

[Chong Lu]

INHIBIT_PACKAGE_STRIP variable will make debuginfo lose in shared library.
Pack kernel modules in test cases to avoid strip command failed.

Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
 meta/recipes-kernel/kmod/kmod/run-ptest | 1 +
 meta/recipes-kernel/kmod/kmod_git.bb    | 9 ++++++++-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/kmod/kmod/run-ptest b/meta/recipes-kernel/kmod/kmod/run-ptest
index 37adec3..4ed8715 100755
--- a/meta/recipes-kernel/kmod/kmod/run-ptest
+++ b/meta/recipes-kernel/kmod/kmod/run-ptest
@@ -1,3 +1,4 @@
 #!/bin/sh
 touch testsuite/stamp-rootfs
+tar xf testmodule.tar
 make -k runtest-TESTS 2>/dev/null| grep -e ^PASS -e ^FAIL
diff --git a/meta/recipes-kernel/kmod/kmod_git.bb b/meta/recipes-kernel/kmod/kmod_git.bb
index d4c21a4..8a23ac4 100644
--- a/meta/recipes-kernel/kmod/kmod_git.bb
+++ b/meta/recipes-kernel/kmod/kmod_git.bb
@@ -34,6 +34,10 @@ do_install_append () {
         # install depmod.d file for search/ dir
         install -Dm644 "${WORKDIR}/depmod-search.conf" "${D}${base_libdir}/depmod.d/search.conf"
 
+        if ${@base_contains('DISTRO_FEATURES', 'ptest', 'true', 'false', d)}; then
+                find testsuite -name \*.ko -exec tar rf testmodule.tar {} \;
+                find testsuite -name \*.ko -exec rm -f {} \;
+        fi
 }
 
 do_compile_prepend() {
@@ -44,7 +48,10 @@ do_compile_ptest () {
         oe_runmake buildtest-TESTS rootfs
 }
 
-INHIBIT_PACKAGE_STRIP = "${@bb.utils.contains("DISTRO_FEATURES", "ptest", "1", "0", d)}"
+do_install_ptest () {
+        install testmodule.tar ${D}${PTEST_PATH}
+}
+
 INSANE_SKIP_${PN}-ptest = "arch"
 
 inherit update-alternatives
-- 
1.9.1

Re: [PATCH V2 1/1] kmod: fix debuginfo is missing in shared library

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

On 24 October 2014 07:25, Chong Lu <Chong.Lu@windriver.com> wrote:

> +++ b/meta/recipes-kernel/kmod/kmod/run-ptest
> @@ -1,3 +1,4 @@
>  #!/bin/sh
>  touch testsuite/stamp-rootfs
> +tar xf testmodule.tar
>  make -k runtest-TESTS 2>/dev/null| grep -e ^PASS -e ^FAIL
>

We should to make sure that the ptest scripts clean up after themselves, so
can you change this to delete the modules after the test has ran?

Ross

[-- Attachment #2: Type: text/html, Size: 810 bytes --]

Re: [PATCH V2 1/1] kmod: fix debuginfo is missing in shared library

[Chong Lu]

On 10/24/2014 07:08 PM, Burton, Ross wrote:
>
> On 24 October 2014 07:25, Chong Lu <Chong.Lu@windriver.com 
> <mailto:Chong.Lu@windriver.com>> wrote:
>
>     +++ b/meta/recipes-kernel/kmod/kmod/run-ptest
>     @@ -1,3 +1,4 @@
>      #!/bin/sh
>      touch testsuite/stamp-rootfs
>     +tar xf testmodule.tar
>      make -k runtest-TESTS 2>/dev/null| grep -e ^PASS -e ^FAIL
>
>
> We should to make sure that the ptest scripts clean up after 
> themselves, so can you change this to delete the modules after the 
> test has ran?
>
> Ross

OK, I will send a V2.

Best Regards
Chong