From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel-yocto.bbclass: fix shell syntax error
Date: Mon, 1 Dec 2014 12:25:45 -0500 [thread overview]
Message-ID: <547CA499.2050506@windriver.com> (raw)
In-Reply-To: <1417454430-27930-1-git-send-email-paul.eggleton@linux.intel.com>
On 14-12-01 12:20 PM, Paul Eggleton wrote:
> Spaces aren't valid around = in an assignment statement (not even with
> bash).
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> meta/classes/kernel-yocto.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> index e672a0e..c3e2494 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -212,7 +212,7 @@ do_kernel_checkout() {
> machine_branch="${@ get_machine_branch(d, "${KBRANCH}" )}"
> git show-ref --quiet --verify -- "refs/heads/${machine_branch}"
> if [ $? -eq 0 ]; then
> - machine_branch = "master"
> + machine_branch="master"
Clearly not running very often :)
Looks good to me.
Bruce
> fi
>
> # checkout and clobber any unimportant files
>
prev parent reply other threads:[~2014-12-01 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 17:20 [PATCH] kernel-yocto.bbclass: fix shell syntax error Paul Eggleton
2014-12-01 17:25 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547CA499.2050506@windriver.com \
--to=bruce.ashfield@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox