Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] kernel-yocto.bbclass: fix shell syntax error
@ 2014-12-01 17:20 Paul Eggleton
  2014-12-01 17:25 ` Bruce Ashfield
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Eggleton @ 2014-12-01 17:20 UTC (permalink / raw)
  To: openembedded-core

Spaces aren't valid around = in an assignment statement (not even with
bash).

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/classes/kernel-yocto.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
index e672a0e..c3e2494 100644
--- a/meta/classes/kernel-yocto.bbclass
+++ b/meta/classes/kernel-yocto.bbclass
@@ -212,7 +212,7 @@ do_kernel_checkout() {
 	machine_branch="${@ get_machine_branch(d, "${KBRANCH}" )}"
 	git show-ref --quiet --verify -- "refs/heads/${machine_branch}"
 	if [ $? -eq 0 ]; then
-		machine_branch = "master"
+		machine_branch="master"
 	fi
 
 	# checkout and clobber any unimportant files
-- 
1.9.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] kernel-yocto.bbclass: fix shell syntax error
  2014-12-01 17:20 [PATCH] kernel-yocto.bbclass: fix shell syntax error Paul Eggleton
@ 2014-12-01 17:25 ` Bruce Ashfield
  0 siblings, 0 replies; 2+ messages in thread
From: Bruce Ashfield @ 2014-12-01 17:25 UTC (permalink / raw)
  To: Paul Eggleton, openembedded-core

On 14-12-01 12:20 PM, Paul Eggleton wrote:
> Spaces aren't valid around = in an assignment statement (not even with
> bash).
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>   meta/classes/kernel-yocto.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> index e672a0e..c3e2494 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -212,7 +212,7 @@ do_kernel_checkout() {
>   	machine_branch="${@ get_machine_branch(d, "${KBRANCH}" )}"
>   	git show-ref --quiet --verify -- "refs/heads/${machine_branch}"
>   	if [ $? -eq 0 ]; then
> -		machine_branch = "master"
> +		machine_branch="master"

Clearly not running very often :)

Looks good to me.

Bruce

>   	fi
>
>   	# checkout and clobber any unimportant files
>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-01 17:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-01 17:20 [PATCH] kernel-yocto.bbclass: fix shell syntax error Paul Eggleton
2014-12-01 17:25 ` Bruce Ashfield

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox