Re: [PATCH 09/24] libpng: add neon option for aarch64

[Kang Kai <Kai.Kang@windriver.com>]

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

On 2014年12月17日 03:30, Koen Kooi wrote:
>> Op 7 nov. 2014, om 09:51 heeft Kai Kang <kai.kang@windriver.com> het volgende geschreven:
>>
>> Add neon option for aarch64 just as for arm. It fails with:
>>
>> | ./.libs/libpng16.so: undefined reference to `png_init_filter_functions_neon'
>> | collect2: error: ld returned 1 exit status
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
>> ---
>> meta/recipes-multimedia/libpng/libpng_1.6.13.bb | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-multimedia/libpng/libpng_1.6.13.bb b/meta/recipes-multimedia/libpng/libpng_1.6.13.bb
>> index 0c6fd1f..3d32bfe 100644
>> --- a/meta/recipes-multimedia/libpng/libpng_1.6.13.bb
>> +++ b/meta/recipes-multimedia/libpng/libpng_1.6.13.bb
>> @@ -20,6 +20,7 @@ inherit autotools binconfig-disabled pkgconfig
>>
>> # Work around missing symbols
>> EXTRA_OECONF_append_arm = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off" ,d)}"
>> +EXTRA_OECONF_append_aarch64 = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off" ,d)}"
> You're introducing the same bug in a different way: overeager use of qualifiers. Just drop the _arm bit and it works.
>

OK. I'll remove the _arm to fix this issue.

Thanks.

-- 
Regards,
Neil | Kai Kang


[-- Attachment #2: Type: text/html, Size: 2063 bytes --]