Re: [PATCH 09/24] libpng: add neon option for aarch64

[Kang Kai <Kai.Kang@windriver.com>]

On 2014年12月17日 19:04, Burton, Ross wrote:
> I find Koen's patch for libpng neater so could you merge that into your
> qemuarm64 branch?  The autobuilder has been doing some builds so this
> should be the last stage before it's all merged.

OK. I'll do it.

--Kai

>
> Ross
>
> On 17 December 2014 at 08:47, Kang Kai <Kai.Kang@windriver.com> wrote:
>>   On 2014年12月17日 03:30, Koen Kooi wrote:
>>
>>   Op 7 nov. 2014, om 09:51 heeft Kai Kang <kai.kang@windriver.com> <kai.kang@windriver.com> het volgende geschreven:
>>
>> Add neon option for aarch64 just as for arm. It fails with:
>>
>> | ./.libs/libpng16.so: undefined reference to `png_init_filter_functions_neon'
>> | collect2: error: ld returned 1 exit status
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com> <kai.kang@windriver.com>
>> ---
>> meta/recipes-multimedia/libpng/libpng_1.6.13.bb | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-multimedia/libpng/libpng_1.6.13.bb b/meta/recipes-multimedia/libpng/libpng_1.6.13.bb
>> index 0c6fd1f..3d32bfe 100644
>> --- a/meta/recipes-multimedia/libpng/libpng_1.6.13.bb
>> +++ b/meta/recipes-multimedia/libpng/libpng_1.6.13.bb
>> @@ -20,6 +20,7 @@ inherit autotools binconfig-disabled pkgconfig
>>
>> # Work around missing symbols
>> EXTRA_OECONF_append_arm = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off" ,d)}"
>> +EXTRA_OECONF_append_aarch64 = " ${@bb.utils.contains("TUNE_FEATURES", "neon", "--enable-arm-neon=on", "--enable-arm-neon=off" ,d)}"
>>
>>   You're introducing the same bug in a different way: overeager use of qualifiers. Just drop the _arm bit and it works.
>>
>>
>>
>> OK. I'll remove the _arm to fix this issue.
>>
>> Thanks.
>>
>> --
>> Regards,
>> Neil | Kai Kang
>>
>>


-- 
Regards,
Neil | Kai Kang