[PATCH 0/1] dhcp: fix for systemd service file

[PATCH 0/1] dhcp: fix for systemd service file

[Chen Qi]

The following changes since commit e6c6d3fcfd2faf867e8145d25c1ba197fb9ee6b5:

  build-appliance-image: Update to dizzy head revision (2014-09-23 22:10:21 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib ChenQi/systemd-dhcpd
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=ChenQi/systemd-dhcpd

Chen Qi (1):
  dhcp: fix for systemd service file

 meta/recipes-connectivity/dhcp/files/dhcpd.service | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/1] dhcp: fix for systemd service file

[Chen Qi]

1. Set Type=forking for dhcpd.service to make it start up correctly.
2. Add PIDFile=/var/run/dhcpd.pid
3. Do not force existence of the environment file.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-connectivity/dhcp/files/dhcpd.service | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-connectivity/dhcp/files/dhcpd.service b/meta/recipes-connectivity/dhcp/files/dhcpd.service
index 8648f1a..4215173 100644
--- a/meta/recipes-connectivity/dhcp/files/dhcpd.service
+++ b/meta/recipes-connectivity/dhcp/files/dhcpd.service
@@ -4,7 +4,9 @@ After=network.target
 After=time-sync.target
 
 [Service]
-EnvironmentFile=@SYSCONFDIR@/default/dhcp-server
+Type=forking
+PIDFile=/var/run/dhcpd.pid
+EnvironmentFile=-@SYSCONFDIR@/default/dhcp-server
 ExecStart=-@SBINDIR@/dhcpd -q $INTERFACES
 
 [Install]
-- 
1.9.1

Re: [PATCH 1/1] dhcp: fix for systemd service file

[ChenQi]

ping

On 09/28/2014 04:59 PM, Chen Qi wrote:
> 1. Set Type=forking for dhcpd.service to make it start up correctly.
> 2. Add PIDFile=/var/run/dhcpd.pid
> 3. Do not force existence of the environment file.
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   meta/recipes-connectivity/dhcp/files/dhcpd.service | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/dhcp/files/dhcpd.service b/meta/recipes-connectivity/dhcp/files/dhcpd.service
> index 8648f1a..4215173 100644
> --- a/meta/recipes-connectivity/dhcp/files/dhcpd.service
> +++ b/meta/recipes-connectivity/dhcp/files/dhcpd.service
> @@ -4,7 +4,9 @@ After=network.target
>   After=time-sync.target
>   
>   [Service]
> -EnvironmentFile=@SYSCONFDIR@/default/dhcp-server
> +Type=forking
> +PIDFile=/var/run/dhcpd.pid
> +EnvironmentFile=-@SYSCONFDIR@/default/dhcp-server
>   ExecStart=-@SBINDIR@/dhcpd -q $INTERFACES
>   
>   [Install]

Re: [PATCH 1/1] dhcp: fix for systemd service file

[Enrico Scholz]

ChenQi <Qi.Chen-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> writes:

>> 1. Set Type=forking for dhcpd.service to make it start up correctly.
>> 2. Add PIDFile=/var/run/dhcpd.pid

why forking? Starting dhcpd with '-f --no-pid' should chose the more
simple non-forking variant without a clumsy.pidfile.


Enrico

Re: [PATCH 1/1] dhcp: fix for systemd service file

[ChenQi]

On 12/17/2014 06:21 PM, Enrico Scholz wrote:
> ChenQi <Qi.Chen-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org> writes:
>
>>> 1. Set Type=forking for dhcpd.service to make it start up correctly.
>>> 2. Add PIDFile=/var/run/dhcpd.pid
> why forking? Starting dhcpd with '-f --no-pid' should chose the more
> simple non-forking variant without a clumsy.pidfile.
>
>
> Enrico

V2 sent, using '-f --no-pid'.

Regards,
Chen Qi