Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: "Vincent Génieux" <vincent2014@startigen.fr>,
	openembedded-core@lists.openembedded.org
Subject: Re: fix '[[: not found' error message using dash
Date: Wed, 14 Jan 2015 09:01:15 -0800	[thread overview]
Message-ID: <54B6A0DB.70706@linux.intel.com> (raw)
In-Reply-To: <1421100601-30956-1-git-send-email-vincent2014@startigen.fr>

Hi Vincent,

On 1/12/15 2:10 PM, Vincent Génieux wrote:
> This is a fix for https://bugzilla.yoctoproject.org/show_bug.cgi?id=7112
> bash specific syntax '[[ test ]]' replaced with '[ test ]'.
> 

Please use the tag:

Fixes [YOCTO 7112]

In the message body, on it's own line.

> Signed-off-by: Vincent Génieux <vincent2014@startigen.fr>

Here it is customary to list the people you have been working with:

Cc: Darren Hart <dvhart@linux.intel.com>
Cc: Bruce Ashfield...
etc.

Also, ensure your mailer does actually Cc those people (git send-email
can do this automatically).

> ---
>  meta/classes/kernel.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 70ed95b..2a6ec34 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -403,7 +403,7 @@ do_strip() {
>  			  gawk '{print $1}'`
>  
>  		for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do {
> -			if [[ "$headers" != *"$str"* ]]; then
> +			if [ "$headers" != *"$str"* ]; then
>  				bbwarn "Section not found: $str";
>  			fi
>  
> 

Content is correct. I presume this passes your testing with the dash shell?

Acked-by: Darren Hart <dvhart@linux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center


  reply	other threads:[~2015-01-14 17:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 22:10 fix '[[: not found' error message using dash Vincent Génieux
2015-01-14 17:01 ` Darren Hart [this message]
2015-01-14 23:35   ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B6A0DB.70706@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=vincent2014@startigen.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox