fix '[[: not found' error message using dash

fix '[[: not found' error message using dash

[Vincent Génieux]

This is a fix for https://bugzilla.yoctoproject.org/show_bug.cgi?id=7112
bash specific syntax '[[ test ]]' replaced with '[ test ]'.

Signed-off-by: Vincent Génieux <vincent2014@startigen.fr>
---
 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 70ed95b..2a6ec34 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -403,7 +403,7 @@ do_strip() {
 			  gawk '{print $1}'`
 
 		for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do {
-			if [[ "$headers" != *"$str"* ]]; then
+			if [ "$headers" != *"$str"* ]; then
 				bbwarn "Section not found: $str";
 			fi
 
-- 
1.7.10.4

Re: fix '[[: not found' error message using dash

[Darren Hart]

Hi Vincent,

On 1/12/15 2:10 PM, Vincent Génieux wrote:
> This is a fix for https://bugzilla.yoctoproject.org/show_bug.cgi?id=7112
> bash specific syntax '[[ test ]]' replaced with '[ test ]'.
> 

Please use the tag:

Fixes [YOCTO 7112]

In the message body, on it's own line.

> Signed-off-by: Vincent Génieux <vincent2014@startigen.fr>

Here it is customary to list the people you have been working with:

Cc: Darren Hart <dvhart@linux.intel.com>
Cc: Bruce Ashfield...
etc.

Also, ensure your mailer does actually Cc those people (git send-email
can do this automatically).

> ---
>  meta/classes/kernel.bbclass |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 70ed95b..2a6ec34 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -403,7 +403,7 @@ do_strip() {
>  			  gawk '{print $1}'`
>  
>  		for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do {
> -			if [[ "$headers" != *"$str"* ]]; then
> +			if [ "$headers" != *"$str"* ]; then
>  				bbwarn "Section not found: $str";
>  			fi
>  
> 

Content is correct. I presume this passes your testing with the dash shell?

Acked-by: Darren Hart <dvhart@linux.intel.com>

-- 
Darren Hart
Intel Open Source Technology Center

Re: fix '[[: not found' error message using dash

[Paul Eggleton]

On Wednesday 14 January 2015 09:01:15 Darren Hart wrote:
> On 1/12/15 2:10 PM, Vincent Génieux wrote:
> > This is a fix for https://bugzilla.yoctoproject.org/show_bug.cgi?id=7112
> > bash specific syntax '[[ test ]]' replaced with '[ test ]'.
> 
> Please use the tag:
> 
> Fixes [YOCTO 7112]
> 
> In the message body, on it's own line.

To be 100% correct, the syntax is

Fixes [YOCTO #7112]

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre