Openembedded Core Discussions
 help / color / mirror / Atom feed
* [oe-core dizzy][PATCH 0/3] fixes for dizzy
@ 2015-01-15  4:03 ting.liu
  2015-01-15  4:03 ` [oe-core dizzy][PATCH 1/3] libunwind: Fix test case link failure on PowerPC with Altivec ting.liu
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: ting.liu @ 2015-01-15  4:03 UTC (permalink / raw)
  To: openembedded-core

From: Ting Liu <ting.liu@freescale.com>

The following changes since commit e13f2681b75fd83aa3a1c823ad1c09faed0d6ae3
    rm_work: Fix RM_WORK_EXCLUDE for image/sdk recipes

Ting Liu (3):
  libunwind: Fix test case link failure on PowerPC with Altivec
  bitbake.conf: add PKGDATA_DIR to BB_HASHBASE_WHITELIST
  valgrind: build with altivec only if it supported

 meta/conf/bitbake.conf                             |  2 +-
 .../pass-maltivec-only-if-it-supported.patch       | 68 ++++++++++++++++++++++
 meta/recipes-devtools/valgrind/valgrind_3.9.0.bb   |  1 +
 ...k-failure-on-PowerPC-systems-with-Altivec.patch | 28 +++++++++
 meta/recipes-support/libunwind/libunwind_1.1.bb    |  4 ++
 5 files changed, 102 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch
 create mode 100644 meta/recipes-support/libunwind/libunwind-1.1/Fix-test-case-link-failure-on-PowerPC-systems-with-Altivec.patch

-- 
1.8.3.2



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [oe-core dizzy][PATCH 1/3] libunwind: Fix test case link failure on PowerPC with Altivec
  2015-01-15  4:03 [oe-core dizzy][PATCH 0/3] fixes for dizzy ting.liu
@ 2015-01-15  4:03 ` ting.liu
  2015-01-15  4:03 ` [oe-core dizzy][PATCH 2/3] bitbake.conf: add PKGDATA_DIR to BB_HASHBASE_WHITELIST ting.liu
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: ting.liu @ 2015-01-15  4:03 UTC (permalink / raw)
  To: openembedded-core

From: Ting Liu <ting.liu@freescale.com>

Signed-off-by: Ting Liu <ting.liu@freescale.com>
---
 ...k-failure-on-PowerPC-systems-with-Altivec.patch | 28 ++++++++++++++++++++++
 meta/recipes-support/libunwind/libunwind_1.1.bb    |  4 ++++
 2 files changed, 32 insertions(+)
 create mode 100644 meta/recipes-support/libunwind/libunwind-1.1/Fix-test-case-link-failure-on-PowerPC-systems-with-Altivec.patch

diff --git a/meta/recipes-support/libunwind/libunwind-1.1/Fix-test-case-link-failure-on-PowerPC-systems-with-Altivec.patch b/meta/recipes-support/libunwind/libunwind-1.1/Fix-test-case-link-failure-on-PowerPC-systems-with-Altivec.patch
new file mode 100644
index 0000000..dc0f5c1
--- /dev/null
+++ b/meta/recipes-support/libunwind/libunwind-1.1/Fix-test-case-link-failure-on-PowerPC-systems-with-Altivec.patch
@@ -0,0 +1,28 @@
+Fix test case link failure on PowerPC systems with Altivec
+
+Upstream-Status:backport
+
+On systems where the system compiler supports Altivec by default,
+the libunwind Makefile will attempt to build an extra test case
+ppc64-test-altivec.  Unfortunately, the link step will fail since
+the Makefile does not actually link against the libunwind library.
+
+Fixed by adding the appropriate LDADD macro.
+
+Signed-off-by: Ulrich Weigand <address@hidden>
+---
+ tests/Makefile.am | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/tests/Makefile.am b/tests/Makefile.am
+index 0e30536..9c76628 100644
+--- a/tests/Makefile.am
++++ b/tests/Makefile.am
+@@ -201,3 +201,4 @@ Lia64_test_rbs_LDADD = $(LIBUNWIND_local)
+ Lia64_test_readonly_LDADD = $(LIBUNWIND_local)
+ ia64_test_dyn1_LDADD = $(LIBUNWIND)
+ ia64_test_sig_LDADD = $(LIBUNWIND)
++ppc64_test_altivec_LDADD = $(LIBUNWIND)
+-- 
+1.8.5
+
diff --git a/meta/recipes-support/libunwind/libunwind_1.1.bb b/meta/recipes-support/libunwind/libunwind_1.1.bb
index bc38e36..20db132 100644
--- a/meta/recipes-support/libunwind/libunwind_1.1.bb
+++ b/meta/recipes-support/libunwind/libunwind_1.1.bb
@@ -1,4 +1,8 @@
 require libunwind.inc
 
+SRC_URI += "\
+    file://Fix-test-case-link-failure-on-PowerPC-systems-with-Altivec.patch \
+"
+
 SRC_URI[md5sum] = "fb4ea2f6fbbe45bf032cd36e586883ce"
 SRC_URI[sha256sum] = "9dfe0fcae2a866de9d3942c66995e4b460230446887dbdab302d41a8aee8d09a"
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [oe-core dizzy][PATCH 2/3] bitbake.conf: add PKGDATA_DIR to BB_HASHBASE_WHITELIST
  2015-01-15  4:03 [oe-core dizzy][PATCH 0/3] fixes for dizzy ting.liu
  2015-01-15  4:03 ` [oe-core dizzy][PATCH 1/3] libunwind: Fix test case link failure on PowerPC with Altivec ting.liu
@ 2015-01-15  4:03 ` ting.liu
  2015-01-15  4:03 ` [oe-core dizzy][PATCH 3/3] valgrind: build with altivec only if it supported ting.liu
  2015-01-30  4:50 ` [oe-core dizzy][PATCH 0/3] fixes for dizzy akuster808
  3 siblings, 0 replies; 5+ messages in thread
From: ting.liu @ 2015-01-15  4:03 UTC (permalink / raw)
  To: openembedded-core

From: Ting Liu <b28495@freescale.com>

In meta/conf/bitbake.conf, PKGDATA_DIR is default to:
PKGDATA_DIR = "${STAGING_DIR_HOST}/pkgdata"

But in meta/conf/multilib.conf, PKGDATA_DIR is set as:
PKGDATA_DIR = "${STAGING_DIR}/${MACHINE}/pkgdata"

When multilib enabled, linux-libc-headers cache will be machine
specific:
$ bitbake-diffsigs sstate-cache/1a/sstate:linux-libc-headers:ppce6500-poky-linux:3.17.7:r0:ppce6500:3:1a0c3934d91479fd7242a5b1d407d155_package.tgz.siginfo sstate-cache/28/sstate:linux-libc-headers:ppce6500-poky-linux:3.17.7:r0:ppce6500:3:28c918e8f9f4a4cfceb3a38b258f7501_package.tgz.siginfo
basehash changed from 8d3158bbddcee612fa30badd05f47b8e to 68ac258fc6c8e489f360fde3123a5894
Variable MACHINE value changed from 'b4420qds' to 'b4860qds'

Signed-off-by: Ting Liu <ting.liu@freescale.com>
---
 meta/conf/bitbake.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 74813a2..90b64b0 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -771,7 +771,7 @@ BB_HASHBASE_WHITELIST ?= "TMPDIR FILE PATH PWD BB_TASKHASH BBPATH DL_DIR \
     USER FILESPATH STAGING_DIR_HOST STAGING_DIR_TARGET COREBASE PRSERV_HOST \
     PRSERV_DUMPDIR PRSERV_DUMPFILE PRSERV_LOCKDOWN PARALLEL_MAKE \
     CCACHE_DIR EXTERNAL_TOOLCHAIN CCACHE CCACHE_DISABLE LICENSE_PATH SDKPKGSUFFIX \
-    WARN_QA ERROR_QA WORKDIR STAMPCLEAN"
+    WARN_QA ERROR_QA WORKDIR STAMPCLEAN PKGDATA_DIR"
 BB_HASHCONFIG_WHITELIST ?= "${BB_HASHBASE_WHITELIST} DATE TIME SSH_AGENT_PID \
     SSH_AUTH_SOCK PSEUDO_BUILD BB_ENV_EXTRAWHITE DISABLE_SANITY_CHECKS \
     PARALLEL_MAKE BB_NUMBER_THREADS BB_ORIGENV BB_INVALIDCONF BBINCLUDED"
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [oe-core dizzy][PATCH 3/3] valgrind: build with altivec only if it supported
  2015-01-15  4:03 [oe-core dizzy][PATCH 0/3] fixes for dizzy ting.liu
  2015-01-15  4:03 ` [oe-core dizzy][PATCH 1/3] libunwind: Fix test case link failure on PowerPC with Altivec ting.liu
  2015-01-15  4:03 ` [oe-core dizzy][PATCH 2/3] bitbake.conf: add PKGDATA_DIR to BB_HASHBASE_WHITELIST ting.liu
@ 2015-01-15  4:03 ` ting.liu
  2015-01-30  4:50 ` [oe-core dizzy][PATCH 0/3] fixes for dizzy akuster808
  3 siblings, 0 replies; 5+ messages in thread
From: ting.liu @ 2015-01-15  4:03 UTC (permalink / raw)
  To: openembedded-core

From: Ting Liu <ting.liu@freescale.com>

Signed-off-by: Ting Liu <ting.liu@freescale.com>
---
 .../pass-maltivec-only-if-it-supported.patch       | 68 ++++++++++++++++++++++
 meta/recipes-devtools/valgrind/valgrind_3.9.0.bb   |  1 +
 2 files changed, 69 insertions(+)
 create mode 100644 meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch

diff --git a/meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch b/meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch
new file mode 100644
index 0000000..12ad4c3
--- /dev/null
+++ b/meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch
@@ -0,0 +1,68 @@
+Upstream-status: Backport
+
+r14566 | florian | 2014-09-24 17:02:54 -0500 (Wed, 24 Sep 2014) | 4 lines
+
+The testbuckets none/tests/ppc{32,64} did not build in case the
+toolchain did not support -maltivec -mabi=altivec.
+This should work now. Fixes BZ #338731
+
+Index: none/tests/ppc32/Makefile.am
+===================================================================
+--- a/none/tests/ppc32/Makefile.am	(revision 14565)
++++ b/none/tests/ppc32/Makefile.am	(revision 14566)
+@@ -72,8 +72,12 @@
+ allexec_CFLAGS		= $(AM_CFLAGS) @FLAG_W_NO_NONNULL@
+ 
+ if HAS_ALTIVEC
++BUILD_FLAG_ALTIVEC = -maltivec
++BUILD_FLAG_ABI_ALTIVEC = -mabi=altivec
+ ALTIVEC_FLAG = -DHAS_ALTIVEC
+ else
++BUILD_FLAG_ALTIVEC =
++BUILD_FLAG_ABI_ALTIVEC =
+ ALTIVEC_FLAG =
+ endif
+ 
+@@ -101,11 +105,12 @@
+ ISA_2_07_FLAG =
+ endif
+ 
+-jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames -maltivec \
+-			@FLAG_M32@ $(ALTIVEC_FLAG)
++jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames \
++			@FLAG_M32@ $(ALTIVEC_FLAG) $(BUILD_FLAG_ALTIVEC)
+ 
+-testVMX_CFLAGS  = $(AM_CFLAGS) -O -g -Wall -maltivec -mabi=altivec -DALTIVEC \
+-			-DGCC_COMPILER @FLAG_M32@
++testVMX_CFLAGS  = $(AM_CFLAGS) -O -g -Wall -DALTIVEC \
++			-DGCC_COMPILER @FLAG_M32@  $(BUILD_FLAG_ALTIVEC) \
++			$(BUILD_FLAG_ABI_ALTIVEC)
+ 
+ test_isa_2_06_part1_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames $(VSX_FLAG) \
+ 			@FLAG_M32@ $(ALTIVEC_FLAG) $(BUILD_FLAG_VSX)
+Index: none/tests/ppc64/Makefile.am
+===================================================================
+--- a/none/tests/ppc64/Makefile.am	(revision 14565)
++++ b/none/tests/ppc64/Makefile.am	(revision 14566)
+@@ -50,8 +50,10 @@
+ allexec_CFLAGS		= $(AM_CFLAGS) @FLAG_W_NO_NONNULL@
+ 
+ if HAS_ALTIVEC
++BUILD_FLAG_ALTIVEC = -maltivec
+ ALTIVEC_FLAG = -DHAS_ALTIVEC
+ else
++BUILD_FLAG_ALTIVEC =
+ ALTIVEC_FLAG =
+ endif
+ 
+@@ -88,8 +90,8 @@
+ test_isa_2_06_part3_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames $(VSX_FLAG) \
+ 			@FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_VSX)
+ 
+-jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames -maltivec \
+-			@FLAG_M64@ $(ALTIVEC_FLAG)
++jm_insns_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames \
++			@FLAG_M64@ $(ALTIVEC_FLAG) $(BUILD_FLAG_ALTIVEC)
+ 
+ test_dfp1_CFLAGS = $(AM_CFLAGS) -Winline -Wall -O -g -mregnames $(DFP_FLAG) \
+ 			@FLAG_M64@ $(BUILD_FLAGS_DFP)
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb
index c415e77..eea81a2 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.9.0.bb
@@ -20,6 +20,7 @@ SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \
            file://remove-arm-variant-specific.patch \
            file://remove-ppc-tests-failing-build.patch \
            file://add-ptest.patch \
+           file://pass-maltivec-only-if-it-supported.patch \
            file://run-ptest \
           "
 
-- 
1.8.3.2



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [oe-core dizzy][PATCH 0/3] fixes for dizzy
  2015-01-15  4:03 [oe-core dizzy][PATCH 0/3] fixes for dizzy ting.liu
                   ` (2 preceding siblings ...)
  2015-01-15  4:03 ` [oe-core dizzy][PATCH 3/3] valgrind: build with altivec only if it supported ting.liu
@ 2015-01-30  4:50 ` akuster808
  3 siblings, 0 replies; 5+ messages in thread
From: akuster808 @ 2015-01-30  4:50 UTC (permalink / raw)
  To: openembedded-core


patches staged.

- armin
On 01/14/2015 08:03 PM, ting.liu@freescale.com wrote:
> From: Ting Liu <ting.liu@freescale.com>
>
> The following changes since commit e13f2681b75fd83aa3a1c823ad1c09faed0d6ae3
>      rm_work: Fix RM_WORK_EXCLUDE for image/sdk recipes
>
> Ting Liu (3):
>    libunwind: Fix test case link failure on PowerPC with Altivec
>    bitbake.conf: add PKGDATA_DIR to BB_HASHBASE_WHITELIST
>    valgrind: build with altivec only if it supported
>
>   meta/conf/bitbake.conf                             |  2 +-
>   .../pass-maltivec-only-if-it-supported.patch       | 68 ++++++++++++++++++++++
>   meta/recipes-devtools/valgrind/valgrind_3.9.0.bb   |  1 +
>   ...k-failure-on-PowerPC-systems-with-Altivec.patch | 28 +++++++++
>   meta/recipes-support/libunwind/libunwind_1.1.bb    |  4 ++
>   5 files changed, 102 insertions(+), 1 deletion(-)
>   create mode 100644 meta/recipes-devtools/valgrind/valgrind/pass-maltivec-only-if-it-supported.patch
>   create mode 100644 meta/recipes-support/libunwind/libunwind-1.1/Fix-test-case-link-failure-on-PowerPC-systems-with-Altivec.patch
>


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-01-30  4:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15  4:03 [oe-core dizzy][PATCH 0/3] fixes for dizzy ting.liu
2015-01-15  4:03 ` [oe-core dizzy][PATCH 1/3] libunwind: Fix test case link failure on PowerPC with Altivec ting.liu
2015-01-15  4:03 ` [oe-core dizzy][PATCH 2/3] bitbake.conf: add PKGDATA_DIR to BB_HASHBASE_WHITELIST ting.liu
2015-01-15  4:03 ` [oe-core dizzy][PATCH 3/3] valgrind: build with altivec only if it supported ting.liu
2015-01-30  4:50 ` [oe-core dizzy][PATCH 0/3] fixes for dizzy akuster808

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox