[PATCH] opkg: Fix error when recompiled

[PATCH] opkg: Fix error when recompiled

[Gary Thomas]

If this package were ever recompiled, i.e. do_compile is rerun
as a result of a compiler change, etc., the 'opkg.conf' file
would be incorrectly updated, leading to an error:
 * opkg_conf_set_option: Duplicate option lists_dir, using first seen value "/var/lib/opkg".

This change prevents this by not tampering with the original 'opkg.conf'

Signed-off-by: Gary Thomas <gary@mlbassoc.com>
---
 meta/recipes-devtools/opkg/opkg_0.2.4.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/opkg/opkg_0.2.4.bb b/meta/recipes-devtools/opkg/opkg_0.2.4.bb
index 8455eac..b07d4d4 100644
--- a/meta/recipes-devtools/opkg/opkg_0.2.4.bb
+++ b/meta/recipes-devtools/opkg/opkg_0.2.4.bb
@@ -48,12 +48,13 @@ do_configure_prepend() {
 }
 
 do_compile_append () {
-	echo "option lists_dir ${OPKGLIBDIR}/opkg" >>${WORKDIR}/opkg.conf
+	cp ${WORKDIR}/opkg.conf ${WORKDIR}/opkg.conf-configured
+	echo "option lists_dir ${OPKGLIBDIR}/opkg" >>${WORKDIR}/opkg.conf-configured
 }
 
 do_install_append () {
 	install -d ${D}${sysconfdir}/opkg
-	install -m 0644 ${WORKDIR}/opkg.conf ${D}${sysconfdir}/opkg/opkg.conf
+	install -m 0644 ${WORKDIR}/opkg.conf-configured ${D}${sysconfdir}/opkg/opkg.conf
 
 	# We need to create the lock directory
 	install -d ${D}${OPKGLIBDIR}/opkg
-- 
1.9.1

Re: [PATCH] opkg: Fix error when recompiled

[Otavio Salvador]

On Thu, Mar 5, 2015 at 12:17 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> If this package were ever recompiled, i.e. do_compile is rerun
> as a result of a compiler change, etc., the 'opkg.conf' file
> would be incorrectly updated, leading to an error:
>  * opkg_conf_set_option: Duplicate option lists_dir, using first seen value "/var/lib/opkg".
>
> This change prevents this by not tampering with the original 'opkg.conf'
>
> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
> ---
>  meta/recipes-devtools/opkg/opkg_0.2.4.bb | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/opkg/opkg_0.2.4.bb b/meta/recipes-devtools/opkg/opkg_0.2.4.bb
> index 8455eac..b07d4d4 100644
> --- a/meta/recipes-devtools/opkg/opkg_0.2.4.bb
> +++ b/meta/recipes-devtools/opkg/opkg_0.2.4.bb
> @@ -48,12 +48,13 @@ do_configure_prepend() {
>  }
>
>  do_compile_append () {
> -       echo "option lists_dir ${OPKGLIBDIR}/opkg" >>${WORKDIR}/opkg.conf
> +       cp ${WORKDIR}/opkg.conf ${WORKDIR}/opkg.conf-configured
> +       echo "option lists_dir ${OPKGLIBDIR}/opkg" >>${WORKDIR}/opkg.conf-configured

Ideally this could be done for D (in install) so it does not need to
be preserved.

>  }
>
>  do_install_append () {
>         install -d ${D}${sysconfdir}/opkg
> -       install -m 0644 ${WORKDIR}/opkg.conf ${D}${sysconfdir}/opkg/opkg.conf
> +       install -m 0644 ${WORKDIR}/opkg.conf-configured ${D}${sysconfdir}/opkg/opkg.conf
>
>         # We need to create the lock directory
>         install -d ${D}${OPKGLIBDIR}/opkg
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core



-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] opkg: Fix error when recompiled

[Gary Thomas]

On 2015-03-05 08:38, Otavio Salvador wrote:
> On Thu, Mar 5, 2015 at 12:17 PM, Gary Thomas <gary@mlbassoc.com> wrote:
>> If this package were ever recompiled, i.e. do_compile is rerun
>> as a result of a compiler change, etc., the 'opkg.conf' file
>> would be incorrectly updated, leading to an error:
>>   * opkg_conf_set_option: Duplicate option lists_dir, using first seen value "/var/lib/opkg".
>>
>> This change prevents this by not tampering with the original 'opkg.conf'
>>
>> Signed-off-by: Gary Thomas <gary@mlbassoc.com>
>> ---
>>   meta/recipes-devtools/opkg/opkg_0.2.4.bb | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/opkg/opkg_0.2.4.bb b/meta/recipes-devtools/opkg/opkg_0.2.4.bb
>> index 8455eac..b07d4d4 100644
>> --- a/meta/recipes-devtools/opkg/opkg_0.2.4.bb
>> +++ b/meta/recipes-devtools/opkg/opkg_0.2.4.bb
>> @@ -48,12 +48,13 @@ do_configure_prepend() {
>>   }
>>
>>   do_compile_append () {
>> -       echo "option lists_dir ${OPKGLIBDIR}/opkg" >>${WORKDIR}/opkg.conf
>> +       cp ${WORKDIR}/opkg.conf ${WORKDIR}/opkg.conf-configured
>> +       echo "option lists_dir ${OPKGLIBDIR}/opkg" >>${WORKDIR}/opkg.conf-configured
>
> Ideally this could be done for D (in install) so it does not need to
> be preserved.

Sure, that's probably a better way to do it - I was just following the code
that was there (and incorrect).  I'll make a new patch.

>
>>   }
>>
>>   do_install_append () {
>>          install -d ${D}${sysconfdir}/opkg
>> -       install -m 0644 ${WORKDIR}/opkg.conf ${D}${sysconfdir}/opkg/opkg.conf
>> +       install -m 0644 ${WORKDIR}/opkg.conf-configured ${D}${sysconfdir}/opkg/opkg.conf
>>
>>          # We need to create the lock directory
>>          install -d ${D}${OPKGLIBDIR}/opkg
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
>

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------