[PATCH 0/1] insane.bbclass: add missing QA to WARN_QA

[PATCH 0/1] insane.bbclass: add missing QA to WARN_QA

[Robert Yang]

The following changes since commit 0752c79282b1cc9699743e719518e6c341d50a3a:

  systemd: fix /var/log/journal ownership (2015-03-16 17:38:51 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/qa
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/qa

Robert Yang (1):
  insane.bbclass: add missing QA to WARN_QA

 meta/classes/insane.bbclass |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
1.7.9.5

[PATCH 1/1] insane.bbclass: add missing QA to WARN_QA

[Robert Yang]

The following QA were not in WARN_QA or ERROR_QA, so they are not in
ALL_QA:
buildpaths
desktop
libexec
pkgname
symlink-to-sysroot
unsafe-references-in-binaries
unsafe-references-in-scripts

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/insane.bbclass |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 061ce5b..c201c9b 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -30,7 +30,9 @@ WARN_QA ?= "ldflags useless-rpaths rpaths staticdev libdir xorg-driver-abi \
             textrel already-stripped incompatible-license files-invalid \
             installed-vs-shipped compile-host-path install-host-path \
             pn-overrides infodir build-deps file-rdeps \
-            unknown-configure-option \
+            unknown-configure-option buildpaths desktop libexec pkgname \
+            symlink-to-sysroot unsafe-references-in-binaries \
+            unsafe-references-in-scripts \
             "
 ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch pkgconfig la \
             perms dep-cmp pkgvarcheck perm-config perm-line perm-link \
-- 
1.7.9.5

Re: [PATCH 1/1] insane.bbclass: add missing QA to WARN_QA

[Paul Eggleton]

Hi Robert,

On Thursday 19 March 2015 02:17:43 Robert Yang wrote:
> The following QA were not in WARN_QA or ERROR_QA, so they are not in
> ALL_QA:
>
> buildpaths

Last I checked enabling this throws up quite a few issues, some of which 
aren't a problem. Has that been fixed? If not, we can't enable it.

> desktop

I'm pretty sure we kept this one off deliberately as well, there are too many 
bad desktop files out there and for most people it doesn't matter.

> libexec

Does this test work?

> pkgname

Only certain package managers care about the rules this test enforces.

> symlink-to-sysroot

I agree this one should probably be enabled.

> unsafe-references-in-binaries
> unsafe-references-in-scripts

We haven't enabled these because there isn't general agreement that this is a 
problem for everyone.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/1] insane.bbclass: add missing QA to WARN_QA

[Robert Yang]

Hi Paul,

Thanks for the reply, I just wanted to add them to ALL_QA, but you
are right, I need do more checking and fix, please ignore this patch atm.

// Robert

On 03/19/2015 05:37 PM, Paul Eggleton wrote:
> Hi Robert,
>
> On Thursday 19 March 2015 02:17:43 Robert Yang wrote:
>> The following QA were not in WARN_QA or ERROR_QA, so they are not in
>> ALL_QA:
>>
>> buildpaths
>
> Last I checked enabling this throws up quite a few issues, some of which
> aren't a problem. Has that been fixed? If not, we can't enable it.
>
>> desktop
>
> I'm pretty sure we kept this one off deliberately as well, there are too many
> bad desktop files out there and for most people it doesn't matter.
>
>> libexec
>
> Does this test work?
>
>> pkgname
>
> Only certain package managers care about the rules this test enforces.
>
>> symlink-to-sysroot
>
> I agree this one should probably be enabled.
>
>> unsafe-references-in-binaries
>> unsafe-references-in-scripts
>
> We haven't enabled these because there isn't general agreement that this is a
> problem for everyone.
>
> Cheers,
> Paul
>