[PATCH] uninative-tarball: fix dependency on patchelf

[PATCH] uninative-tarball: fix dependency on patchelf

[Tyler Hall]

DEPENDS doesn't actually add the dependency on patchelf-native to the
populate_sdk task. SDK_DEPENDS does this, but move the append to after
inheriting the base class so it does not get overwritten.

Without this, uninative-tarball fails to build in a clean workspace on a
system without patchelf.

Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
CC: Richard Purdie <richard.purdie@linuxfoundation.org>
CC: Randy Witt <randy.e.witt@linux.intel.com>
---
 meta/recipes-core/meta/uninative-tarball.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/meta/uninative-tarball.bb b/meta/recipes-core/meta/uninative-tarball.bb
index 53435f2..62bdde8 100644
--- a/meta/recipes-core/meta/uninative-tarball.bb
+++ b/meta/recipes-core/meta/uninative-tarball.bb
@@ -11,7 +11,6 @@ TOOLCHAIN_HOST_TASK = "\
     "
 
 INHIBIT_DEFAULT_DEPS = "1"
-DEPENDS += "patchelf-native"
 
 TOOLCHAIN_OUTPUTNAME ?= "${BUILD_ARCH}-nativesdk-libc"
 
@@ -25,6 +24,8 @@ inherit populate_sdk
 deltask install
 deltask package
 
+SDK_DEPENDS += "patchelf-native"
+
 SDK_PACKAGING_FUNC = ""
 
 fakeroot create_sdk_files() {
-- 
2.3.1

Re: [PATCH] uninative-tarball: fix dependency on patchelf

[Randy Witt]

On 03/24/2015 03:17 PM, Tyler Hall wrote:
> DEPENDS doesn't actually add the dependency on patchelf-native to the
> populate_sdk task. SDK_DEPENDS does this, but move the append to after
> inheriting the base class so it does not get overwritten.
>
> Without this, uninative-tarball fails to build in a clean workspace on a
> system without patchelf.
>
> Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
> CC: Richard Purdie <richard.purdie@linuxfoundation.org>
> CC: Randy Witt <randy.e.witt@linux.intel.com>
> ---
>   meta/recipes-core/meta/uninative-tarball.bb | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/meta/uninative-tarball.bb b/meta/recipes-core/meta/uninative-tarball.bb
> index 53435f2..62bdde8 100644
> --- a/meta/recipes-core/meta/uninative-tarball.bb
> +++ b/meta/recipes-core/meta/uninative-tarball.bb
> @@ -11,7 +11,6 @@ TOOLCHAIN_HOST_TASK = "\
>       "
>
>   INHIBIT_DEFAULT_DEPS = "1"
> -DEPENDS += "patchelf-native"
>
>   TOOLCHAIN_OUTPUTNAME ?= "${BUILD_ARCH}-nativesdk-libc"
>
> @@ -25,6 +24,8 @@ inherit populate_sdk
>   deltask install
>   deltask package
>
> +SDK_DEPENDS += "patchelf-native"
> +
>   SDK_PACKAGING_FUNC = ""
>
>   fakeroot create_sdk_files() {
>

This patch is the same as what I had queued up. The only thing is to put the 
yocto bug number 7467 in the commit message.

Acked-by: Randy Witt <randy.e.witt@linux.intel.com>

[PATCH v2] uninative-tarball: fix dependency on patchelf

[Tyler Hall]

DEPENDS doesn't actually add the dependency on patchelf-native to the
populate_sdk task. SDK_DEPENDS does this, but move the append to after
inheriting the base class so it does not get overwritten.

Without this, uninative-tarball fails to build in a clean workspace on a
system without patchelf.

[Yocto #7467]

Signed-off-by: Tyler Hall <tylerwhall@gmail.com>
Acked-by: Randy Witt <randy.e.witt@linux.intel.com>
CC: Richard Purdie <richard.purdie@linuxfoundation.org>
CC: Randy Witt <randy.e.witt@linux.intel.com>
---
 meta/recipes-core/meta/uninative-tarball.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/meta/uninative-tarball.bb b/meta/recipes-core/meta/uninative-tarball.bb
index 53435f2..62bdde8 100644
--- a/meta/recipes-core/meta/uninative-tarball.bb
+++ b/meta/recipes-core/meta/uninative-tarball.bb
@@ -11,7 +11,6 @@ TOOLCHAIN_HOST_TASK = "\
     "
 
 INHIBIT_DEFAULT_DEPS = "1"
-DEPENDS += "patchelf-native"
 
 TOOLCHAIN_OUTPUTNAME ?= "${BUILD_ARCH}-nativesdk-libc"
 
@@ -25,6 +24,8 @@ inherit populate_sdk
 deltask install
 deltask package
 
+SDK_DEPENDS += "patchelf-native"
+
 SDK_PACKAGING_FUNC = ""
 
 fakeroot create_sdk_files() {
-- 
2.3.1

Re: [PATCH v2] uninative-tarball: fix dependency on patchelf

[Tyler Hall]

Randy, Richard,

Disregard. Looks like we raced with each other. Thanks for applying v1.

-Tyler