Re: [PATCH 2nd resend] powertop: Fix build for !uclibc - kindly respond

Re: [PATCH 2nd resend] powertop: Fix build for !uclibc - kindly respond

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

On 12 May 2015 at 11:48, Jens Rottmann <Jens.Rottmann@adlinktech.com> wrote:

> Is there anything else I should do, any additional information I need to
> provide, anything I did wrong? Kindly respond.
>

If a patch is for a release branch, it's best to add eg [daisy] to the
subject line so that it gets noticed.

Ross

[-- Attachment #2: Type: text/html, Size: 745 bytes --]

Re: [PATCH 2nd resend] powertop: Fix build for !uclibc - kindly respond

[Saul Wold]

I am working on getting a 1.6.3 release finalized, this will be pulled 
into that release and it should be going to QA this week.

Sau!


On 05/12/2015 03:48 AM, Jens Rottmann wrote:
> From: Martin Jansa <martin.jansa@gmail.com>
> Date: Thu, 18 Dec 2014 15:54:14 +0100
> Subject: powertop: Fix build for !uclibc
>
> * EXTRA_LDFLAGS isn't defined for !uclibc and configure fails
>    when it reads it unexpanded, see config.log snippet:
>
>    configure:4177: checking whether the C compiler works
>    configure:4199: i586-oe-linux-gcc  -m32 -march=i586 --sysroot=/OE/sysroots/qemux86  -O2 -pipe -g -feliminate-unused-debug-types  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed ${EXTRA_LDFLAGS} conftest.c  >&5
>    i586-oe-linux-gcc: error: ${EXTRA_LDFLAGS}: No such file or directory
>    configure:4203: $? = 1
>    configure:4241: result: no
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
>
> Backported from OpenEmbedded Dizzy branch, commit
> c8f9b5c9a8e5179c2013f25decd6a5483df9c716.
>
> Signed-off-by: Jens Rottmann <Jens.Rottmann@ADLINKtech.com>
> ---
>
> Hi Saul,
>
> as I said, attached patch was taken/ported from OE-Core Dizzy, commit c8f9b5c9a8e5179c2013f25decd6a5483df9c716.
>
> Please apply it to OE-Core _Daisy_ branch, which is affected, too.
>
> Is there anything else I should do, any additional information I need to provide, anything I did wrong? Kindly respond.
>
> Thanks & best regards,
> Jens
>
> diff --git a/meta/recipes-kernel/powertop/powertop_2.5.bb b/met/recipes-kernel/powertop/powertop_2.5.bb
> index f37d7a7..84cca25 100644
> --- a/meta/recipes-kernel/powertop/powertop_2.5.bb
> +++ b/meta/recipes-kernel/powertop/powertop_2.5.bb
> @@ -14,8 +14,9 @@ SRC_URI[sha256sum] = "8b2c08a555d79e1c428863470c41cb023971d74ba4801d80a05e35adee
>   inherit autotools gettext
>
>   # we need to explicitly link with libintl in uClibc systems
> -LDFLAGS += "${EXTRA_LDFLAGS}"
> +EXTRA_LDFLAGS ?= ""
>   EXTRA_LDFLAGS_libc-uclibc = "-lintl"
> +LDFLAGS += "${EXTRA_LDFLAGS}"
>
>   # we do not want libncursesw if we can
>   do_configure_prepend() {
>