[PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[Florian Boor]

---
 meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb b/meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb
index 33b6afe..9c52193 100644
--- a/meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb
+++ b/meta/recipes-gnome/gtk-engines/gtk-engines_2.20.2.bb
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=2d5025d4aa3495befef8f17206a5b0a1"
 SECTION = "x11/base"
 DEPENDS = "intltool-native gtk+"
 
-PR = "r3"
+PR = "r4"
 
 PACKAGES += "${PN}-schemas"
 PACKAGES_DYNAMIC += "^gtk-engine-.* ^gtk-theme-.*"
@@ -29,6 +29,8 @@ FILES_${PN}-schemas = "${datadir}/gtk-engines/*.xml"
 
 CFLAGS_prepend = "-DHAVE_ANIMATION "
 
+ALLOW_EMPTY_${PN} = "1"
+
 inherit gnomebase
 
 python populate_packages_prepend() {
-- 
2.1.4

Re: [PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 279 bytes --]

On 20 May 2015 at 12:49, Florian Boor <florian.boor@kernelconcepts.de>
wrote:

> -PR = "r3"
> +PR = "r4"
>

No need to bump PR.

Personally I think that the fix here is to stop PN-dev depending on PN,
instead of creating an empty PN package to confuse people.

Ross

[-- Attachment #2: Type: text/html, Size: 774 bytes --]

Re: [PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[Florian Boor]

Hi Ross,

On 20.05.2015 15:08, Burton, Ross wrote:
> No need to bump PR.
> 
> Personally I think that the fix here is to stop PN-dev depending on PN, instead
> of creating an empty PN package to confuse people.

well, in this way it automatically fixes this issues with the -dev package which
is not installable for every build where gtk-engines has been built already, so
in my opinion this is a good reason to increment PR.
Randomly laying around packages with broken dependencies have quite more
potential to confuse people than incremented PR most users do not care about much.

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de
                                        http://www.kernelconcepts.de/en

Re: [PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[Otavio Salvador]

On Wed, May 20, 2015 at 10:17 AM, Florian Boor
<florian.boor@kernelconcepts.de> wrote:
> On 20.05.2015 15:08, Burton, Ross wrote:
>> No need to bump PR.
>>
>> Personally I think that the fix here is to stop PN-dev depending on PN, instead
>> of creating an empty PN package to confuse people.
>
> well, in this way it automatically fixes this issues with the -dev package which
> is not installable for every build where gtk-engines has been built already, so
> in my opinion this is a good reason to increment PR.
> Randomly laying around packages with broken dependencies have quite more
> potential to confuse people than incremented PR most users do not care about much.

No. You should rely on PR Service for this. Drop the PR bump as it is
pointless here.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[Florian Boor]

Hi Otavio,

On 20.05.2015 15:20, Otavio Salvador wrote:

> No. You should rely on PR Service for this. Drop the PR bump as it is
> pointless here.

oh PR Service - if we can rely on it in this case I agree.

Greetings

Florian


-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de
                                        http://www.kernelconcepts.de/en

Re: [PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

On 20 May 2015 at 14:27, Florian Boor <florian.boor@kernelconcepts.de>
wrote:

> > No. You should rely on PR Service for this. Drop the PR bump as it is
> > pointless here.
>
> oh PR Service - if we can rely on it in this case I agree.


If you care about upgrade paths then the PR service is far more reliable
than explicit PR bumps.

Ross

[-- Attachment #2: Type: text/html, Size: 744 bytes --]

Re: [PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[Florian Boor]

Hi,

On 20.05.2015 15:32, Burton, Ross wrote:
> If you care about upgrade paths then the PR service is far more reliable than
> explicit PR bumps.

ok great... then I'll change it to dropping the dependency of the -dev package
while I'm working on it anyway.

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de
                                        http://www.kernelconcepts.de/en

Re: [PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[Florian Boor]

Hi,

On 20.05.2015 15:48, Florian Boor wrote:
> ok great... then I'll change it to dropping the dependency of the -dev package
> while I'm working on it anyway.

hrm strange... somehow my new patch did not make it to the list. Anyone an idea
if it ended up in some filter?

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de
                                        http://www.kernelconcepts.de/en

Re: [PATCH] gtk-engines: Allow gtk-engines package to be empty in order to make the -dev package installable.

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 529 bytes --]

On 28 May 2015 at 11:13, Florian Boor <florian.boor@kernelconcepts.de>
wrote:

> > ok great... then I'll change it to dropping the dependency of the -dev
> package
> > while I'm working on it anyway.
>
> hrm strange... somehow my new patch did not make it to the list. Anyone an
> idea
> if it ended up in some filter?
>

You mean this patch?

    gtk-engines: Make gtk-engines-dev installable by dropping dependency to
not generated gtk-engines package.

It made it to the list as it's been merged. :)

Ross

[-- Attachment #2: Type: text/html, Size: 1180 bytes --]