[PATCH v2] dosfstools: Add recipe for v3.0.28

[PATCH v2] dosfstools: Add recipe for v3.0.28

[Soren Brinkmann]

Add a recipe for building the latest (as of today) version of
dosfstools.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
v2:
 - add recipe for 3.0.28 additionally to the 2.11 one
---
 meta/recipes-devtools/dosfstools/dosfstools.inc    |  8 ++++++++
 .../recipes-devtools/dosfstools/dosfstools_2.11.bb |  7 +++----
 .../dosfstools/dosfstools_3.0.28.bb                | 22 ++++++++++++++++++++++
 3 files changed, 33 insertions(+), 4 deletions(-)
 create mode 100644 meta/recipes-devtools/dosfstools/dosfstools.inc
 create mode 100644 meta/recipes-devtools/dosfstools/dosfstools_3.0.28.bb

diff --git a/meta/recipes-devtools/dosfstools/dosfstools.inc b/meta/recipes-devtools/dosfstools/dosfstools.inc
new file mode 100644
index 000000000000..d2e672df1f48
--- /dev/null
+++ b/meta/recipes-devtools/dosfstools/dosfstools.inc
@@ -0,0 +1,8 @@
+# dosfstools OE build file
+# Copyright (C) 2015, Sören Brinkmann <soeren.brinkmann@gmail>  All Rights Reserved
+# Released under the MIT license (see packages/COPYING)
+
+SUMMARY = "DOS FAT Filesystem Utilities"
+SECTION = "base"
+
+BBCLASSEXTEND = "native"
diff --git a/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb b/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb
index d1c24b874845..d237cc9b9eac 100644
--- a/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb
+++ b/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb
@@ -1,10 +1,11 @@
 # dosfstools OE build file
 # Copyright (C) 2004-2006, Advanced Micro Devices, Inc.  All Rights Reserved
 # Released under the MIT license (see packages/COPYING)
-SUMMARY = "DOS FAT Filesystem Utilities"
+
+require dosfstools.inc
+
 HOMEPAGE = "http://daniel-baumann.ch/software/dosfstools/"
 
-SECTION = "base"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://mkdosfs/COPYING;md5=cbe67f08d6883bff587f615f0cc81aa8"
 PR = "r5"
@@ -31,5 +32,3 @@ do_install () {
 	oe_runmake "PREFIX=${D}" "SBINDIR=${D}${base_sbindir}" \
 		   "MANDIR=${D}${mandir}/man8" install
 }
-
-BBCLASSEXTEND = "native"
diff --git a/meta/recipes-devtools/dosfstools/dosfstools_3.0.28.bb b/meta/recipes-devtools/dosfstools/dosfstools_3.0.28.bb
new file mode 100644
index 000000000000..3a746498a013
--- /dev/null
+++ b/meta/recipes-devtools/dosfstools/dosfstools_3.0.28.bb
@@ -0,0 +1,22 @@
+# dosfstools OE build file
+# Copyright (C) 2004-2006, Advanced Micro Devices, Inc.  All Rights Reserved
+# Copyright (C) 2015, Sören Brinkmann <soeren.brinkmann@gmail>  All Rights Reserved
+# Released under the MIT license (see packages/COPYING)
+
+require dosfstools.inc
+
+HOMEPAGE = "https://github.com/dosfstools/dosfstools"
+
+LICENSE = "GPLv3"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
+
+SRC_URI = "https://github.com/dosfstools/dosfstools/releases/download/v3.0.28/dosfstools-3.0.28.tar.xz"
+SRC_URI[md5sum] = "6a047a6c65186b9ebb1853709adb36db"
+SRC_URI[sha256sum] = "ee95913044ecf2719b63ea11212917649709a6e53209a72d622135aaa8517ee2"
+
+FILES_${PN} = "${base_sbindir}"
+FILES_${PN}-doc = "${mandir} ${docdir}"
+
+do_install () {
+	oe_runmake "PREFIX=${D}${prefix}" "SBINDIR=${D}${base_sbindir}" install
+}
-- 
2.4.1.3.g4adf53d.dirty

Re: [PATCH v2] dosfstools: Add recipe for v3.0.28

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

On 25 May 2015 at 23:29, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:

> +++ b/meta/recipes-devtools/dosfstools/dosfstools.inc
> @@ -0,0 +1,8 @@
> +# dosfstools OE build file
> +# Copyright (C) 2015, Sören Brinkmann <soeren.brinkmann@gmail>  All
> Rights Reserved
> +# Released under the MIT license (see packages/COPYING)
> +
> +SUMMARY = "DOS FAT Filesystem Utilities"
> +SECTION = "base"
> +
> +BBCLASSEXTEND = "native"
>

Is it really worth having a .inc file for three lines?  Also, the makefile
still respects MANDIR so we should continue passing it in as dosfstools 2.x
does.

Ross

[-- Attachment #2: Type: text/html, Size: 1149 bytes --]

Re: [PATCH v2] dosfstools: Add recipe for v3.0.28

[Sören Brinkmann]

On Tue, 2015-06-02 at 05:22PM +0100, Burton, Ross wrote:
>    On 25 May 2015 at 23:29, Soren Brinkmann <[1]soren.brinkmann@xilinx.com>
>    wrote:
> 
>      +++ b/meta/recipes-devtools/dosfstools/dosfstools.inc
>      @@ -0,0 +1,8 @@
>      +# dosfstools OE build file
>      +# Copyright (C) 2015, Sören Brinkmann <soeren.brinkmann@gmail>  All
>      Rights Reserved
>      +# Released under the MIT license (see packages/COPYING)
>      +
>      +SUMMARY = "DOS FAT Filesystem Utilities"
>      +SECTION = "base"
>      +
>      +BBCLASSEXTEND = "native"
> 
>    Is it really worth having a .inc file for three lines?  Also, the makefile
>    still respects MANDIR so we should continue passing it in as dosfstools
>    2.x does.

The MANDIR is automatically correct with the parameters passed, I
believe.

If you prefer duplication over the inc file, that's easily accomplished.

	Sören

Re: [PATCH v2] dosfstools: Add recipe for v3.0.28

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

On 2 June 2015 at 17:36, Sören Brinkmann <soren.brinkmann@xilinx.com> wrote:

> The MANDIR is automatically correct with the parameters passed, I
> believe.
>

The makefile says:

PREFIX = /usr/local
SBINDIR = $(PREFIX)/sbin
DOCDIR = $(PREFIX)/share/doc
MANDIR = $(PREFIX)/share/man

So we should probably pass the correct paths for DOCDIR and MANDIR to
handle the distribution changing those values.

Ross

[-- Attachment #2: Type: text/html, Size: 1135 bytes --]

Re: [PATCH v2] dosfstools: Add recipe for v3.0.28

[Robert Yang]

Hello,

Why not remove the old one dosfstools_2.11.bb, please ?

// Robert

On 05/26/2015 06:29 AM, Soren Brinkmann wrote:
> Add a recipe for building the latest (as of today) version of
> dosfstools.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> v2:
>   - add recipe for 3.0.28 additionally to the 2.11 one
> ---
>   meta/recipes-devtools/dosfstools/dosfstools.inc    |  8 ++++++++
>   .../recipes-devtools/dosfstools/dosfstools_2.11.bb |  7 +++----
>   .../dosfstools/dosfstools_3.0.28.bb                | 22 ++++++++++++++++++++++
>   3 files changed, 33 insertions(+), 4 deletions(-)
>   create mode 100644 meta/recipes-devtools/dosfstools/dosfstools.inc
>   create mode 100644 meta/recipes-devtools/dosfstools/dosfstools_3.0.28.bb
>
> diff --git a/meta/recipes-devtools/dosfstools/dosfstools.inc b/meta/recipes-devtools/dosfstools/dosfstools.inc
> new file mode 100644
> index 000000000000..d2e672df1f48
> --- /dev/null
> +++ b/meta/recipes-devtools/dosfstools/dosfstools.inc
> @@ -0,0 +1,8 @@
> +# dosfstools OE build file
> +# Copyright (C) 2015, Sören Brinkmann <soeren.brinkmann@gmail>  All Rights Reserved
> +# Released under the MIT license (see packages/COPYING)
> +
> +SUMMARY = "DOS FAT Filesystem Utilities"
> +SECTION = "base"
> +
> +BBCLASSEXTEND = "native"
> diff --git a/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb b/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb
> index d1c24b874845..d237cc9b9eac 100644
> --- a/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb
> +++ b/meta/recipes-devtools/dosfstools/dosfstools_2.11.bb
> @@ -1,10 +1,11 @@
>   # dosfstools OE build file
>   # Copyright (C) 2004-2006, Advanced Micro Devices, Inc.  All Rights Reserved
>   # Released under the MIT license (see packages/COPYING)
> -SUMMARY = "DOS FAT Filesystem Utilities"
> +
> +require dosfstools.inc
> +
>   HOMEPAGE = "http://daniel-baumann.ch/software/dosfstools/"
>
> -SECTION = "base"
>   LICENSE = "GPLv2"
>   LIC_FILES_CHKSUM = "file://mkdosfs/COPYING;md5=cbe67f08d6883bff587f615f0cc81aa8"
>   PR = "r5"
> @@ -31,5 +32,3 @@ do_install () {
>   	oe_runmake "PREFIX=${D}" "SBINDIR=${D}${base_sbindir}" \
>   		   "MANDIR=${D}${mandir}/man8" install
>   }
> -
> -BBCLASSEXTEND = "native"
> diff --git a/meta/recipes-devtools/dosfstools/dosfstools_3.0.28.bb b/meta/recipes-devtools/dosfstools/dosfstools_3.0.28.bb
> new file mode 100644
> index 000000000000..3a746498a013
> --- /dev/null
> +++ b/meta/recipes-devtools/dosfstools/dosfstools_3.0.28.bb
> @@ -0,0 +1,22 @@
> +# dosfstools OE build file
> +# Copyright (C) 2004-2006, Advanced Micro Devices, Inc.  All Rights Reserved
> +# Copyright (C) 2015, Sören Brinkmann <soeren.brinkmann@gmail>  All Rights Reserved
> +# Released under the MIT license (see packages/COPYING)
> +
> +require dosfstools.inc
> +
> +HOMEPAGE = "https://github.com/dosfstools/dosfstools"
> +
> +LICENSE = "GPLv3"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> +
> +SRC_URI = "https://github.com/dosfstools/dosfstools/releases/download/v3.0.28/dosfstools-3.0.28.tar.xz"
> +SRC_URI[md5sum] = "6a047a6c65186b9ebb1853709adb36db"
> +SRC_URI[sha256sum] = "ee95913044ecf2719b63ea11212917649709a6e53209a72d622135aaa8517ee2"
> +
> +FILES_${PN} = "${base_sbindir}"
> +FILES_${PN}-doc = "${mandir} ${docdir}"
> +
> +do_install () {
> +	oe_runmake "PREFIX=${D}${prefix}" "SBINDIR=${D}${base_sbindir}" install
> +}
>

Re: [PATCH v2] dosfstools: Add recipe for v3.0.28

[Sören Brinkmann]

On Wed, 2015-06-03 at 08:25AM +0800, Robert Yang wrote:
> 
> Hello,
> 
> Why not remove the old one dosfstools_2.11.bb, please ?
[...]
> >v2:
> >  - add recipe for 3.0.28 additionally to the 2.11 one

There was a reason for this to be changed:
http://lists.openembedded.org/pipermail/openembedded-core/2015-May/105053.html

	Sören

Re: [PATCH v2] dosfstools: Add recipe for v3.0.28

[Robert Yang]

On 06/03/2015 08:31 AM, Sören Brinkmann wrote:
> On Wed, 2015-06-03 at 08:25AM +0800, Robert Yang wrote:
>>
>> Hello,
>>
>> Why not remove the old one dosfstools_2.11.bb, please ?
> [...]
>>> v2:
>>>   - add recipe for 3.0.28 additionally to the 2.11 one
>
> There was a reason for this to be changed:
> http://lists.openembedded.org/pipermail/openembedded-core/2015-May/105053.html

Thanks, yes, we need a GPLv2 version.

// Robert

>
> 	Sören
>
>