Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Joshua Lock <joshua.lock@collabora.co.uk>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] [fido] ncurses: fix native builds when host has gcc5
Date: Wed, 17 Jun 2015 12:57:43 +0100	[thread overview]
Message-ID: <558160B7.3070405@collabora.co.uk> (raw)
In-Reply-To: <1433946506-85872-1-git-send-email-martin.stolpe@gmail.com>

On 10/06/15 15:28, Martin Stolpe wrote:
> GCC"s preprocessor starts to add newlines which are not
> handled properly by ncurses build system startin from
> version 5.0.
>
> See also: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7870
>
> Signed-off-by: Martin Stolpe <martin.stolpe@gmail.com>

Thanks for the patch, I've queued a modified version that only passes -P 
to the native variant of the ncurses recipe:

http://cgit.openembedded.org/openembedded-core-contrib/commit/?h=joshuagl/fido-next&id=5b5067831144112914d2d31752177bc13ffcda5b

Regards,

Joshua

> ---
>   meta/recipes-core/ncurses/ncurses.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
> index 10f7dd1..a7a265d 100644
> --- a/meta/recipes-core/ncurses/ncurses.inc
> +++ b/meta/recipes-core/ncurses/ncurses.inc
> @@ -26,7 +26,7 @@ ENABLE_WIDEC ?= "true"
>   # _GNU_SOURCE is required for widec stuff and is detected automatically
>   # for target objects.  But it must be set manually for native and sdk
>   # builds.
> -BUILD_CPPFLAGS += "-D_GNU_SOURCE"
> +BUILD_CPPFLAGS += "-D_GNU_SOURCE -P"
>
>   # natives don't generally look in base_libdir
>   base_libdir_class-native = "${libdir}"
>



      reply	other threads:[~2015-06-17 11:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-10 14:28 [PATCH] [fido] ncurses: fix native builds when host has gcc5 Martin Stolpe
2015-06-17 11:57 ` Joshua Lock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=558160B7.3070405@collabora.co.uk \
    --to=joshua.lock@collabora.co.uk \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox