Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] [fido] ncurses: fix native builds when host has gcc5
@ 2015-06-10 14:28 Martin Stolpe
  2015-06-17 11:57 ` Joshua Lock
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Stolpe @ 2015-06-10 14:28 UTC (permalink / raw)
  To: openembedded-core; +Cc: Martin Stolpe

GCC"s preprocessor starts to add newlines which are not
handled properly by ncurses build system startin from
version 5.0.

See also: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7870

Signed-off-by: Martin Stolpe <martin.stolpe@gmail.com>
---
 meta/recipes-core/ncurses/ncurses.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
index 10f7dd1..a7a265d 100644
--- a/meta/recipes-core/ncurses/ncurses.inc
+++ b/meta/recipes-core/ncurses/ncurses.inc
@@ -26,7 +26,7 @@ ENABLE_WIDEC ?= "true"
 # _GNU_SOURCE is required for widec stuff and is detected automatically
 # for target objects.  But it must be set manually for native and sdk
 # builds.
-BUILD_CPPFLAGS += "-D_GNU_SOURCE"
+BUILD_CPPFLAGS += "-D_GNU_SOURCE -P"
 
 # natives don't generally look in base_libdir
 base_libdir_class-native = "${libdir}"
-- 
2.4.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] [fido] ncurses: fix native builds when host has gcc5
  2015-06-10 14:28 [PATCH] [fido] ncurses: fix native builds when host has gcc5 Martin Stolpe
@ 2015-06-17 11:57 ` Joshua Lock
  0 siblings, 0 replies; 2+ messages in thread
From: Joshua Lock @ 2015-06-17 11:57 UTC (permalink / raw)
  To: openembedded-core

On 10/06/15 15:28, Martin Stolpe wrote:
> GCC"s preprocessor starts to add newlines which are not
> handled properly by ncurses build system startin from
> version 5.0.
>
> See also: https://bugzilla.yoctoproject.org/show_bug.cgi?id=7870
>
> Signed-off-by: Martin Stolpe <martin.stolpe@gmail.com>

Thanks for the patch, I've queued a modified version that only passes -P 
to the native variant of the ncurses recipe:

http://cgit.openembedded.org/openembedded-core-contrib/commit/?h=joshuagl/fido-next&id=5b5067831144112914d2d31752177bc13ffcda5b

Regards,

Joshua

> ---
>   meta/recipes-core/ncurses/ncurses.inc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
> index 10f7dd1..a7a265d 100644
> --- a/meta/recipes-core/ncurses/ncurses.inc
> +++ b/meta/recipes-core/ncurses/ncurses.inc
> @@ -26,7 +26,7 @@ ENABLE_WIDEC ?= "true"
>   # _GNU_SOURCE is required for widec stuff and is detected automatically
>   # for target objects.  But it must be set manually for native and sdk
>   # builds.
> -BUILD_CPPFLAGS += "-D_GNU_SOURCE"
> +BUILD_CPPFLAGS += "-D_GNU_SOURCE -P"
>
>   # natives don't generally look in base_libdir
>   base_libdir_class-native = "${libdir}"
>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-06-17 11:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-10 14:28 [PATCH] [fido] ncurses: fix native builds when host has gcc5 Martin Stolpe
2015-06-17 11:57 ` Joshua Lock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox