Openembedded Core Discussions
 help / color / mirror / Atom feed
From: zhangxiao <xiao.zhang@windriver.com>
To: Christopher Larson <clarson@kergoth.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] logrotate: move binary logrotate back to /usr/sbin
Date: Tue, 14 Jul 2015 09:19:12 +0800	[thread overview]
Message-ID: <55A46390.2090904@windriver.com> (raw)
In-Reply-To: <CABcZANnrGkZLwZC+9qoqQJtCMcxd6z4pcSS5d2=WsnFicqpOaQ@mail.gmail.com>

On 2015年07月13日 22:28, Christopher Larson wrote:
>
> On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao <xiao.zhang@windriver.com
> <mailto:xiao.zhang@windriver.com>> wrote:
>
>     Upstream-Status: pending
>
>     Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com
>     <mailto:xiao.zhang@windriver.com>>
>
>
> There’s no info on why this is being done, only what’s being done, in
> this commit message.

Binary logrotate should be installed in /usr/sbin and int fact, at the very
beginning, it was there. While with commit a46d3646a3e1781be44:
...
logrotate: obey our flags

Needed to quiet GNU_HASH warnings, and some minor fixes.
...

Part of its modification as below:
...
-    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
+    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} 
BINDIR=${bindir}
...
moves it to /usr/bin. It is not correct, so move it back to
/usr/sbin with ${sbindir}.

Xiao

> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics


  reply	other threads:[~2015-07-14  1:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  6:10 [PATCH] logrotate: move binary logrotate back to /usr/sbin Zhang Xiao
2015-07-13 14:28 ` Christopher Larson
2015-07-14  1:19   ` zhangxiao [this message]
2015-07-14  1:47     ` Christopher Larson
2015-07-14  2:10       ` zhangxiao
2015-07-14  3:11         ` Robert Yang
2015-07-14  5:49           ` zhangxiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A46390.2090904@windriver.com \
    --to=xiao.zhang@windriver.com \
    --cc=clarson@kergoth.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox