* [PATCH] logrotate: move binary logrotate back to /usr/sbin @ 2015-07-13 6:10 Zhang Xiao 2015-07-13 14:28 ` Christopher Larson 0 siblings, 1 reply; 7+ messages in thread From: Zhang Xiao @ 2015-07-13 6:10 UTC (permalink / raw) To: openembedded-core Upstream-Status: pending Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com> --- meta/recipes-extended/logrotate/logrotate_3.9.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb index 7d0a159..6c2e222 100644 --- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb +++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb @@ -53,7 +53,7 @@ do_compile_prepend() { } do_install(){ - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} BINDIR=${bindir} + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} BINDIR=${sbindir} mkdir -p ${D}${sysconfdir}/logrotate.d mkdir -p ${D}${sysconfdir}/cron.daily mkdir -p ${D}${localstatedir}/lib -- 1.8.5.2.233.g932f7e4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] logrotate: move binary logrotate back to /usr/sbin 2015-07-13 6:10 [PATCH] logrotate: move binary logrotate back to /usr/sbin Zhang Xiao @ 2015-07-13 14:28 ` Christopher Larson 2015-07-14 1:19 ` zhangxiao 0 siblings, 1 reply; 7+ messages in thread From: Christopher Larson @ 2015-07-13 14:28 UTC (permalink / raw) To: Zhang Xiao; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 433 bytes --] On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao <xiao.zhang@windriver.com> wrote: > Upstream-Status: pending > > Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com> > There’s no info on why this is being done, only what’s being done, in this commit message. -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics [-- Attachment #2: Type: text/html, Size: 881 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] logrotate: move binary logrotate back to /usr/sbin 2015-07-13 14:28 ` Christopher Larson @ 2015-07-14 1:19 ` zhangxiao 2015-07-14 1:47 ` Christopher Larson 0 siblings, 1 reply; 7+ messages in thread From: zhangxiao @ 2015-07-14 1:19 UTC (permalink / raw) To: Christopher Larson; +Cc: Patches and discussions about the oe-core layer On 2015年07月13日 22:28, Christopher Larson wrote: > > On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao <xiao.zhang@windriver.com > <mailto:xiao.zhang@windriver.com>> wrote: > > Upstream-Status: pending > > Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com > <mailto:xiao.zhang@windriver.com>> > > > There’s no info on why this is being done, only what’s being done, in > this commit message. Binary logrotate should be installed in /usr/sbin and int fact, at the very beginning, it was there. While with commit a46d3646a3e1781be44: ... logrotate: obey our flags Needed to quiet GNU_HASH warnings, and some minor fixes. ... Part of its modification as below: ... - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} BINDIR=${bindir} ... moves it to /usr/bin. It is not correct, so move it back to /usr/sbin with ${sbindir}. Xiao > -- > Christopher Larson > clarson at kergoth dot com > Founder - BitBake, OpenEmbedded, OpenZaurus > Maintainer - Tslib > Senior Software Engineer, Mentor Graphics ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] logrotate: move binary logrotate back to /usr/sbin 2015-07-14 1:19 ` zhangxiao @ 2015-07-14 1:47 ` Christopher Larson 2015-07-14 2:10 ` zhangxiao 0 siblings, 1 reply; 7+ messages in thread From: Christopher Larson @ 2015-07-14 1:47 UTC (permalink / raw) To: zhangxiao; +Cc: Patches and discussions about the oe-core layer [-- Attachment #1: Type: text/plain, Size: 1383 bytes --] On Mon, Jul 13, 2015 at 6:19 PM, zhangxiao <xiao.zhang@windriver.com> wrote: > On 2015年07月13日 22:28, Christopher Larson wrote: > >> >> On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao <xiao.zhang@windriver.com >> <mailto:xiao.zhang@windriver.com>> wrote: >> >> Upstream-Status: pending >> >> Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com >> <mailto:xiao.zhang@windriver.com>> >> >> >> There’s no info on why this is being done, only what’s being done, in >> this commit message. >> > > Binary logrotate should be installed in /usr/sbin and int fact, at the very > beginning, it was there. While with commit a46d3646a3e1781be44: > ... > logrotate: obey our flags > > Needed to quiet GNU_HASH warnings, and some minor fixes. > ... > > Part of its modification as below: > ... > - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} > + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} > BINDIR=${bindir} > ... > moves it to /usr/bin. It is not correct, so move it back to > /usr/sbin with ${sbindir}. > That’s entirely reasonable, but at least some reference to that needs to be in the commit message, not just email discussion :) -- Christopher Larson clarson at kergoth dot com Founder - BitBake, OpenEmbedded, OpenZaurus Maintainer - Tslib Senior Software Engineer, Mentor Graphics [-- Attachment #2: Type: text/html, Size: 2207 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] logrotate: move binary logrotate back to /usr/sbin 2015-07-14 1:47 ` Christopher Larson @ 2015-07-14 2:10 ` zhangxiao 2015-07-14 3:11 ` Robert Yang 0 siblings, 1 reply; 7+ messages in thread From: zhangxiao @ 2015-07-14 2:10 UTC (permalink / raw) To: Christopher Larson; +Cc: Patches and discussions about the oe-core layer On 2015年07月14日 09:47, Christopher Larson wrote: > > On Mon, Jul 13, 2015 at 6:19 PM, zhangxiao <xiao.zhang@windriver.com > <mailto:xiao.zhang@windriver.com>> wrote: > > On 2015年07月13日 22:28, Christopher Larson wrote: > > > On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao > <xiao.zhang@windriver.com <mailto:xiao.zhang@windriver.com> > <mailto:xiao.zhang@windriver.com > <mailto:xiao.zhang@windriver.com>>> wrote: > > Upstream-Status: pending > > Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com > <mailto:xiao.zhang@windriver.com> > <mailto:xiao.zhang@windriver.com > <mailto:xiao.zhang@windriver.com>>> > > > There’s no info on why this is being done, only what’s being > done, in > this commit message. > > > Binary logrotate should be installed in /usr/sbin and int fact, at > the very > beginning, it was there. While with commit a46d3646a3e1781be44: > ... > logrotate: obey our flags > > Needed to quiet GNU_HASH warnings, and some minor fixes. > ... > > Part of its modification as below: > ... > - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} > + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} > BINDIR=${bindir} > ... > moves it to /usr/bin. It is not correct, so move it back to > /usr/sbin with ${sbindir}. > > > That’s entirely reasonable, but at least some reference to that needs to > be in the commit message, not just email discussion :) So, How about: Commit a46d36 moves logrotate to /usr/bin by mistake. Fix it. Thanks Xiao > -- > Christopher Larson > clarson at kergoth dot com > Founder - BitBake, OpenEmbedded, OpenZaurus > Maintainer - Tslib > Senior Software Engineer, Mentor Graphics ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] logrotate: move binary logrotate back to /usr/sbin 2015-07-14 2:10 ` zhangxiao @ 2015-07-14 3:11 ` Robert Yang 2015-07-14 5:49 ` zhangxiao 0 siblings, 1 reply; 7+ messages in thread From: Robert Yang @ 2015-07-14 3:11 UTC (permalink / raw) To: zhangxiao, Christopher Larson Cc: Patches and discussions about the oe-core layer On 07/14/2015 10:10 AM, zhangxiao wrote: > On 2015年07月14日 09:47, Christopher Larson wrote: >> >> On Mon, Jul 13, 2015 at 6:19 PM, zhangxiao <xiao.zhang@windriver.com >> <mailto:xiao.zhang@windriver.com>> wrote: >> >> On 2015年07月13日 22:28, Christopher Larson wrote: >> >> >> On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao >> <xiao.zhang@windriver.com <mailto:xiao.zhang@windriver.com> >> <mailto:xiao.zhang@windriver.com >> <mailto:xiao.zhang@windriver.com>>> wrote: >> >> Upstream-Status: pending >> >> Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com >> <mailto:xiao.zhang@windriver.com> >> <mailto:xiao.zhang@windriver.com >> <mailto:xiao.zhang@windriver.com>>> >> >> >> There’s no info on why this is being done, only what’s being >> done, in >> this commit message. >> >> >> Binary logrotate should be installed in /usr/sbin and int fact, at >> the very >> beginning, it was there. While with commit a46d3646a3e1781be44: >> ... >> logrotate: obey our flags >> >> Needed to quiet GNU_HASH warnings, and some minor fixes. >> ... >> >> Part of its modification as below: >> ... >> - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} >> + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} >> BINDIR=${bindir} >> ... >> moves it to /usr/bin. It is not correct, so move it back to >> /usr/sbin with ${sbindir}. >> >> >> That’s entirely reasonable, but at least some reference to that needs to >> be in the commit message, not just email discussion :) > > So, How about: > > Commit a46d36 moves logrotate to /usr/bin by mistake. Fix it. I think that you can your last email as the commit message: Binary logrotate should be installed in /usr/sbin, at the very beginning, it was there. While with commit a46d3646a3e1781be44: ... logrotate: obey our flags Needed to quiet GNU_HASH warnings, and some minor fixes. ... Part of its modification as below: ... - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} BINDIR=${bindir} ... moves it to /usr/bin. It is not correct, so move it back to /usr/sbin with ${sbindir}. // Robert > > Thanks > Xiao >> -- >> Christopher Larson >> clarson at kergoth dot com >> Founder - BitBake, OpenEmbedded, OpenZaurus >> Maintainer - Tslib >> Senior Software Engineer, Mentor Graphics ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] logrotate: move binary logrotate back to /usr/sbin 2015-07-14 3:11 ` Robert Yang @ 2015-07-14 5:49 ` zhangxiao 0 siblings, 0 replies; 7+ messages in thread From: zhangxiao @ 2015-07-14 5:49 UTC (permalink / raw) To: Robert Yang Cc: Christopher Larson, Patches and discussions about the oe-core layer On 2015年07月14日 11:11, Robert Yang wrote: > > > On 07/14/2015 10:10 AM, zhangxiao wrote: >> On 2015年07月14日 09:47, Christopher Larson wrote: >>> >>> On Mon, Jul 13, 2015 at 6:19 PM, zhangxiao <xiao.zhang@windriver.com >>> <mailto:xiao.zhang@windriver.com>> wrote: >>> >>> On 2015年07月13日 22:28, Christopher Larson wrote: >>> >>> >>> On Sun, Jul 12, 2015 at 11:10 PM, Zhang Xiao >>> <xiao.zhang@windriver.com <mailto:xiao.zhang@windriver.com> >>> <mailto:xiao.zhang@windriver.com >>> <mailto:xiao.zhang@windriver.com>>> wrote: >>> >>> Upstream-Status: pending >>> >>> Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com >>> <mailto:xiao.zhang@windriver.com> >>> <mailto:xiao.zhang@windriver.com >>> <mailto:xiao.zhang@windriver.com>>> >>> >>> >>> There’s no info on why this is being done, only what’s being >>> done, in >>> this commit message. >>> >>> >>> Binary logrotate should be installed in /usr/sbin and int fact, at >>> the very >>> beginning, it was there. While with commit a46d3646a3e1781be44: >>> ... >>> logrotate: obey our flags >>> >>> Needed to quiet GNU_HASH warnings, and some minor fixes. >>> ... >>> >>> Part of its modification as below: >>> ... >>> - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} >>> + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} >>> BINDIR=${bindir} >>> ... >>> moves it to /usr/bin. It is not correct, so move it back to >>> /usr/sbin with ${sbindir}. >>> >>> >>> That’s entirely reasonable, but at least some reference to that needs to >>> be in the commit message, not just email discussion :) >> >> So, How about: >> >> Commit a46d36 moves logrotate to /usr/bin by mistake. Fix it. > > I think that you can your last email as the commit message: > > Binary logrotate should be installed in /usr/sbin, at the very > beginning, it was there. While with commit a46d3646a3e1781be44: > ... > logrotate: obey our flags > > Needed to quiet GNU_HASH warnings, and some minor fixes. > ... > > Part of its modification as below: > ... > - oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} > + oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} > BINDIR=${bindir} > ... > moves it to /usr/bin. It is not correct, so move it back to > /usr/sbin with ${sbindir}. > Get it, I will send a new patch. Thanks Xiao > // Robert > >> >> Thanks >> Xiao >>> -- >>> Christopher Larson >>> clarson at kergoth dot com >>> Founder - BitBake, OpenEmbedded, OpenZaurus >>> Maintainer - Tslib >>> Senior Software Engineer, Mentor Graphics > > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-07-14 5:46 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-07-13 6:10 [PATCH] logrotate: move binary logrotate back to /usr/sbin Zhang Xiao 2015-07-13 14:28 ` Christopher Larson 2015-07-14 1:19 ` zhangxiao 2015-07-14 1:47 ` Christopher Larson 2015-07-14 2:10 ` zhangxiao 2015-07-14 3:11 ` Robert Yang 2015-07-14 5:49 ` zhangxiao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox