* [PATCH 0/3] Fixes for qemu and mc
@ 2015-07-28 9:05 Robert Yang
2015-07-28 9:05 ` [PATCH 1/3] mc: add PACKAGECONFIG for util-linux Robert Yang
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Robert Yang @ 2015-07-28 9:05 UTC (permalink / raw)
To: openembedded-core
The following changes since commit 27d068d05239c26a3848eb101571acab54635e37:
harfbuzz: upgrade to 1.0.1 (2015-07-27 23:28:23 +0100)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/qemu
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/qemu
Robert Yang (3):
mc: add PACKAGECONFIG for util-linux
qemu: add PACKAGECONFIG for gnutls
qemu_git.bb: remove it
meta/recipes-devtools/qemu/qemu.inc | 1 +
...-Arm-versatilepb-Add-memory-size-checking.patch | 0
.../exclude-some-arm-EABI-obsolete-syscalls.patch | 0
.../qemu-enlarge-env-entry-size.patch | 0
meta/recipes-devtools/qemu/qemu_git.bb | 15 ---------------
meta/recipes-extended/mc/mc_4.8.14.bb | 1 +
6 files changed, 2 insertions(+), 15 deletions(-)
rename meta/recipes-devtools/qemu/{files => qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%)
rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%)
rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%)
delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb
--
1.7.9.5
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/3] mc: add PACKAGECONFIG for util-linux 2015-07-28 9:05 [PATCH 0/3] Fixes for qemu and mc Robert Yang @ 2015-07-28 9:05 ` Robert Yang 2015-07-28 11:25 ` Burton, Ross 2015-07-28 9:05 ` [PATCH 2/3] qemu: add PACKAGECONFIG for gnutls Robert Yang 2015-07-28 9:05 ` [PATCH 3/3] qemu_git.bb: remove it Robert Yang 2 siblings, 1 reply; 11+ messages in thread From: Robert Yang @ 2015-07-28 9:05 UTC (permalink / raw) To: openembedded-core Fixed: mc-4.8.14: mc rdepends on util-linux-libmount, but it isn't a build dependency? [build-deps] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- meta/recipes-extended/mc/mc_4.8.14.bb | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-extended/mc/mc_4.8.14.bb b/meta/recipes-extended/mc/mc_4.8.14.bb index 8fec0b3..81a8ad9 100644 --- a/meta/recipes-extended/mc/mc_4.8.14.bb +++ b/meta/recipes-extended/mc/mc_4.8.14.bb @@ -20,6 +20,7 @@ inherit autotools gettext pkgconfig PACKAGECONFIG ??= "" PACKAGECONFIG[smb] = "--enable-vfs-smb,--disable-vfs-smb,samba," PACKAGECONFIG[sftp] = "--enable-vfs-sftp,--disable-vfs-sftp,libssh2," +PACKAGECONFIG[util-linux] = "ac_cv_lib_mount_mnt_new_table_from_file=yes,ac_cv_lib_mount_mnt_new_table_from_file=no,util-linux," EXTRA_OECONF = "--with-screen=ncurses --without-gpm-mouse --without-x" -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] mc: add PACKAGECONFIG for util-linux 2015-07-28 9:05 ` [PATCH 1/3] mc: add PACKAGECONFIG for util-linux Robert Yang @ 2015-07-28 11:25 ` Burton, Ross 2015-07-29 1:52 ` Robert Yang 0 siblings, 1 reply; 11+ messages in thread From: Burton, Ross @ 2015-07-28 11:25 UTC (permalink / raw) To: Robert Yang; +Cc: OE-core [-- Attachment #1: Type: text/plain, Size: 287 bytes --] On 28 July 2015 at 10:05, Robert Yang <liezhi.yang@windriver.com> wrote: > +PACKAGECONFIG[util-linux] = > "ac_cv_lib_mount_mnt_new_table_from_file=yes,ac_cv_lib_mount_mnt_new_table_from_file=no,util-linux," > For mc this might be something we want to enable by default. Ross [-- Attachment #2: Type: text/html, Size: 702 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] mc: add PACKAGECONFIG for util-linux 2015-07-28 11:25 ` Burton, Ross @ 2015-07-29 1:52 ` Robert Yang 0 siblings, 0 replies; 11+ messages in thread From: Robert Yang @ 2015-07-29 1:52 UTC (permalink / raw) To: Burton, Ross; +Cc: OE-core On 07/28/2015 07:25 PM, Burton, Ross wrote: > > On 28 July 2015 at 10:05, Robert Yang <liezhi.yang@windriver.com > <mailto:liezhi.yang@windriver.com>> wrote: > > +PACKAGECONFIG[util-linux] = > "ac_cv_lib_mount_mnt_new_table_from_file=yes,ac_cv_lib_mount_mnt_new_table_from_file=no,util-linux," > > > For mc this might be something we want to enable by default. Thanks, I will update it. // Robert > > Ross ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/3] qemu: add PACKAGECONFIG for gnutls 2015-07-28 9:05 [PATCH 0/3] Fixes for qemu and mc Robert Yang 2015-07-28 9:05 ` [PATCH 1/3] mc: add PACKAGECONFIG for util-linux Robert Yang @ 2015-07-28 9:05 ` Robert Yang 2015-07-28 9:05 ` [PATCH 3/3] qemu_git.bb: remove it Robert Yang 2 siblings, 0 replies; 11+ messages in thread From: Robert Yang @ 2015-07-28 9:05 UTC (permalink / raw) To: openembedded-core Fixed: qemu-2.3.99+2.4.0-rc2: qemu rdepends on nettle, but it isn't a build dependency? [build-deps] qemu-2.3.99+2.4.0-rc2: qemu rdepends on gnutls, but it isn't a build dependency? [build-deps] Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- meta/recipes-devtools/qemu/qemu.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc index eba7d3d..6a744c3 100644 --- a/meta/recipes-devtools/qemu/qemu.inc +++ b/meta/recipes-devtools/qemu/qemu.inc @@ -105,6 +105,7 @@ PACKAGECONFIG[alsa] = ",,alsa-lib" PACKAGECONFIG[glx] = "--enable-opengl,--disable-opengl,mesa" PACKAGECONFIG[lzo] = "--enable-lzo,--disable-lzo,lzo" PACKAGECONFIG[numa] = "--enable-numa,--disable-numa,numactl" +PACKAGECONFIG[gnutls] = "--enable-gnutls,--disable-gnutls,gnutls" EXTRA_OECONF += "${@bb.utils.contains('PACKAGECONFIG', 'alsa', '--audio-drv-list=oss,alsa', '', d)}" -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 3/3] qemu_git.bb: remove it 2015-07-28 9:05 [PATCH 0/3] Fixes for qemu and mc Robert Yang 2015-07-28 9:05 ` [PATCH 1/3] mc: add PACKAGECONFIG for util-linux Robert Yang 2015-07-28 9:05 ` [PATCH 2/3] qemu: add PACKAGECONFIG for gnutls Robert Yang @ 2015-07-28 9:05 ` Robert Yang 2015-07-28 14:04 ` Iorga, Cristian 2 siblings, 1 reply; 11+ messages in thread From: Robert Yang @ 2015-07-28 9:05 UTC (permalink / raw) To: openembedded-core Remove it since we have 2.4.0, the git version is 1.3 can't be built by deafult: ERROR: Fetcher failure: Unable to find revision 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from upstream We can fix it, but seems that no one uses it any more. And move patches from "files" dir to "qemu" dir. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- ...-Arm-versatilepb-Add-memory-size-checking.patch | 0 .../exclude-some-arm-EABI-obsolete-syscalls.patch | 0 .../qemu-enlarge-env-entry-size.patch | 0 meta/recipes-devtools/qemu/qemu_git.bb | 15 --------------- 4 files changed, 15 deletions(-) rename meta/recipes-devtools/qemu/{files => qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%) delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb diff --git a/meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch b/meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch similarity index 100% rename from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch rename to meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch diff --git a/meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch b/meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch similarity index 100% rename from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch rename to meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch diff --git a/meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch b/meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch similarity index 100% rename from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch rename to meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch diff --git a/meta/recipes-devtools/qemu/qemu_git.bb b/meta/recipes-devtools/qemu/qemu_git.bb deleted file mode 100644 index a30932a..0000000 --- a/meta/recipes-devtools/qemu/qemu_git.bb +++ /dev/null @@ -1,15 +0,0 @@ -require qemu.inc - -SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8" - -LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \ - file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913" - -PV = "1.3.0+git${SRCPV}" - -SRC_URI_prepend = "git://git.qemu.org/qemu.git" -S = "${WORKDIR}/git" - -DEFAULT_PREFERENCE = "-1" - -COMPATIBLE_HOST_class-target_mips64 = "null" -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] qemu_git.bb: remove it 2015-07-28 9:05 ` [PATCH 3/3] qemu_git.bb: remove it Robert Yang @ 2015-07-28 14:04 ` Iorga, Cristian 2015-07-28 14:16 ` Martin Jansa 0 siblings, 1 reply; 11+ messages in thread From: Iorga, Cristian @ 2015-07-28 14:04 UTC (permalink / raw) To: Yang, Liezhi (Wind River), openembedded-core@lists.openembedded.org Hi Robert, Hmm, Qemu git recipe is useful, and is close to being up to date, why to remove it?? Qemu brakes quite often, as seen recently on autobuilders, building from git allowed us to move forward (although it is true that the git upgrade was not integrated into master.) I vote against this patch. Thanks, Cristian -----Original Message----- From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Robert Yang Sent: Tuesday, July 28, 2015 12:05 PM To: openembedded-core@lists.openembedded.org Subject: [OE-core] [PATCH 3/3] qemu_git.bb: remove it Remove it since we have 2.4.0, the git version is 1.3 can't be built by deafult: ERROR: Fetcher failure: Unable to find revision 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from upstream We can fix it, but seems that no one uses it any more. And move patches from "files" dir to "qemu" dir. Signed-off-by: Robert Yang <liezhi.yang@windriver.com> --- ...-Arm-versatilepb-Add-memory-size-checking.patch | 0 .../exclude-some-arm-EABI-obsolete-syscalls.patch | 0 .../qemu-enlarge-env-entry-size.patch | 0 meta/recipes-devtools/qemu/qemu_git.bb | 15 --------------- 4 files changed, 15 deletions(-) rename meta/recipes-devtools/qemu/{files => qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%) delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb diff --git a/meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch b/meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch similarity index 100% rename from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch rename to meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch diff --git a/meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch b/meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch similarity index 100% rename from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch rename to meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch diff --git a/meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch b/meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch similarity index 100% rename from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch rename to meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch diff --git a/meta/recipes-devtools/qemu/qemu_git.bb b/meta/recipes-devtools/qemu/qemu_git.bb deleted file mode 100644 index a30932a..0000000 --- a/meta/recipes-devtools/qemu/qemu_git.bb +++ /dev/null @@ -1,15 +0,0 @@ -require qemu.inc - -SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8" - -LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \ - file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913" - -PV = "1.3.0+git${SRCPV}" - -SRC_URI_prepend = "git://git.qemu.org/qemu.git" -S = "${WORKDIR}/git" - -DEFAULT_PREFERENCE = "-1" - -COMPATIBLE_HOST_class-target_mips64 = "null" -- 1.7.9.5 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] qemu_git.bb: remove it 2015-07-28 14:04 ` Iorga, Cristian @ 2015-07-28 14:16 ` Martin Jansa 2015-07-28 14:18 ` Burton, Ross 2015-07-28 14:33 ` Iorga, Cristian 0 siblings, 2 replies; 11+ messages in thread From: Martin Jansa @ 2015-07-28 14:16 UTC (permalink / raw) To: Iorga, Cristian; +Cc: openembedded-core@lists.openembedded.org [-- Attachment #1: Type: text/plain, Size: 4735 bytes --] On Tue, Jul 28, 2015 at 02:04:28PM +0000, Iorga, Cristian wrote: > Hi Robert, > > Hmm, > Qemu git recipe is useful, and is close to being up to date, why to remove it?? Close to being up to date? Aren't you talking about ./meta/recipes-devtools/qemu/qemu_2.4.0-rc2.bb? bitbake@jama:/OE/webos/ow/oe-core$ find . -name qemu\*bb -exec grep PV.*= {} \; REALPV = "2.4.0-rc2" PV = "2.3.99+${REALPV}" PV = "1.3.0+git${SRCPV}" As Robert said, 1.3 version is old and current qemu_git recipe broken, because 04024dea2674861fcf13582a77b58130c67fccd8 isn't in master branch anymore after it was moved to stable-1.3 branch: bitbake@jama:/OE/projects/qemu$ git branch -a --contains 04024dea2674861fcf13582a77b58130c67fccd8 remotes/origin/stable-1.3 > Qemu brakes quite often, as seen recently on autobuilders, building from git allowed us to move forward (although it is true that the git upgrade was not integrated into master.) > I vote against this patch. Regards, > > Thanks, > Cristian > > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Robert Yang > Sent: Tuesday, July 28, 2015 12:05 PM > To: openembedded-core@lists.openembedded.org > Subject: [OE-core] [PATCH 3/3] qemu_git.bb: remove it > > Remove it since we have 2.4.0, the git version is 1.3 can't be built by > deafult: > ERROR: Fetcher failure: Unable to find revision 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from upstream > > We can fix it, but seems that no one uses it any more. > > And move patches from "files" dir to "qemu" dir. > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > --- > ...-Arm-versatilepb-Add-memory-size-checking.patch | 0 > .../exclude-some-arm-EABI-obsolete-syscalls.patch | 0 > .../qemu-enlarge-env-entry-size.patch | 0 > meta/recipes-devtools/qemu/qemu_git.bb | 15 --------------- > 4 files changed, 15 deletions(-) > rename meta/recipes-devtools/qemu/{files => qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%) rename meta/recipes-devtools/qemu/{files => qemu}/qemu-enlarge-env-entry-size.patch (100%) delete mode 100644 meta/recipes-devtools/qemu/qemu_git.bb > > diff --git a/meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch b/meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch > similarity index 100% > rename from meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size-checking.patch > rename to meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-checking.patch > diff --git a/meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch b/meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch > similarity index 100% > rename from meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscalls.patch > rename to meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscalls.patch > diff --git a/meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch b/meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch > similarity index 100% > rename from meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch > rename to meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch > diff --git a/meta/recipes-devtools/qemu/qemu_git.bb b/meta/recipes-devtools/qemu/qemu_git.bb > deleted file mode 100644 > index a30932a..0000000 > --- a/meta/recipes-devtools/qemu/qemu_git.bb > +++ /dev/null > @@ -1,15 +0,0 @@ > -require qemu.inc > - > -SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8" > - > -LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \ > - file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913" > - > -PV = "1.3.0+git${SRCPV}" > - > -SRC_URI_prepend = "git://git.qemu.org/qemu.git" > -S = "${WORKDIR}/git" > - > -DEFAULT_PREFERENCE = "-1" > - > -COMPATIBLE_HOST_class-target_mips64 = "null" > -- > 1.7.9.5 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 188 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] qemu_git.bb: remove it 2015-07-28 14:16 ` Martin Jansa @ 2015-07-28 14:18 ` Burton, Ross 2015-07-28 14:33 ` Iorga, Cristian 1 sibling, 0 replies; 11+ messages in thread From: Burton, Ross @ 2015-07-28 14:18 UTC (permalink / raw) To: Martin Jansa; +Cc: openembedded-core@lists.openembedded.org [-- Attachment #1: Type: text/plain, Size: 759 bytes --] On 28 July 2015 at 15:16, Martin Jansa <martin.jansa@gmail.com> wrote: > Close to being up to date? Aren't you talking about > ./meta/recipes-devtools/qemu/qemu_2.4.0-rc2.bb? > > bitbake@jama:/OE/webos/ow/oe-core$ find . -name qemu\*bb -exec grep > PV.*= {} \; > REALPV = "2.4.0-rc2" > PV = "2.3.99+${REALPV}" > PV = "1.3.0+git${SRCPV}" > > As Robert said, 1.3 version is old and current qemu_git recipe broken, > because 04024dea2674861fcf13582a77b58130c67fccd8 isn't in master branch > anymore after it was moved to stable-1.3 branch: > For local testing it's not exactly rocket science to set SRC_URI and S in a bbappend. _git recipes are fine *if they're actively used* but when they sit around and bitrot, what's the point? Ross [-- Attachment #2: Type: text/html, Size: 1309 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] qemu_git.bb: remove it 2015-07-28 14:16 ` Martin Jansa 2015-07-28 14:18 ` Burton, Ross @ 2015-07-28 14:33 ` Iorga, Cristian 2015-07-29 1:52 ` Robert Yang 1 sibling, 1 reply; 11+ messages in thread From: Iorga, Cristian @ 2015-07-28 14:33 UTC (permalink / raw) To: Martin Jansa; +Cc: openembedded-core@lists.openembedded.org I am not in the habit of talking without knowing. Usually. There might be exceptions. This is not one. That being said, I was able to switch to qemu git recipe (instead of the tarball releases) and make it work for a git head just before 2.4.0RC0 in under 20 minutes. The patch was not submitted for inclusion into master however. I am not sure why the git recipe bothers everyone that much in this specific case, when I just explained that it was quite useful for me (and by extension, to the project). Thanks, Cristian -----Original Message----- From: Martin Jansa [mailto:martin.jansa@gmail.com] Sent: Tuesday, July 28, 2015 5:16 PM To: Iorga, Cristian Cc: Yang, Liezhi (Wind River); openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH 3/3] qemu_git.bb: remove it On Tue, Jul 28, 2015 at 02:04:28PM +0000, Iorga, Cristian wrote: > Hi Robert, > > Hmm, > Qemu git recipe is useful, and is close to being up to date, why to remove it?? Close to being up to date? Aren't you talking about ./meta/recipes-devtools/qemu/qemu_2.4.0-rc2.bb? bitbake@jama:/OE/webos/ow/oe-core$ find . -name qemu\*bb -exec grep PV.*= {} \; REALPV = "2.4.0-rc2" PV = "2.3.99+${REALPV}" PV = "1.3.0+git${SRCPV}" As Robert said, 1.3 version is old and current qemu_git recipe broken, because 04024dea2674861fcf13582a77b58130c67fccd8 isn't in master branch anymore after it was moved to stable-1.3 branch: bitbake@jama:/OE/projects/qemu$ git branch -a --contains 04024dea2674861fcf13582a77b58130c67fccd8 remotes/origin/stable-1.3 > Qemu brakes quite often, as seen recently on autobuilders, building > from git allowed us to move forward (although it is true that the git upgrade was not integrated into master.) I vote against this patch. Regards, > > Thanks, > Cristian > > -----Original Message----- > From: openembedded-core-bounces@lists.openembedded.org > [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of > Robert Yang > Sent: Tuesday, July 28, 2015 12:05 PM > To: openembedded-core@lists.openembedded.org > Subject: [OE-core] [PATCH 3/3] qemu_git.bb: remove it > > Remove it since we have 2.4.0, the git version is 1.3 can't be built > by > deafult: > ERROR: Fetcher failure: Unable to find revision > 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from > upstream > > We can fix it, but seems that no one uses it any more. > > And move patches from "files" dir to "qemu" dir. > > Signed-off-by: Robert Yang <liezhi.yang@windriver.com> > --- > ...-Arm-versatilepb-Add-memory-size-checking.patch | 0 > .../exclude-some-arm-EABI-obsolete-syscalls.patch | 0 > .../qemu-enlarge-env-entry-size.patch | 0 > meta/recipes-devtools/qemu/qemu_git.bb | 15 --------------- > 4 files changed, 15 deletions(-) > rename meta/recipes-devtools/qemu/{files => > qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%) > rename meta/recipes-devtools/qemu/{files => > qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%) rename > meta/recipes-devtools/qemu/{files => > qemu}/qemu-enlarge-env-entry-size.patch (100%) delete mode 100644 > meta/recipes-devtools/qemu/qemu_git.bb > > diff --git > a/meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-siz > e-checking.patch > b/meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size > -checking.patch > similarity index 100% > rename from > meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size- > checking.patch rename to > meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-c > hecking.patch diff --git > a/meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-sysc > alls.patch > b/meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-sysca > lls.patch > similarity index 100% > rename from > meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscal > ls.patch rename to > meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscall > s.patch diff --git > a/meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch > b/meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch > similarity index 100% > rename from > meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch > rename to > meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch > diff --git a/meta/recipes-devtools/qemu/qemu_git.bb > b/meta/recipes-devtools/qemu/qemu_git.bb > deleted file mode 100644 > index a30932a..0000000 > --- a/meta/recipes-devtools/qemu/qemu_git.bb > +++ /dev/null > @@ -1,15 +0,0 @@ > -require qemu.inc > - > -SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8" > - > -LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \ > - file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913" > - > -PV = "1.3.0+git${SRCPV}" > - > -SRC_URI_prepend = "git://git.qemu.org/qemu.git" > -S = "${WORKDIR}/git" > - > -DEFAULT_PREFERENCE = "-1" > - > -COMPATIBLE_HOST_class-target_mips64 = "null" > -- > 1.7.9.5 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] qemu_git.bb: remove it 2015-07-28 14:33 ` Iorga, Cristian @ 2015-07-29 1:52 ` Robert Yang 0 siblings, 0 replies; 11+ messages in thread From: Robert Yang @ 2015-07-29 1:52 UTC (permalink / raw) To: Iorga, Cristian, Martin Jansa; +Cc: openembedded-core@lists.openembedded.org On 07/28/2015 10:33 PM, Iorga, Cristian wrote: > I am not in the habit of talking without knowing. Usually. > There might be exceptions. This is not one. > That being said, I was able to switch to qemu git recipe (instead of the tarball releases) and make it work for a git head just before 2.4.0RC0 in under 20 minutes. > The patch was not submitted for inclusion into master however. > I am not sure why the git recipe bothers everyone that much in this specific case, when I just explained that it was quite useful for me (and by extension, to the project). Hi Cristian, The problem is that it is broken, we need try to avoid shipping broken recipes to confuse the end user, you can fix it to make it work, but qemu 1.3 and 2.4 have different configure options, you will get warnings about unknown configure options, so you need move a few PACKAGECONFIGs from qemu.inc to qemu_2.4.bb to fix the warnings, that seems not worth, so I removed it, if you do like qemu_git.bb recipes, I think that you can upgrade it to 2.4.0-rc2 and replace qemu_2.4.0-rc2.bb. // Robert > Thanks, > Cristian > > -----Original Message----- > From: Martin Jansa [mailto:martin.jansa@gmail.com] > Sent: Tuesday, July 28, 2015 5:16 PM > To: Iorga, Cristian > Cc: Yang, Liezhi (Wind River); openembedded-core@lists.openembedded.org > Subject: Re: [OE-core] [PATCH 3/3] qemu_git.bb: remove it > > On Tue, Jul 28, 2015 at 02:04:28PM +0000, Iorga, Cristian wrote: >> Hi Robert, >> >> Hmm, >> Qemu git recipe is useful, and is close to being up to date, why to remove it?? > > Close to being up to date? Aren't you talking about ./meta/recipes-devtools/qemu/qemu_2.4.0-rc2.bb? > > bitbake@jama:/OE/webos/ow/oe-core$ find . -name qemu\*bb -exec grep PV.*= {} \; REALPV = "2.4.0-rc2" > PV = "2.3.99+${REALPV}" > PV = "1.3.0+git${SRCPV}" > > As Robert said, 1.3 version is old and current qemu_git recipe broken, because 04024dea2674861fcf13582a77b58130c67fccd8 isn't in master branch anymore after it was moved to stable-1.3 branch: > > bitbake@jama:/OE/projects/qemu$ git branch -a --contains 04024dea2674861fcf13582a77b58130c67fccd8 > remotes/origin/stable-1.3 > >> Qemu brakes quite often, as seen recently on autobuilders, building >> from git allowed us to move forward (although it is true that the git upgrade was not integrated into master.) I vote against this patch. > > Regards, >> >> Thanks, >> Cristian >> >> -----Original Message----- >> From: openembedded-core-bounces@lists.openembedded.org >> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of >> Robert Yang >> Sent: Tuesday, July 28, 2015 12:05 PM >> To: openembedded-core@lists.openembedded.org >> Subject: [OE-core] [PATCH 3/3] qemu_git.bb: remove it >> >> Remove it since we have 2.4.0, the git version is 1.3 can't be built >> by >> deafult: >> ERROR: Fetcher failure: Unable to find revision >> 04024dea2674861fcf13582a77b58130c67fccd8 in branch master even from >> upstream >> >> We can fix it, but seems that no one uses it any more. >> >> And move patches from "files" dir to "qemu" dir. >> >> Signed-off-by: Robert Yang <liezhi.yang@windriver.com> >> --- >> ...-Arm-versatilepb-Add-memory-size-checking.patch | 0 >> .../exclude-some-arm-EABI-obsolete-syscalls.patch | 0 >> .../qemu-enlarge-env-entry-size.patch | 0 >> meta/recipes-devtools/qemu/qemu_git.bb | 15 --------------- >> 4 files changed, 15 deletions(-) >> rename meta/recipes-devtools/qemu/{files => >> qemu}/Qemu-Arm-versatilepb-Add-memory-size-checking.patch (100%) >> rename meta/recipes-devtools/qemu/{files => >> qemu}/exclude-some-arm-EABI-obsolete-syscalls.patch (100%) rename >> meta/recipes-devtools/qemu/{files => >> qemu}/qemu-enlarge-env-entry-size.patch (100%) delete mode 100644 >> meta/recipes-devtools/qemu/qemu_git.bb >> >> diff --git >> a/meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-siz >> e-checking.patch >> b/meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size >> -checking.patch >> similarity index 100% >> rename from >> meta/recipes-devtools/qemu/files/Qemu-Arm-versatilepb-Add-memory-size- >> checking.patch rename to >> meta/recipes-devtools/qemu/qemu/Qemu-Arm-versatilepb-Add-memory-size-c >> hecking.patch diff --git >> a/meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-sysc >> alls.patch >> b/meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-sysca >> lls.patch >> similarity index 100% >> rename from >> meta/recipes-devtools/qemu/files/exclude-some-arm-EABI-obsolete-syscal >> ls.patch rename to >> meta/recipes-devtools/qemu/qemu/exclude-some-arm-EABI-obsolete-syscall >> s.patch diff --git >> a/meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch >> b/meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch >> similarity index 100% >> rename from >> meta/recipes-devtools/qemu/files/qemu-enlarge-env-entry-size.patch >> rename to >> meta/recipes-devtools/qemu/qemu/qemu-enlarge-env-entry-size.patch >> diff --git a/meta/recipes-devtools/qemu/qemu_git.bb >> b/meta/recipes-devtools/qemu/qemu_git.bb >> deleted file mode 100644 >> index a30932a..0000000 >> --- a/meta/recipes-devtools/qemu/qemu_git.bb >> +++ /dev/null >> @@ -1,15 +0,0 @@ >> -require qemu.inc >> - >> -SRCREV = "04024dea2674861fcf13582a77b58130c67fccd8" >> - >> -LIC_FILES_CHKSUM = "file://COPYING;md5=441c28d2cf86e15a37fa47e15a72fbac \ >> - file://COPYING.LIB;endline=24;md5=c04def7ae38850e7d3ef548588159913" >> - >> -PV = "1.3.0+git${SRCPV}" >> - >> -SRC_URI_prepend = "git://git.qemu.org/qemu.git" >> -S = "${WORKDIR}/git" >> - >> -DEFAULT_PREFERENCE = "-1" >> - >> -COMPATIBLE_HOST_class-target_mips64 = "null" >> -- >> 1.7.9.5 >> >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> -- >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > -- > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com > > ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-07-29 1:52 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-07-28 9:05 [PATCH 0/3] Fixes for qemu and mc Robert Yang 2015-07-28 9:05 ` [PATCH 1/3] mc: add PACKAGECONFIG for util-linux Robert Yang 2015-07-28 11:25 ` Burton, Ross 2015-07-29 1:52 ` Robert Yang 2015-07-28 9:05 ` [PATCH 2/3] qemu: add PACKAGECONFIG for gnutls Robert Yang 2015-07-28 9:05 ` [PATCH 3/3] qemu_git.bb: remove it Robert Yang 2015-07-28 14:04 ` Iorga, Cristian 2015-07-28 14:16 ` Martin Jansa 2015-07-28 14:18 ` Burton, Ross 2015-07-28 14:33 ` Iorga, Cristian 2015-07-29 1:52 ` Robert Yang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox