From: Randy MacLeod <randy.macleod@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] Rename 'BRANCH' variable to 'SRC_BRANCH' for clearness
Date: Sat, 22 Aug 2015 00:20:14 -0400 [thread overview]
Message-ID: <55D7F87E.3050803@windriver.com> (raw)
In-Reply-To: <CAP9ODKrEBfBH-+Z2VYg3qG5Bpi7aDozn6F1Z9r7MP3qC8Zs+RQ@mail.gmail.com>
On 2015-08-21 05:58 PM, Otavio Salvador wrote:
> On Fri, Aug 21, 2015 at 6:49 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>
>>> On Aug 21, 2015, at 2:38 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>>
>>> The 'BRANCH' variable name has no explicit relation with the
>>> SRC_URI. Using 'SRC_BRANCH' makes it more obvious and easier to
>>> identify.
>>
>> Look good to me, just may be avoid ‘_’ and call it SRCBRANCH
>
> I did this initially but looking at how it looks in the source code,
> it seems SRC_BRANCH makes easier to spot the relation with SRC_URI. So
> I took the second.
+1
--
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON,
Canada, K2K 2W5
next prev parent reply other threads:[~2015-08-22 4:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 21:38 [PATCH] Rename 'BRANCH' variable to 'SRC_BRANCH' for clearness Otavio Salvador
2015-08-21 21:49 ` Khem Raj
2015-08-21 21:58 ` Otavio Salvador
2015-08-22 4:20 ` Randy MacLeod [this message]
2015-08-22 6:03 ` Khem Raj
2015-08-22 9:08 ` Richard Purdie
2015-08-22 10:48 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D7F87E.3050803@windriver.com \
--to=randy.macleod@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox