Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] perf: fix the check
@ 2015-08-21  8:06 rongqing.li
  2015-08-21 13:26 ` Burton, Ross
  0 siblings, 1 reply; 4+ messages in thread
From: rongqing.li @ 2015-08-21  8:06 UTC (permalink / raw)
  To: openembedded-core

From: Roy Li <rongqing.li@windriver.com>

$(grep xxx xxx) never returns 0, it maybe return empty or a string, and
can not compare with 0

Signed-off-by: Roy Li <rongqing.li@windriver.com>
---
 meta/recipes-kernel/perf/perf.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 246f1b4..0aff9fb 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -111,7 +111,7 @@ do_install() {
 	unset CFLAGS
 	oe_runmake DESTDIR=${D} install
 	# we are checking for this make target to be compatible with older perf versions
-	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" -a $(grep install-python_ext ${S}/tools/perf/Makefile) = "0" ]; then
+	if [ "${@perf_feature_enabled('perf-scripting', 1, 0, d)}" = "1" ] && grep -q install-python_ext ${S}/tools/perf/Makefile; then
 		oe_runmake DESTDIR=${D} install-python_ext
 	fi
 }
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-24  6:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-21  8:06 [PATCH] perf: fix the check rongqing.li
2015-08-21 13:26 ` Burton, Ross
2015-08-21 13:48   ` Richard Purdie
2015-08-24  6:50   ` Rongqing Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox