Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: Martin Jansa <martin.jansa@gmail.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH][master][fido][dizzy] Revert "perf: fix for rebuilding"
Date: Wed, 16 Sep 2015 15:48:58 +0800	[thread overview]
Message-ID: <55F91EEA.8040005@windriver.com> (raw)
In-Reply-To: <55F7B25B.6030801@windriver.com>


Hi Martin,

I've figured out the reason, this is because the task's default cwd
is ${B}, the easier way to fix the problem is use mkdir -p rather than
mkdir, autotools.bbclass also has this problem, but I'd like to fix
exec_func, I will send a patch to bitbake-devel after more testing.

// Robert

On 09/15/2015 01:53 PM, Robert Yang wrote:
>
> Hi Martin,
>
> Sorry, I'm blocked by mutitlib SDK issues recently, I will fix it sooner.
> Revert the patch is fine to me if it is urgent.
>
> // Robert
>
> On 09/15/2015 01:29 PM, Martin Jansa wrote:
>> * This reverts commit 9dafa571ed0a40d21a886dec7704c31150b21942.
>>
>> * The "fix" is causing more issues then it's fixing and there was no
>>    feedback in many months.
>> * More info:
>>
>> http://lists.openembedded.org/pipermail/openembedded-core/2015-June/105684.html
>>
>> http://lists.openembedded.org/pipermail/openembedded-core/2015-September/109870.html
>>
>>
>> http://lists.openembedded.org/pipermail/openembedded-core/2015-September/110338.html
>>
>>
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
>> ---
>>   meta/recipes-kernel/perf/perf.bb | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
>> index adb3a2c..f1d7894 100644
>> --- a/meta/recipes-kernel/perf/perf.bb
>> +++ b/meta/recipes-kernel/perf/perf.bb
>> @@ -118,10 +118,6 @@ do_install() {
>>   }
>>
>>   do_configure_prepend () {
>> -    # Fix for rebuilding
>> -    rm -rf ${B}/
>> -    mkdir ${B}/
>> -
>>       # If building a multlib based perf, the incorrect library path will be
>>       # detected by perf, since it triggers via: ifeq ($(ARCH),x86_64). In a
>> 32 bit
>>       # build, with a 64 bit multilib, the arch won't match and the detection
>> of a
>>


  reply	other threads:[~2015-09-16  7:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-02 16:00 Robert Yang : perf: fix for rebuilding Martin Jansa
2015-09-10 16:05 ` Martin Jansa
2015-09-15  5:29   ` [PATCH][master][fido][dizzy] Revert "perf: fix for rebuilding" Martin Jansa
2015-09-15  5:53     ` Robert Yang
2015-09-16  7:48       ` Robert Yang [this message]
2015-09-16  8:57         ` Burton, Ross
2015-09-16  9:07           ` Robert Yang
2015-09-21 19:04         ` Martin Jansa
2015-09-21 19:36           ` [RFC][PATCH] perf: don't re-create ${B} Martin Jansa
2015-09-21 20:33           ` [RFC][PATCHv2] cmake.bbclass, " Martin Jansa
2015-09-21 20:55             ` Burton, Ross
2015-09-22  5:44               ` Martin Jansa
2015-09-22  8:10             ` Richard Purdie
2015-09-22  9:36               ` Burton, Ross
2015-09-22  5:48           ` [RFC][PATCHv3] autotools.bbclass, " Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55F91EEA.8040005@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox