[PATCH] gnutls: cleanup buildpaths from gnutls.pc

[PATCH] gnutls: cleanup buildpaths from gnutls.pc

[wenzong.fan]

From: Wenzong Fan <wenzong.fan@windriver.com>

* gnutls.pc:
  -L/path/to/tmp/sysroots/qemux86-64/lib64 -> -L/lib64

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
 meta/recipes-support/gnutls/gnutls.inc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
index e9b138a..0a5e663 100644
--- a/meta/recipes-support/gnutls/gnutls.inc
+++ b/meta/recipes-support/gnutls/gnutls.inc
@@ -38,6 +38,11 @@ PACKAGECONFIG ??= "zlib"
 PACKAGECONFIG[tpm] = "--with-tpm, --without-tpm, trousers"
 PACKAGECONFIG[zlib] = "--with-zlib, --without-zlib, zlib"
 
+do_install_append() {
+	# cleanup buildpaths from gnutls.pc
+	sed -i -e 's#${STAGING_DIR_HOST}##g' ${D}${libdir}/pkgconfig/gnutls.pc
+}
+
 PACKAGES =+ "${PN}-openssl ${PN}-xx"
 
 FILES_${PN}-dev += "${bindir}/gnutls-cli-debug"
-- 
1.9.1

Re: [PATCH] gnutls: cleanup buildpaths from gnutls.pc

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

On 24 September 2015 at 14:04, <wenzong.fan@windriver.com> wrote:

> From: Wenzong Fan <wenzong.fan@windriver.com>
>
> * gnutls.pc:
>   -L/path/to/tmp/sysroots/qemux86-64/lib64 -> -L/lib64
>

I'm not seeing this problem and gnutls.pc.in file looks ok to me. Any idea
how I could reproduce this?

Jussi


Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
>  meta/recipes-support/gnutls/gnutls.inc | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-support/gnutls/gnutls.inc
> b/meta/recipes-support/gnutls/gnutls.inc
> index e9b138a..0a5e663 100644
> --- a/meta/recipes-support/gnutls/gnutls.inc
> +++ b/meta/recipes-support/gnutls/gnutls.inc
> @@ -38,6 +38,11 @@ PACKAGECONFIG ??= "zlib"
>  PACKAGECONFIG[tpm] = "--with-tpm, --without-tpm, trousers"
>  PACKAGECONFIG[zlib] = "--with-zlib, --without-zlib, zlib"
>
> +do_install_append() {
> +       # cleanup buildpaths from gnutls.pc
> +       sed -i -e 's#${STAGING_DIR_HOST}##g'
> ${D}${libdir}/pkgconfig/gnutls.pc
> +}
> +
>  PACKAGES =+ "${PN}-openssl ${PN}-xx"
>
>  FILES_${PN}-dev += "${bindir}/gnutls-cli-debug"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2356 bytes --]

Re: [PATCH] gnutls: cleanup buildpaths from gnutls.pc

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 519 bytes --]

On 24 September 2015 at 12:49, Jussi Kukkonen <jussi.kukkonen@intel.com>
wrote:

> I'm not seeing this problem and gnutls.pc.in file looks ok to me. Any
> idea how I could reproduce this?
>

Also, just sedding them out of the resulting file seems suboptimal compared
to finding out where the path is coming from and fixing that, so it would
be good to see an analysis as to where the path comes from.  Last timeI
fixed a number of those it exposed real problems or bad assumptions in the
makefiles.

Ross

[-- Attachment #2: Type: text/html, Size: 995 bytes --]

Re: [PATCH] gnutls: cleanup buildpaths from gnutls.pc

[wenzong fan]

On 09/24/2015 07:49 PM, Jussi Kukkonen wrote:
> On 24 September 2015 at 14:04, <wenzong.fan@windriver.com
> <mailto:wenzong.fan@windriver.com>> wrote:
>
>     From: Wenzong Fan <wenzong.fan@windriver.com
>     <mailto:wenzong.fan@windriver.com>>
>
>     * gnutls.pc:
>        -L/path/to/tmp/sysroots/qemux86-64/lib64 -> -L/lib64
>
>
> I'm not seeing this problem and gnutls.pc.in <http://gnutls.pc.in> file
> looks ok to me. Any idea how I could reproduce this?

Sorry for the confusion, I'll update the commit logs.

To reproduce the issue with qemux86-64:

1. update local.conf:

MACHINE ?= "qemux86-64"
require conf/multilib.conf
MULTILIBS ?= "multilib:lib32 multilib:lib64"
DEFAULTTUNE_virtclass-multilib-lib32 ?= "x86"
DEFAULTTUNE_virtclass-multilib-lib64 ?= "x86-64"

2. run bitbake gnutls

3. check gnutls.pc:

Libs.private: 
-L/buildarea/raid5/wfan/yocto/builds/poky-build/tmp/sysroots/qemux86-64/usr/lib64 
-lz        -lgmp

Thanks
Wenzong

>
> Jussi
>
>     Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com
>     <mailto:wenzong.fan@windriver.com>>
>     ---
>       meta/recipes-support/gnutls/gnutls.inc | 5 +++++
>       1 file changed, 5 insertions(+)
>
>     diff --git a/meta/recipes-support/gnutls/gnutls.inc
>     b/meta/recipes-support/gnutls/gnutls.inc
>     index e9b138a..0a5e663 100644
>     --- a/meta/recipes-support/gnutls/gnutls.inc
>     +++ b/meta/recipes-support/gnutls/gnutls.inc
>     @@ -38,6 +38,11 @@ PACKAGECONFIG ??= "zlib"
>       PACKAGECONFIG[tpm] = "--with-tpm, --without-tpm, trousers"
>       PACKAGECONFIG[zlib] = "--with-zlib, --without-zlib, zlib"
>
>     +do_install_append() {
>     +       # cleanup buildpaths from gnutls.pc
>     +       sed -i -e 's#${STAGING_DIR_HOST}##g'
>     ${D}${libdir}/pkgconfig/gnutls.pc
>     +}
>     +
>       PACKAGES =+ "${PN}-openssl ${PN}-xx"
>
>       FILES_${PN}-dev += "${bindir}/gnutls-cli-debug"
>     --
>     1.9.1
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

Re: [PATCH] gnutls: cleanup buildpaths from gnutls.pc

[wenzong fan]

On 09/24/2015 07:55 PM, Burton, Ross wrote:
>
> On 24 September 2015 at 12:49, Jussi Kukkonen <jussi.kukkonen@intel.com
> <mailto:jussi.kukkonen@intel.com>> wrote:
>
>     I'm not seeing this problem and gnutls.pc.in <http://gnutls.pc.in>
>     file looks ok to me. Any idea how I could reproduce this?
>
>
> Also, just sedding them out of the resulting file seems suboptimal
> compared to finding out where the path is coming from and fixing that,
> so it would be good to see an analysis as to where the path comes from.
> Last timeI fixed a number of those it exposed real problems or bad
> assumptions in the makefiles.
>
> Ross

For this case, or such cases that use pkg-config to compute paths for 
LIBS (such as zlib), they have different behaviors:

* multilib enabled build:

$ bitbake gnutls -cdevshell
$ pkg-config --libs zlib

-L/buildarea/raid5/wfan/yocto/builds/poky-build/tmp/sysroots/qemux86-64/usr/lib64 
-lz

* build w/o multilib

$ bitbake gnutls -cdevshell
$ pkg-config --libs zlib

-lz

This is where the buildpaths from for target pkgconfig files. Ideally it 
should be fixed from pkg-config side, but just fix it with sed is 
acceptable I think if the former is impossible.

I'll investigate more about that. Do you know where the difference from?

Thanks
Wenzong

Re: [PATCH] gnutls: cleanup buildpaths from gnutls.pc

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 414 bytes --]

On 25 September 2015 at 11:21, wenzong fan <wenzong.fan@windriver.com>
wrote:

> I'll investigate more about that. Do you know where the difference from?
>

I'd immediately suspect the lib/lib64 path confusing pkg-config's logic on
automatic library path removal.  In the non-multilib case it generates a
-L[long path] but determines that the path is in the default search path so
can remove it.

Ross

[-- Attachment #2: Type: text/html, Size: 835 bytes --]