[PATCH] gstreamer1.0-plugins-bad: change glimagesink rank to marginal

[PATCH] gstreamer1.0-plugins-bad: change glimagesink rank to marginal

[Alexander Kanavin]

[YOCTO #7787]

Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
---
 .../0001-glimagesink-Downrank-to-marginal.patch    | 32 ++++++++++++++++++++++
 .../gstreamer/gstreamer1.0-plugins-bad_1.4.5.bb    |  4 ++-
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-glimagesink-Downrank-to-marginal.patch

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-glimagesink-Downrank-to-marginal.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-glimagesink-Downrank-to-marginal.patch
new file mode 100644
index 0000000..f677603
--- /dev/null
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-glimagesink-Downrank-to-marginal.patch
@@ -0,0 +1,32 @@
+From c6b37a80806f9128de47f1ccc3f2354f8d436bb6 Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Thu, 24 Sep 2015 19:47:32 +0300
+Subject: [PATCH] glimagesink: Downrank to marginal
+
+On desktop, where there is good OpenGL, xvimagesink will come up first,
+on other platforms, OpenGL can't be trusted because it's either software (like
+in a VM) or broken (like on embedded)., so let ximagesink come above.
+
+Upstream-Status: Submitted [https://bugzilla.gnome.org/show_bug.cgi?id=751684]
+
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+---
+ ext/gl/gstopengl.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/ext/gl/gstopengl.c b/ext/gl/gstopengl.c
+index a4b2540..0ccaacd 100644
+--- a/ext/gl/gstopengl.c
++++ b/ext/gl/gstopengl.c
+@@ -101,7 +101,7 @@ plugin_init (GstPlugin * plugin)
+ #endif
+ 
+   if (!gst_element_register (plugin, "glimagesink",
+-          GST_RANK_SECONDARY, GST_TYPE_GLIMAGE_SINK)) {
++          GST_RANK_MARGINAL, GST_TYPE_GLIMAGE_SINK)) {
+     return FALSE;
+   }
+ 
+-- 
+2.1.4
+
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.4.5.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.4.5.bb
index 59065de..6873669 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.4.5.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.4.5.bb
@@ -5,7 +5,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=73a5855a8119deb017f5f13cf327095d \
                     file://COPYING.LIB;md5=21682e4e8fea52413fd26c60acb907e5 \
                     file://gst/tta/crc32.h;beginline=12;endline=29;md5=27db269c575d1e5317fffca2d33b3b50"
 
-SRC_URI += "file://0001-gl-do-not-check-for-GL-GLU-EGL-GLES2-libs-if-disable.patch"
+SRC_URI += "file://0001-gl-do-not-check-for-GL-GLU-EGL-GLES2-libs-if-disable.patch \
+           file://0001-glimagesink-Downrank-to-marginal.patch \
+           "
 
 SRC_URI[md5sum] = "e0bb39412cf4a48fe0397bcf3a7cd451"
 SRC_URI[sha256sum] = "152fad7250683d72f9deb36c5685428338365fe4a4c87ffe15e38783b14f983c"
-- 
2.1.4

Re: [PATCH] gstreamer1.0-plugins-bad: change glimagesink rank to marginal

[Nicolas Dechesne]

On Thu, Sep 24, 2015 at 10:42 AM, Alexander Kanavin
<alexander.kanavin@linux.intel.com> wrote:
> [YOCTO #7787]
>
> Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
> ---
>  .../0001-glimagesink-Downrank-to-marginal.patch    | 32 ++++++++++++++++++++++
>  .../gstreamer/gstreamer1.0-plugins-bad_1.4.5.bb    |  4 ++-
>  2 files changed, 35 insertions(+), 1 deletion(-)
>  create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-glimagesink-Downrank-to-marginal.patch
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-glimagesink-Downrank-to-marginal.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-glimagesink-Downrank-to-marginal.patch
> new file mode 100644
> index 0000000..f677603
> --- /dev/null
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-glimagesink-Downrank-to-marginal.patch
> @@ -0,0 +1,32 @@
> +From c6b37a80806f9128de47f1ccc3f2354f8d436bb6 Mon Sep 17 00:00:00 2001
> +From: Alexander Kanavin <alex.kanavin@gmail.com>
> +Date: Thu, 24 Sep 2015 19:47:32 +0300
> +Subject: [PATCH] glimagesink: Downrank to marginal
> +
> +On desktop, where there is good OpenGL, xvimagesink will come up first,
> +on other platforms, OpenGL can't be trusted because it's either software (like
> +in a VM) or broken (like on embedded)., so let ximagesink come above.
> +
> +Upstream-Status: Submitted [https://bugzilla.gnome.org/show_bug.cgi?id=751684]


fwiw... on my platforms (QCOM DragonBoard) I rely on glimagesink, and
we have good OpenGL support.. but I understand that this isn't the
norm for ARM, and more an exception.. I can manage that in my BSP
layer, if that ever gets merged. Note we might want to wait for the
upstream discussion to settle before merging.

Re: [PATCH] gstreamer1.0-plugins-bad: change glimagesink rank to marginal

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

On 24 September 2015 at 21:03, Nicolas Dechesne <nicolas.dechesne@linaro.org
> wrote:

> fwiw... on my platforms (QCOM DragonBoard) I rely on glimagesink, and
> we have good OpenGL support.. but I understand that this isn't the
> norm for ARM, and more an exception.. I can manage that in my BSP
> layer, if that ever gets merged. Note we might want to wait for the
> upstream discussion to settle before merging.
>

Does your platform support Xvideo?  If not then glimagesink will likely be
picked anyway.

Ross

[-- Attachment #2: Type: text/html, Size: 947 bytes --]

Re: [PATCH] gstreamer1.0-plugins-bad: change glimagesink rank to marginal

[Nicolas Dechesne]

On Thu, Sep 24, 2015 at 1:19 PM, Burton, Ross <ross.burton@intel.com> wrote:
> Does your platform support Xvideo?  If not then glimagesink will likely be
> picked anyway.

no, it doesn't. i will give this a try, but not before next week.

Re: [PATCH] gstreamer1.0-plugins-bad: change glimagesink rank to marginal

[Alexander Kanavin]

On 09/24/2015 11:03 PM, Nicolas Dechesne wrote:

> fwiw... on my platforms (QCOM DragonBoard) I rely on glimagesink, and
> we have good OpenGL support.. but I understand that this isn't the
> norm for ARM, and more an exception.. I can manage that in my BSP
> layer, if that ever gets merged. Note we might want to wait for the
> upstream discussion to settle before merging.

If you explicitly specify glimagesink in your pipelines, then this patch 
will not affect you. But if you rely on gstreamer's autoplugging, then 
it's entirely coincidental that you're getting the sink you want; 
gstreamer makes no promises about what you end up with. It simply sorts 
sinks by their hardcoded rank, and picks the first one that initializes 
without error.

The upstream discussion has stalled two months ago. Meanwhile we have a 
real problem in qemu images: video playback does not work. If you can 
propose a better fix, you're very much welcome.


Regards,
Alex