[PATCH] gcc-shared-source: Set empty SRC_URI

[PATCH] gcc-shared-source: Set empty SRC_URI

[Richard Purdie]

gcc-source is the only gcc recipe meant to handle the fetch/unpack/patch
tasks, the other gcc recipes then depend on this.

This approach has been creating some confusion for tools like the archiver.
The simplest way to signal to these processes that there is no source
is to empty SRC_URI at the same time we disable the other tasks.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/recipes-devtools/gcc/gcc-shared-source.inc b/meta/recipes-devtools/gcc/gcc-shared-source.inc
index 9acffb1..aac4b49 100644
--- a/meta/recipes-devtools/gcc/gcc-shared-source.inc
+++ b/meta/recipes-devtools/gcc/gcc-shared-source.inc
@@ -5,5 +5,7 @@ do_fetch[noexec] = "1"
 deltask do_unpack
 deltask do_patch
 
+SRC_URI = ""
+
 do_configure[depends] += "gcc-source-${PV}:do_preconfigure"
 do_populate_lic[depends] += "gcc-source-${PV}:do_unpack"

Re: [PATCH] gcc-shared-source: Set empty SRC_URI

[Alexander Kanavin]

On 09/24/2015 12:33 AM, Richard Purdie wrote:
> gcc-source is the only gcc recipe meant to handle the fetch/unpack/patch
> tasks, the other gcc recipes then depend on this.
>
> This approach has been creating some confusion for tools like the archiver.
> The simplest way to signal to these processes that there is no source
> is to empty SRC_URI at the same time we disable the other tasks.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

This has broken the upstream version check for the gcc recipes, which 
was working fine before:

http://packages.yoctoproject.org/


Alex

Re: [PATCH] gcc-shared-source: Set empty SRC_URI

[Alexander Kanavin]

On 09/25/2015 02:03 PM, Alexander Kanavin wrote:

>> gcc-source is the only gcc recipe meant to handle the fetch/unpack/patch
>> tasks, the other gcc recipes then depend on this.
>>
>> This approach has been creating some confusion for tools like the
>> archiver.
>> The simplest way to signal to these processes that there is no source
>> is to empty SRC_URI at the same time we disable the other tasks.
>>
>> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> This has broken the upstream version check for the gcc recipes, which
> was working fine before:
>
> http://packages.yoctoproject.org/

Actually, maybe the problem is not with this patch, but with the 
upstream version checker that defaults to 1.0 when the SRC_URI is empty 
or points to a local file. In that case, it should simply set the 
upstream version to the version of the recipe itself. I'll file a bug.


Alex