Re: [oe] [meta-oe][PATCH v2] meta-oe: recipes-graphics: add libvncserver recipe

Re: [oe] [meta-oe][PATCH v2] meta-oe: recipes-graphics: add libvncserver recipe

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 4146 bytes --]

On Wed, Oct 14, 2015 at 05:06:07PM +0300, Ioan-Adrian Ratiu wrote:
> On 13.10.2015 16:08, Martin Jansa wrote:
> > On Tue, Oct 13, 2015 at 03:40:20PM +0300, Ioan-Adrian Ratiu wrote:
> >> On 13.10.2015 13:53, Martin Jansa wrote:
> >>> On Fri, Oct 09, 2015 at 09:58:07AM +0300, Ioan-Adrian Ratiu wrote:
> >>>> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> >>>> ---
> >>>>    .../libvncserver/libvncserver_0.9.10.bb               | 19 +++++++++++++++++++
> >>>>    1 file changed, 19 insertions(+)
> >>>>    create mode 100644 meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
> >>>>
> >>>> diff --git a/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
> >>>> new file mode 100644
> >>>> index 0000000..afa303c
> >>>> --- /dev/null
> >>>> +++ b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
> >>>> @@ -0,0 +1,19 @@
> >>>> +DESCRIPTION = "library for easy implementation of a RDP/VNC server"
> >
> > Use SUMMARY for such short description.
> >
> >>>> +HOMEPAGE = "https://libvnc.github.io"
> >>>> +SECTION = "libs"
> >>>> +PRIORITY = "optional"
> >
> > Drop PRIORITY, we don't use it anywhere.
> >
> >>>> +LICENSE = "GPLv2"
> >>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=361b6b837cad26c6900a926b62aada5f"
> >>>> +
> >>>> +DEPENDS += "zlib jpeg libpng gtk+ libgcrypt nettle gnutls gmp"
> >>>> +RDEPENDS_${PN} += "libpng gtk+ libgcrypt"
> >>>> +
> >>>> +RCONFLICTS_${PN} = "x11vnc"
> >>>
> >>> This isn't enough to resolve conflicts with x11vnc in sysroot, this only
> >>> prevent installing both packages in the same image.
> >>>
> >>>> +
> >>>> +inherit autotools pkgconfig
> >>>> +
> >>>> +SRC_URI  = "git://github.com/LibVNC/libvncserver.git;tag=LibVNCServer-0.9.10"
> >>>
> >>> Set SRCREV matching with this tag, otherwise bitbake will always use git
> >>> ls-remote to convert tag name to git SHA, which won't work for builds
> >>> from premirror (possibly without access to network)
> >>>
> >>
> >> This is easy to fix, however the above x11vnc conflict is not and I have
> >> to check with upstream developers which might take awhile.
> >>
> >> Is it ok to blacklist libvncserver in patch v3 in order to not break
> >> x11vnc until this is solved?
> >
> > I don't want to introduce more blacklisted recipes in meta-oe, so this
> > won't be merged until it's resolved.
> 
> Quick question: Fixing this involves adding a PACKAGECONFIG dependency 
> inside x11vnc on libvncserver. x11vnc is in the openembedded-core layer.

If such PACKAGECONFIG can be disabled by default, then it's ok.

> Should I move libvncserver to oe-core, move x11vnc in meta-oe or should 
> I just let them reside in separate layers even though there is this 
> dependency?

oe-core (x11vnc) cannot by default depend on meta-oe (libvncserver), it
can be optional dependency, but without looking at the code my guess is
that this won't fix the issue.

Is the PACKAGECONFIG about using external libvncserver instead of
building own version inside x11vnc recipe? If my guess is right, then
oe-core will need to build own and meta-oe will need to remove such
PACKAGECONFIG in order to unblock building separate libvncserver.

If that's the case then moving libvncserver to oe-core or x11vnc to
meta-oe would be easier way forward.

Adding oe-core ML for their opinion.

Regards,
> >
> >>>> +
> >>>> +S = "${WORKDIR}/git"
> >>>> +
> >>>> +EXTRA_OEMAKE_append=" SUBDIRS='libvncserver' "
> >>>> --
> >>>> 2.1.4
> >>>>
> >>>> --
> >>>> _______________________________________________
> >>>> Openembedded-devel mailing list
> >>>> Openembedded-devel@lists.openembedded.org
> >>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >>>
> >>>
> >>>
> >>
> >> --
> >> _______________________________________________
> >> Openembedded-devel mailing list
> >> Openembedded-devel@lists.openembedded.org
> >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> >
> >
> >
> 

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [oe] [meta-oe][PATCH v2] meta-oe: recipes-graphics: add libvncserver recipe

[Ioan-Adrian Ratiu]

On 14.10.2015 17:16, Martin Jansa wrote:
> On Wed, Oct 14, 2015 at 05:06:07PM +0300, Ioan-Adrian Ratiu wrote:
>> On 13.10.2015 16:08, Martin Jansa wrote:
>>> On Tue, Oct 13, 2015 at 03:40:20PM +0300, Ioan-Adrian Ratiu wrote:
>>>> On 13.10.2015 13:53, Martin Jansa wrote:
>>>>> On Fri, Oct 09, 2015 at 09:58:07AM +0300, Ioan-Adrian Ratiu wrote:
>>>>>> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
>>>>>> ---
>>>>>>     .../libvncserver/libvncserver_0.9.10.bb               | 19 +++++++++++++++++++
>>>>>>     1 file changed, 19 insertions(+)
>>>>>>     create mode 100644 meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
>>>>>>
>>>>>> diff --git a/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
>>>>>> new file mode 100644
>>>>>> index 0000000..afa303c
>>>>>> --- /dev/null
>>>>>> +++ b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
>>>>>> @@ -0,0 +1,19 @@
>>>>>> +DESCRIPTION = "library for easy implementation of a RDP/VNC server"
>>>
>>> Use SUMMARY for such short description.
>>>
>>>>>> +HOMEPAGE = "https://libvnc.github.io"
>>>>>> +SECTION = "libs"
>>>>>> +PRIORITY = "optional"
>>>
>>> Drop PRIORITY, we don't use it anywhere.
>>>
>>>>>> +LICENSE = "GPLv2"
>>>>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=361b6b837cad26c6900a926b62aada5f"
>>>>>> +
>>>>>> +DEPENDS += "zlib jpeg libpng gtk+ libgcrypt nettle gnutls gmp"
>>>>>> +RDEPENDS_${PN} += "libpng gtk+ libgcrypt"
>>>>>> +
>>>>>> +RCONFLICTS_${PN} = "x11vnc"
>>>>>
>>>>> This isn't enough to resolve conflicts with x11vnc in sysroot, this only
>>>>> prevent installing both packages in the same image.
>>>>>
>>>>>> +
>>>>>> +inherit autotools pkgconfig
>>>>>> +
>>>>>> +SRC_URI  = "git://github.com/LibVNC/libvncserver.git;tag=LibVNCServer-0.9.10"
>>>>>
>>>>> Set SRCREV matching with this tag, otherwise bitbake will always use git
>>>>> ls-remote to convert tag name to git SHA, which won't work for builds
>>>>> from premirror (possibly without access to network)
>>>>>
>>>>
>>>> This is easy to fix, however the above x11vnc conflict is not and I have
>>>> to check with upstream developers which might take awhile.
>>>>
>>>> Is it ok to blacklist libvncserver in patch v3 in order to not break
>>>> x11vnc until this is solved?
>>>
>>> I don't want to introduce more blacklisted recipes in meta-oe, so this
>>> won't be merged until it's resolved.
>>
>> Quick question: Fixing this involves adding a PACKAGECONFIG dependency
>> inside x11vnc on libvncserver. x11vnc is in the openembedded-core layer.
>
> If such PACKAGECONFIG can be disabled by default, then it's ok.
>
>> Should I move libvncserver to oe-core, move x11vnc in meta-oe or should
>> I just let them reside in separate layers even though there is this
>> dependency?
>
> oe-core (x11vnc) cannot by default depend on meta-oe (libvncserver), it
> can be optional dependency, but without looking at the code my guess is
> that this won't fix the issue.
>
> Is the PACKAGECONFIG about using external libvncserver instead of
> building own version inside x11vnc recipe? If my guess is right, then
> oe-core will need to build own and meta-oe will need to remove such
> PACKAGECONFIG in order to unblock building separate libvncserver.
>
> If that's the case then moving libvncserver to oe-core or x11vnc to
> meta-oe would be easier way forward.

Yes, this is correct (x11vnc's configured --with-system-libvncserver)

>
> Adding oe-core ML for their opinion.
>
> Regards,
>>>
>>>>>> +
>>>>>> +S = "${WORKDIR}/git"
>>>>>> +
>>>>>> +EXTRA_OEMAKE_append=" SUBDIRS='libvncserver' "
>>>>>> --
>>>>>> 2.1.4
>>>>>>
>>>>>> --
>>>>>> _______________________________________________
>>>>>> Openembedded-devel mailing list
>>>>>> Openembedded-devel@lists.openembedded.org
>>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>>>
>>>>>
>>>>>
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>>
>>>
>>
>

Re: [oe] [meta-oe][PATCH v2] meta-oe: recipes-graphics: add libvncserver recipe

[Paul Eggleton]

On Wednesday 14 October 2015 17:33:23 Ioan-Adrian Ratiu wrote:
> On 14.10.2015 17:16, Martin Jansa wrote:
> > On Wed, Oct 14, 2015 at 05:06:07PM +0300, Ioan-Adrian Ratiu wrote:
> >> On 13.10.2015 16:08, Martin Jansa wrote:
> >>> On Tue, Oct 13, 2015 at 03:40:20PM +0300, Ioan-Adrian Ratiu wrote:
> >>>> On 13.10.2015 13:53, Martin Jansa wrote:
> >>>>> On Fri, Oct 09, 2015 at 09:58:07AM +0300, Ioan-Adrian Ratiu wrote:
> >>>>>> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> >>>>>> ---
> >>>>>> 
> >>>>>>     .../libvncserver/libvncserver_0.9.10.bb               | 19
> >>>>>>     +++++++++++++++++++ 1 file changed, 19 insertions(+)
> >>>>>>     create mode 100644
> >>>>>>     meta-oe/recipes-
graphics/libvncserver/libvncserver_0.9.10.bb>>>>>> 
> >>>>>> diff --git
> >>>>>> a/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
> >>>>>> b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb new
> >>>>>> file mode 100644
> >>>>>> index 0000000..afa303c
> >>>>>> --- /dev/null
> >>>>>> +++ b/meta-oe/recipes-graphics/libvncserver/libvncserver_0.9.10.bb
> >>>>>> @@ -0,0 +1,19 @@
> >>>>>> +DESCRIPTION = "library for easy implementation of a RDP/VNC server"
> >>> 
> >>> Use SUMMARY for such short description.
> >>> 
> >>>>>> +HOMEPAGE = "https://libvnc.github.io"
> >>>>>> +SECTION = "libs"
> >>>>>> +PRIORITY = "optional"
> >>> 
> >>> Drop PRIORITY, we don't use it anywhere.
> >>> 
> >>>>>> +LICENSE = "GPLv2"
> >>>>>> +LIC_FILES_CHKSUM =
> >>>>>> "file://COPYING;md5=361b6b837cad26c6900a926b62aada5f"
> >>>>>> +
> >>>>>> +DEPENDS += "zlib jpeg libpng gtk+ libgcrypt nettle gnutls gmp"
> >>>>>> +RDEPENDS_${PN} += "libpng gtk+ libgcrypt"
> >>>>>> +
> >>>>>> +RCONFLICTS_${PN} = "x11vnc"
> >>>>> 
> >>>>> This isn't enough to resolve conflicts with x11vnc in sysroot, this
> >>>>> only
> >>>>> prevent installing both packages in the same image.
> >>>>> 
> >>>>>> +
> >>>>>> +inherit autotools pkgconfig
> >>>>>> +
> >>>>>> +SRC_URI  =
> >>>>>> 
"git://github.com/LibVNC/libvncserver.git;tag=LibVNCServer-0.9.10">>>>> 
> >>>>> Set SRCREV matching with this tag, otherwise bitbake will always use
> >>>>> git
> >>>>> ls-remote to convert tag name to git SHA, which won't work for builds
> >>>>> from premirror (possibly without access to network)
> >>>> 
> >>>> This is easy to fix, however the above x11vnc conflict is not and I
> >>>> have
> >>>> to check with upstream developers which might take awhile.
> >>>> 
> >>>> Is it ok to blacklist libvncserver in patch v3 in order to not break
> >>>> x11vnc until this is solved?
> >>> 
> >>> I don't want to introduce more blacklisted recipes in meta-oe, so this
> >>> won't be merged until it's resolved.
> >> 
> >> Quick question: Fixing this involves adding a PACKAGECONFIG dependency
> >> inside x11vnc on libvncserver. x11vnc is in the openembedded-core layer.
> > 
> > If such PACKAGECONFIG can be disabled by default, then it's ok.
> > 
> >> Should I move libvncserver to oe-core, move x11vnc in meta-oe or should
> >> I just let them reside in separate layers even though there is this
> >> dependency?
> > 
> > oe-core (x11vnc) cannot by default depend on meta-oe (libvncserver), it
> > can be optional dependency, but without looking at the code my guess is
> > that this won't fix the issue.
> > 
> > Is the PACKAGECONFIG about using external libvncserver instead of
> > building own version inside x11vnc recipe? If my guess is right, then
> > oe-core will need to build own and meta-oe will need to remove such
> > PACKAGECONFIG in order to unblock building separate libvncserver.
> > 
> > If that's the case then moving libvncserver to oe-core or x11vnc to
> > meta-oe would be easier way forward.
> 
> Yes, this is correct (x11vnc's configured --with-system-libvncserver)

FWIW assuming it works and isn't specially patched, I think for x11vnc we'd 
probably be better off using an external lib we can keep up-to-date rather than 
a bundled one that might be out-of-date; that is to say, if we are to keep 
x11vnc in OE-Core then we might as well also have libvncserver. (One might 
possibly ask if we really need x11vnc there though, I don't have an answer to 
that).

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [oe] [meta-oe][PATCH v2] meta-oe: recipes-graphics: add libvncserver recipe

[Otavio Salvador]

On Wed, Oct 14, 2015 at 11:41 AM, Paul Eggleton
<paul.eggleton@linux.intel.com> wrote:
> FWIW assuming it works and isn't specially patched, I think for x11vnc we'd
> probably be better off using an external lib we can keep up-to-date rather than
> a bundled one that might be out-of-date; that is to say, if we are to keep
> x11vnc in OE-Core then we might as well also have libvncserver. (One might
> possibly ask if we really need x11vnc there though, I don't have an answer to
> that).

I think x11vnc could go to meta-oe. It does not seem to be widely used
and a core component.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750