[PATCH] cmake.bbclass: remove ${prefix} assignment

[PATCH] cmake.bbclass: remove ${prefix} assignment

[Kevron Rees]

CMAKE_INSTALL_PREFIX has a different semantic meaning than ${prefix}[1].  cmake treats
CMAKE_INSTALL_PREFIX the same as the DESTDIR environment variable.  Setting
CMAKE_INSTALL_PREFIX to ${prefix} is inappropriate.

This will likely break a lot of cmake recipes that have do_post_install hacks to get
around this bug.

[1] - https://cmake.org/cmake/help/v3.0/variable/CMAKE_INSTALL_PREFIX.html

Signed-off-by: Kevron Rees <kevron.m.rees@intel.com>
---
 meta/classes/cmake.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
index ae3cc02..b7d5950 100644
--- a/meta/classes/cmake.bbclass
+++ b/meta/classes/cmake.bbclass
@@ -108,7 +108,7 @@ cmake_do_configure() {
 	cmake \
 	  ${OECMAKE_SITEFILE} \
 	  ${OECMAKE_SOURCEPATH} \
-	  -DCMAKE_INSTALL_PREFIX:PATH=${prefix} \
+	  -DCMAKE_INSTALL_PREFIX:PATH="" \
 	  -DCMAKE_INSTALL_BINDIR:PATH=${bindir} \
 	  -DCMAKE_INSTALL_SBINDIR:PATH=${sbindir} \
 	  -DCMAKE_INSTALL_LIBEXECDIR:PATH=${libexecdir} \
-- 
2.1.4

Re: [PATCH] cmake.bbclass: remove ${prefix} assignment

[Stefan Herbrechtsmeier]

Am 14.11.2015 um 02:24 schrieb Kevron Rees:
> CMAKE_INSTALL_PREFIX has a different semantic meaning than ${prefix}[1].  cmake treats
> CMAKE_INSTALL_PREFIX the same as the DESTDIR environment variable.
CMAKE_INSTALL_PREFIX and DESTDIR are different and used together [1]:
[...] install the concerned software using the installation prefix [...] 
prepended with the DESTDIR [...]
>    Setting
> CMAKE_INSTALL_PREFIX to ${prefix} is inappropriate.
Why? It configures the prefix.
${prefix} is set to "/usr" in bitbake.conf. The default 
CMAKE_INSTALL_PREFIX is "/usr/local"

> This will likely break a lot of cmake recipes that have do_post_install hacks to get
> around this bug.
What hacks do you mean?

> [1] - https://cmake.org/cmake/help/v3.0/variable/CMAKE_INSTALL_PREFIX.html
>
> Signed-off-by: Kevron Rees <kevron.m.rees@intel.com>
> ---
>   meta/classes/cmake.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/cmake.bbclass b/meta/classes/cmake.bbclass
> index ae3cc02..b7d5950 100644
> --- a/meta/classes/cmake.bbclass
> +++ b/meta/classes/cmake.bbclass
> @@ -108,7 +108,7 @@ cmake_do_configure() {
>   	cmake \
>   	  ${OECMAKE_SITEFILE} \
>   	  ${OECMAKE_SOURCEPATH} \
> -	  -DCMAKE_INSTALL_PREFIX:PATH=${prefix} \
> +	  -DCMAKE_INSTALL_PREFIX:PATH="" \
>   	  -DCMAKE_INSTALL_BINDIR:PATH=${bindir} \
>   	  -DCMAKE_INSTALL_SBINDIR:PATH=${sbindir} \
>   	  -DCMAKE_INSTALL_LIBEXECDIR:PATH=${libexecdir} \