[PATCH 0/1] logrotate: do not move binary logrotate to /usr/bin

[PATCH 0/1] logrotate: do not move binary logrotate to /usr/bin

[Hongxu Jia]

The following changes since commit 370a2916c4559c17952392b872322e8e490b124c:

  build-appliance-image: Update to jethro head revision (2015-10-29 22:20:40 +0000)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib hongxu/logrotate
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=hongxu/logrotate

Hongxu Jia (1):
  logrotate: do not move binary logrotate to /usr/bin

 meta/recipes-extended/logrotate/logrotate_3.9.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/1] logrotate: do not move binary logrotate to /usr/bin

[Hongxu Jia]

In oe-core commit a46d3646a3e1781be4423b508ea63996b3cfca8a
...
Author: Fahad Usman <fahad_usman@mentor.com>
Date:   Tue Aug 26 13:16:48 2014 +0500

    logrotate: obey our flags

    Needed to quiet GNU_HASH warnings, and some minor fixes.
...
it explicitly move logrotate to /usr/bin without any reason,
which is against the original Linux location /usr/sbin.

So partly revert the above commit which let logrotate be
kept in the original place /usr/sbin.

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 meta/recipes-extended/logrotate/logrotate_3.9.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
index 7d0a159..5f1a601 100644
--- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
+++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
@@ -53,7 +53,7 @@ do_compile_prepend() {
 }
 
 do_install(){
-    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir} BINDIR=${bindir}
+    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
     mkdir -p ${D}${sysconfdir}/logrotate.d
     mkdir -p ${D}${sysconfdir}/cron.daily
     mkdir -p ${D}${localstatedir}/lib
-- 
1.9.1

Re: [PATCH 1/1] logrotate: do not move binary logrotate to /usr/bin

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 1690 bytes --]

On Mon, Nov 2, 2015 at 1:33 AM, Hongxu Jia <hongxu.jia@windriver.com> wrote:

> In oe-core commit a46d3646a3e1781be4423b508ea63996b3cfca8a
> ...
> Author: Fahad Usman <fahad_usman@mentor.com>
> Date:   Tue Aug 26 13:16:48 2014 +0500
>
>     logrotate: obey our flags
>
>     Needed to quiet GNU_HASH warnings, and some minor fixes.
> ...
> it explicitly move logrotate to /usr/bin without any reason,
> which is against the original Linux location /usr/sbin.
>
> So partly revert the above commit which let logrotate be
> kept in the original place /usr/sbin.
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  meta/recipes-extended/logrotate/logrotate_3.9.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> index 7d0a159..5f1a601 100644
> --- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> +++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
> @@ -53,7 +53,7 @@ do_compile_prepend() {
>  }
>
>  do_install(){
> -    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
> BINDIR=${bindir}
> +    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
>      mkdir -p ${D}${sysconfdir}/logrotate.d
>      mkdir -p ${D}${sysconfdir}/cron.daily
>      mkdir -p ${D}${localstatedir}/lib
>

This just makes it not obey our target paths again, using its hardcoded
destination. Why not pass BINDIR=${sbindir} instead?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 2874 bytes --]

Re: [PATCH 1/1] logrotate: do not move binary logrotate to /usr/bin

[Hongxu Jia]

[-- Attachment #1: Type: text/plain, Size: 2208 bytes --]

On 11/17/2015 12:32 AM, Christopher Larson wrote:
>
> On Mon, Nov 2, 2015 at 1:33 AM, Hongxu Jia <hongxu.jia@windriver.com 
> <mailto:hongxu.jia@windriver.com>> wrote:
>
>     In oe-core commit a46d3646a3e1781be4423b508ea63996b3cfca8a
>     ...
>     Author: Fahad Usman <fahad_usman@mentor.com
>     <mailto:fahad_usman@mentor.com>>
>     Date:   Tue Aug 26 13:16:48 2014 +0500
>
>     logrotate: obey our flags
>
>         Needed to quiet GNU_HASH warnings, and some minor fixes.
>     ...
>     it explicitly move logrotate to /usr/bin without any reason,
>     which is against the original Linux location /usr/sbin.
>
>     So partly revert the above commit which let logrotate be
>     kept in the original place /usr/sbin.
>
>     Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com
>     <mailto:hongxu.jia@windriver.com>>
>     ---
>      meta/recipes-extended/logrotate/logrotate_3.9.1.bb
>     <http://logrotate_3.9.1.bb> | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
>     <http://logrotate_3.9.1.bb>
>     b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
>     <http://logrotate_3.9.1.bb>
>     index 7d0a159..5f1a601 100644
>     --- a/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
>     <http://logrotate_3.9.1.bb>
>     +++ b/meta/recipes-extended/logrotate/logrotate_3.9.1.bb
>     <http://logrotate_3.9.1.bb>
>     @@ -53,7 +53,7 @@ do_compile_prepend() {
>      }
>
>      do_install(){
>     -    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
>     BINDIR=${bindir}
>     +    oe_runmake install DESTDIR=${D} PREFIX=${D} MANDIR=${mandir}
>          mkdir -p ${D}${sysconfdir}/logrotate.d
>          mkdir -p ${D}${sysconfdir}/cron.daily
>          mkdir -p ${D}${localstatedir}/lib
>
>
> This just makes it not obey our target paths again, using its 
> hardcoded destination. Why not pass BINDIR=${sbindir} instead?

It is fine to me

//Hongxu


> -- 
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics


[-- Attachment #2: Type: text/html, Size: 5084 bytes --]