[PATCH] pseudo: Make it possible to override the append in a bbappend

[PATCH] pseudo: Make it possible to override the append in a bbappend

[Fabrice Coulon]

I need this in order to avoid a conflict when used with
base-passwd-native.

Signed-off-by: Fabrice Coulon <fabrice.coulon@axis.com>
---
 meta/recipes-devtools/pseudo/pseudo_1.7.4.bb | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/pseudo/pseudo_1.7.4.bb b/meta/recipes-devtools/pseudo/pseudo_1.7.4.bb
index d68e0af..87e624e 100644
--- a/meta/recipes-devtools/pseudo/pseudo_1.7.4.bb
+++ b/meta/recipes-devtools/pseudo/pseudo_1.7.4.bb
@@ -11,9 +11,13 @@ SRC_URI[sha256sum] = "f33ff84da328f943155f22cfd49030ef4ad85ad35fc2d9419a203521b6
 
 PSEUDO_EXTRA_OPTS ?= "--enable-force-async --without-passwd-fallback"
 
-do_install_append_class-native () {
+append_class_native() {
 	install -d ${D}${sysconfdir}
 	# The fallback files should never be modified
 	install -m 444 ${WORKDIR}/fallback-passwd ${D}${sysconfdir}/passwd
 	install -m 444 ${WORKDIR}/fallback-group ${D}${sysconfdir}/group
 }
+
+do_install_append_class-native () {
+	append_class_native
+}
-- 
1.9.1

Re: [PATCH] pseudo: Make it possible to override the append in a bbappend

[Andre McCurdy]

On Wed, Dec 2, 2015 at 5:22 AM, Fabrice Coulon <fabrice.coulon@axis.com> wrote:
> I need this in order to avoid a conflict when used with
> base-passwd-native.

Doesn't something like this work from your .bbappend?

  do_install_append_class-native () {
      # Remove to avoid conflict with base-passwd-native
      rm -f ${D}${sysconfdir}/passwd ${D}${sysconfdir}/group
  }


> Signed-off-by: Fabrice Coulon <fabrice.coulon@axis.com>
> ---
>  meta/recipes-devtools/pseudo/pseudo_1.7.4.bb | 6 +++++-

You left out the pseudo_1.6.7.bb recipe. Better to keep the two recipes in sync.

>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/pseudo/pseudo_1.7.4.bb b/meta/recipes-devtools/pseudo/pseudo_1.7.4.bb
> index d68e0af..87e624e 100644
> --- a/meta/recipes-devtools/pseudo/pseudo_1.7.4.bb
> +++ b/meta/recipes-devtools/pseudo/pseudo_1.7.4.bb
> @@ -11,9 +11,13 @@ SRC_URI[sha256sum] = "f33ff84da328f943155f22cfd49030ef4ad85ad35fc2d9419a203521b6
>
>  PSEUDO_EXTRA_OPTS ?= "--enable-force-async --without-passwd-fallback"
>
> -do_install_append_class-native () {
> +append_class_native() {

It might avoid confusion if the function name wasn't made up of a
bitbake keyword and (something very close to) the class-native
over-ride. Maybe "install_passwd_fallbacks", to described what the
function actually does?

>         install -d ${D}${sysconfdir}
>         # The fallback files should never be modified
>         install -m 444 ${WORKDIR}/fallback-passwd ${D}${sysconfdir}/passwd
>         install -m 444 ${WORKDIR}/fallback-group ${D}${sysconfdir}/group
>  }
> +
> +do_install_append_class-native () {
> +       append_class_native
> +}
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] pseudo: Make it possible to override the append in a bbappend

[Fabrice Coulon]

On 12/02/2015 08:05 PM, Andre McCurdy wrote:
> On Wed, Dec 2, 2015 at 5:22 AM, Fabrice Coulon <fabrice.coulon@axis.com> wrote:
>> I need this in order to avoid a conflict when used with
>> base-passwd-native.
> Doesn't something like this work from your .bbappend?
>
>    do_install_append_class-native () {
>        # Remove to avoid conflict with base-passwd-native
>        rm -f ${D}${sysconfdir}/passwd ${D}${sysconfdir}/group
>    }
>

Yes it works. I don't need to change the recipe, it's enough with this 
in a bbappend. Thanks!