From: Trevor Woerner <twoerner@gmail.com>
To: Robert Yang <liezhi.yang@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] glibc-initial.inc: use relative path to run configure
Date: Mon, 11 Jan 2016 09:55:01 -0500 [thread overview]
Message-ID: <5693C245.7060304@gmail.com> (raw)
In-Reply-To: <4f5f10ebe2593fb40fbb637978480d87d9697f40.1452489034.git.liezhi.yang@windriver.com>
On 01/11/16 00:11, Robert Yang wrote:
> Avoid potential build path in output files.
>
> [YOCTO #8894]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/recipes-core/glibc/glibc-initial.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/glibc/glibc-initial.inc b/meta/recipes-core/glibc/glibc-initial.inc
> index 8e81f09..cb2f8dd 100644
> --- a/meta/recipes-core/glibc/glibc-initial.inc
> +++ b/meta/recipes-core/glibc/glibc-initial.inc
> @@ -11,7 +11,7 @@ TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_TCBOOTSTRAP}"
> do_configure () {
> (cd ${S} && gnu-configize) || die "failure in running gnu-configize"
> find ${S} -name "configure" | xargs touch
> - ${S}/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \
> + ../git/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \
Although I haven't tested it, this _looks_ like it might fail quite
readily. I'm sure there are some recipes that play tricks with ${S}, and
what about recipes that don't pull their sources from git?
Maybe something like: (cd ${S} && ./configure ...) would be better?
> --prefix=/usr \
> --without-cvs --disable-sanity-checks \
> --with-headers=${STAGING_DIR_TARGET}${includedir} \
next prev parent reply other threads:[~2016-01-11 14:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 5:11 [PATCH 0/2] autotools.bbclass: use relative path to run configure script Robert Yang
2016-01-11 5:11 ` [PATCH 1/2] glibc-initial.inc: use relative path to run configure Robert Yang
2016-01-11 14:55 ` Trevor Woerner [this message]
2016-01-11 15:06 ` Mark Hatle
2016-01-11 16:18 ` Christopher Larson
2016-01-11 16:25 ` Mark Hatle
2016-01-11 5:11 ` [PATCH 2/2] autotools.bbclass: use relative path to run configure script Robert Yang
2016-01-12 2:04 ` [PATCH 0/2] " Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693C245.7060304@gmail.com \
--to=twoerner@gmail.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox