From: Mark Hatle <mark.hatle@windriver.com>
To: Trevor Woerner <twoerner@gmail.com>,
Robert Yang <liezhi.yang@windriver.com>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] glibc-initial.inc: use relative path to run configure
Date: Mon, 11 Jan 2016 09:06:22 -0600 [thread overview]
Message-ID: <5693C4EE.4040507@windriver.com> (raw)
In-Reply-To: <5693C245.7060304@gmail.com>
On 1/11/16 8:55 AM, Trevor Woerner wrote:
>
>
> On 01/11/16 00:11, Robert Yang wrote:
>> Avoid potential build path in output files.
>>
>> [YOCTO #8894]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>> meta/recipes-core/glibc/glibc-initial.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/glibc/glibc-initial.inc b/meta/recipes-core/glibc/glibc-initial.inc
>> index 8e81f09..cb2f8dd 100644
>> --- a/meta/recipes-core/glibc/glibc-initial.inc
>> +++ b/meta/recipes-core/glibc/glibc-initial.inc
>> @@ -11,7 +11,7 @@ TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_TCBOOTSTRAP}"
>> do_configure () {
>> (cd ${S} && gnu-configize) || die "failure in running gnu-configize"
>> find ${S} -name "configure" | xargs touch
>> - ${S}/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \
>> + ../git/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \
>
> Although I haven't tested it, this _looks_ like it might fail quite
> readily. I'm sure there are some recipes that play tricks with ${S}, and
> what about recipes that don't pull their sources from git?
>
> Maybe something like: (cd ${S} && ./configure ...) would be better?
That won't work since it'll run configure in the S directory.
IF we need to use relative paths here, we need to calculate the relative path
from B to S and use that. It looks like patch 2/2 already does something like
this using the python.. we can probably do the same. (I don't know any reason,
at least for glibc, that all of the items won't be in the same "WORKDIR". So it
would be relative within the WORKDIR, which SHOULD be fine.)
>> --prefix=/usr \
>> --without-cvs --disable-sanity-checks \
>> --with-headers=${STAGING_DIR_TARGET}${includedir} \
>
next prev parent reply other threads:[~2016-01-11 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 5:11 [PATCH 0/2] autotools.bbclass: use relative path to run configure script Robert Yang
2016-01-11 5:11 ` [PATCH 1/2] glibc-initial.inc: use relative path to run configure Robert Yang
2016-01-11 14:55 ` Trevor Woerner
2016-01-11 15:06 ` Mark Hatle [this message]
2016-01-11 16:18 ` Christopher Larson
2016-01-11 16:25 ` Mark Hatle
2016-01-11 5:11 ` [PATCH 2/2] autotools.bbclass: use relative path to run configure script Robert Yang
2016-01-12 2:04 ` [PATCH 0/2] " Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5693C4EE.4040507@windriver.com \
--to=mark.hatle@windriver.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox