[PATCH 1/2] cantarell-fonts: Add recipe

[PATCH 1/2] cantarell-fonts: Add recipe

[Jagadeesh Krishnanjanappa]

1. The Cantarell font typeface is designed as a
   contemporary Humanist sans serif, and was developed for 
   on-screen reading; in particular, reading web pages on an
   HTC Dream mobile phone.

2. Pango test case (test-layout.test) requires cantarell-font
   typeface. This test case uses 'Cantarell 11' font type

Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
---
 .../cantarell-fonts/cantarell-fonts_git.bb         | 25 ++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb

diff --git a/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
new file mode 100644
index 0000000..f55fef1
--- /dev/null
+++ b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
@@ -0,0 +1,25 @@
+SUMMARY = "Cantarell, a Humanist sans-serif font family"
+
+DESCRIPTION = "The Cantarell font typeface is designed as a \
+               contemporary Humanist sans serif, and was developed for \
+               on-screen reading; in particular, reading web pages on an \
+               HTC Dream mobile phone."
+
+HOMEPAGE = "https://git.gnome.org/browse/cantarell-fonts/"
+SECTION = "fonts"
+LICENSE = "OFL-1.1"
+LIC_FILES_CHKSUM = "file://COPYING;md5=df91e3ffcab8cfb972a66bf11255188d"
+
+PV = "0.0.18.1+git${SRCPV}"
+PR = "r0"
+
+SRCREV = "3e954528d06de1c7e5ba8ebf8b0cca9c68faa0c4"
+SRC_URI = "git://git.gnome.org/cantarell-fonts;protocol=git;branch=master"
+
+S = "${WORKDIR}/git"
+
+inherit autotools allarch fontcache
+
+PACKAGECONFIG ??= ""
+PACKAGECONFIG[fontforge] = "--enable-source-rebuild=yes,--enable-source-rebuild=no,fontforge-native"
+FILES_${PN} = "${datadir}/fonts ${datadir}/fontconfig"
-- 
1.9.1

[PATCH 2/2] pango: make ${PN}-ptest RDEPENDS on cantarell-fonts

[Jagadeesh Krishnanjanappa]

Pango test case (test-layout.test) requires cantarell-font
typeface. This test case uses 'Cantarell 11' font type.

Test result after this change on qemux86:
-- snip --
root@qemux86:/usr/lib/pango/ptest# ./run-ptest
Running test: pango/testboundaries_ucd.test
/text/break/grapheme: Testing
/usr/lib/pango/installed-tests/pango/GraphemeBreakTest.txt.
OK
/text/break/word: /usr/lib/pango/installed-tests/pango/WordBreakTest.txt not
found.  Skipping test.
OK
/text/break/sentence: /usr/lib/pango/installed-tests/pango/SentenceBreakTest.txt
not found.  Skipping test.
OK
/text/break/line: /usr/lib/pango/installed-tests/pango/LineBreakTest.txt not
found.  Skipping test.
OK
PASS: pango/testboundaries_ucd.test
Running test: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test

Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
Executing: pango/test-pangocairo-threads.test
PASS: pango/test-pangocairo-threads.test
Running test: pango/test-layout.test
/layout/valid-2.markup: OK
/layout/valid-1.markup: OK
PASS: pango/test-layout.test
Running test: pango/markup-parse.test
/markup/parse/fail-1.markup: OK
/markup/parse/valid-3.markup: OK
/markup/parse/valid-2.markup: OK
/markup/parse/valid-1.markup: OK
/markup/parse/valid-4.markup: OK
PASS: pango/markup-parse.test
Running test: pango/test-ot-tags.test
/tags/script: OK
/tags/language: OK
PASS: pango/test-ot-tags.test
Running test: pango/testiter.test
/layout/iter: OK
/layout/glyphitem-iter: OK
PASS: pango/testiter.test
Running test: pango/testcolor.test
/color/parse: OK
PASS: pango/testcolor.test
Running test: pango/cxx-test.test
PASS: pango/cxx-test.test
Running test: pango/testboundaries.test
/text/boundaries: sample file:
/usr/lib/pango/installed-tests/pango/boundaries.utf8
testboundaries passed
OK
PASS: pango/testboundaries.test
Running test: pango/testscript.test
/script/iter: OK
PASS: pango/testscript.test
Running test: pango/testattributes.test
/attributes/basic: OK
/attributes/equal: OK
/attributes/list/basic: OK
/attributes/list/change: OK
/attributes/list/splice: OK
/attributes/list/filter: OK
/attributes/iter/basic: OK
/attributes/iter/get: OK
/attributes/iter/get_font: OK
/attributes/iter/get_attrs: OK
PASS: pango/testattributes.test
Running test: pango/test-font.test
/pango/fontdescription/parse: OK
/pango/fontdescription/roundtrip: OK
PASS: pango/test-font.test
SUMMARY: total=12; passed=12; skipped=0; failed=0; user=74.9s; system=1.9s;
maxrss=52356
root@qemux86:/usr/lib/pango/ptest#
-- CUT --

Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
---
 meta/recipes-graphics/pango/pango.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-graphics/pango/pango.inc b/meta/recipes-graphics/pango/pango.inc
index 3e9c068..a2a92fe 100644
--- a/meta/recipes-graphics/pango/pango.inc
+++ b/meta/recipes-graphics/pango/pango.inc
@@ -42,7 +42,7 @@ do_compile_prepend () {
 FILES_${PN} = "${bindir}/* ${libdir}/libpango*${SOLIBS}"
 FILES_${PN}-dev += "${libdir}/pango/${LIBV}/modules/*.la"
 
-RDEPENDS_${PN}-ptest += "liberation-fonts"
+RDEPENDS_${PN}-ptest += "liberation-fonts cantarell-fonts"
 
 RPROVIDES_${PN} += "pango-modules pango-module-indic-lang \
                     pango-module-basic-fc pango-module-arabic-lang"
-- 
1.9.1

Re: [PATCH 1/2] cantarell-fonts: Add recipe

[Jagadeesh Krishnanjanappa]

[-- Attachment #1: Type: text/plain, Size: 2271 bytes --]

Ping.

Without cantarell fonts, the pango test case  test-layout.test fails.
Previous result of pango ptest is at
https://wiki.yoctoproject.org/wiki/Ptest_5e3e2e0cbb0a49986f4653e64c4c8d2b5461645e

Regards,
Jagadeesh

On Sat, Jan 9, 2016 at 8:02 PM, Jagadeesh Krishnanjanappa <
jkrishnanjanappa@mvista.com> wrote:

> 1. The Cantarell font typeface is designed as a
>    contemporary Humanist sans serif, and was developed for
>    on-screen reading; in particular, reading web pages on an
>    HTC Dream mobile phone.
>
> 2. Pango test case (test-layout.test) requires cantarell-font
>    typeface. This test case uses 'Cantarell 11' font type
>
> Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
> ---
>  .../cantarell-fonts/cantarell-fonts_git.bb         | 25
> ++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 meta/recipes-graphics/cantarell-fonts/
> cantarell-fonts_git.bb
>
> diff --git a/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
> b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
> new file mode 100644
> index 0000000..f55fef1
> --- /dev/null
> +++ b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
> @@ -0,0 +1,25 @@
> +SUMMARY = "Cantarell, a Humanist sans-serif font family"
> +
> +DESCRIPTION = "The Cantarell font typeface is designed as a \
> +               contemporary Humanist sans serif, and was developed for \
> +               on-screen reading; in particular, reading web pages on an \
> +               HTC Dream mobile phone."
> +
> +HOMEPAGE = "https://git.gnome.org/browse/cantarell-fonts/"
> +SECTION = "fonts"
> +LICENSE = "OFL-1.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=df91e3ffcab8cfb972a66bf11255188d"
> +
> +PV = "0.0.18.1+git${SRCPV}"
> +PR = "r0"
> +
> +SRCREV = "3e954528d06de1c7e5ba8ebf8b0cca9c68faa0c4"
> +SRC_URI = "git://git.gnome.org/cantarell-fonts;protocol=git;branch=master
> "
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools allarch fontcache
> +
> +PACKAGECONFIG ??= ""
> +PACKAGECONFIG[fontforge] =
> "--enable-source-rebuild=yes,--enable-source-rebuild=no,fontforge-native"
> +FILES_${PN} = "${datadir}/fonts ${datadir}/fontconfig"
> --
> 1.9.1
>
>

[-- Attachment #2: Type: text/html, Size: 3871 bytes --]

Re: [PATCH 1/2] cantarell-fonts: Add recipe

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 2874 bytes --]

On 13 January 2016 at 19:36, Jagadeesh Krishnanjanappa <
jkrishnanjanappa@mvista.com> wrote:

> Ping.
>
> Without cantarell fonts, the pango test case  test-layout.test fails.
> Previous result of pango ptest is at
>
> https://wiki.yoctoproject.org/wiki/Ptest_5e3e2e0cbb0a49986f4653e64c4c8d2b5461645e
>
>
Normally I'm all for more test coverage but I'll point out that this is a
18M source repo for a single test... Sure, the download and target sizes
are a fraction of that but they still count.

Jussi



> Regards,
> Jagadeesh
>
> On Sat, Jan 9, 2016 at 8:02 PM, Jagadeesh Krishnanjanappa <
> jkrishnanjanappa@mvista.com> wrote:
>
>> 1. The Cantarell font typeface is designed as a
>>    contemporary Humanist sans serif, and was developed for
>>    on-screen reading; in particular, reading web pages on an
>>    HTC Dream mobile phone.
>>
>> 2. Pango test case (test-layout.test) requires cantarell-font
>>    typeface. This test case uses 'Cantarell 11' font type
>>
>> Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
>> ---
>>  .../cantarell-fonts/cantarell-fonts_git.bb         | 25
>> ++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>  create mode 100644 meta/recipes-graphics/cantarell-fonts/
>> cantarell-fonts_git.bb
>>
>> diff --git a/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
>> b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
>> new file mode 100644
>> index 0000000..f55fef1
>> --- /dev/null
>> +++ b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
>> @@ -0,0 +1,25 @@
>> +SUMMARY = "Cantarell, a Humanist sans-serif font family"
>> +
>> +DESCRIPTION = "The Cantarell font typeface is designed as a \
>> +               contemporary Humanist sans serif, and was developed for \
>> +               on-screen reading; in particular, reading web pages on an
>> \
>> +               HTC Dream mobile phone."
>> +
>> +HOMEPAGE = "https://git.gnome.org/browse/cantarell-fonts/"
>> +SECTION = "fonts"
>> +LICENSE = "OFL-1.1"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=df91e3ffcab8cfb972a66bf11255188d"
>> +
>> +PV = "0.0.18.1+git${SRCPV}"
>> +PR = "r0"
>> +
>> +SRCREV = "3e954528d06de1c7e5ba8ebf8b0cca9c68faa0c4"
>> +SRC_URI = "git://
>> git.gnome.org/cantarell-fonts;protocol=git;branch=master"
>> +
>> +S = "${WORKDIR}/git"
>> +
>> +inherit autotools allarch fontcache
>> +
>> +PACKAGECONFIG ??= ""
>> +PACKAGECONFIG[fontforge] =
>> "--enable-source-rebuild=yes,--enable-source-rebuild=no,fontforge-native"
>> +FILES_${PN} = "${datadir}/fonts ${datadir}/fontconfig"
>> --
>> 1.9.1
>>
>>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 5141 bytes --]

Re: [PATCH 1/2] cantarell-fonts: Add recipe

[Alexander Kanavin]

On 01/13/2016 07:36 PM, Jagadeesh Krishnanjanappa wrote:
> Ping.
>
> Without cantarell fonts, the pango test case test-layout.test fails.
> Previous result of pango ptest is at
> https://wiki.yoctoproject.org/wiki/Ptest_5e3e2e0cbb0a49986f4653e64c4c8d2b5461645e

There is an upstream bug for this:
https://bugzilla.gnome.org/show_bug.cgi?id=755733

You should leave a note at the upstream bug that the absence of the 
needed font is probably the issue. The test should probably be rewritten 
so that it doesn't assume that the font is available.

Alex

Re: [PATCH 1/2] cantarell-fonts: Add recipe

[Jussi Kukkonen]

[-- Attachment #1: Type: text/plain, Size: 2731 bytes --]

Hi again,

Maybe this does make sense even with the downsides I mentioned earlier:
testing the layout is a good idea (even if just using font metrics), and
the build/install time/size of cantarell are reasonable. The test in
question seems good to me and these patches produce correct results.

A recipe review comment below.

Jussi

On 9 January 2016 at 16:32, Jagadeesh Krishnanjanappa <
jkrishnanjanappa@mvista.com> wrote:
>
> 1. The Cantarell font typeface is designed as a
>    contemporary Humanist sans serif, and was developed for
>    on-screen reading; in particular, reading web pages on an
>    HTC Dream mobile phone.
>
> 2. Pango test case (test-layout.test) requires cantarell-font
>    typeface. This test case uses 'Cantarell 11' font type
>
> Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
> ---
>  .../cantarell-fonts/cantarell-fonts_git.bb         | 25
++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 meta/recipes-graphics/cantarell-fonts/
cantarell-fonts_git.bb
>
> diff --git a/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
> new file mode 100644
> index 0000000..f55fef1
> --- /dev/null
> +++ b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
> @@ -0,0 +1,25 @@
> +SUMMARY = "Cantarell, a Humanist sans-serif font family"
> +
> +DESCRIPTION = "The Cantarell font typeface is designed as a \
> +               contemporary Humanist sans serif, and was developed for \
> +               on-screen reading; in particular, reading web pages on an
\
> +               HTC Dream mobile phone."
> +
> +HOMEPAGE = "https://git.gnome.org/browse/cantarell-fonts/"
> +SECTION = "fonts"
> +LICENSE = "OFL-1.1"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=df91e3ffcab8cfb972a66bf11255188d"
> +
> +PV = "0.0.18.1+git${SRCPV}"

We could go with 0.0.21 since that's now out (I realize you picked the
newest release at the time -- sorry for extra work).

> +PR = "r0"

PR is not needed.

> +
> +SRCREV = "3e954528d06de1c7e5ba8ebf8b0cca9c68faa0c4"
> +SRC_URI = "git://git.gnome.org/cantarell-fonts;protocol=git;branch=master
"
> +
> +S = "${WORKDIR}/git"
> +
> +inherit autotools allarch fontcache
> +
> +PACKAGECONFIG ??= ""
> +PACKAGECONFIG[fontforge] =
"--enable-source-rebuild=yes,--enable-source-rebuild=no,fontforge-native"
> +FILES_${PN} = "${datadir}/fonts ${datadir}/fontconfig"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

[-- Attachment #2: Type: text/html, Size: 3899 bytes --]

Re: [PATCH 1/2] cantarell-fonts: Add recipe

[Jagadeesh Krishnanjanappa]

[-- Attachment #1: Type: text/plain, Size: 3173 bytes --]

Hi Jussi,

Thank you for considering the addition of cantarell fonts to OE-core. I
will submit an updated cantarell fonts recipe with v0.0.21 and PR ="r0"
removed.

Regards,
Jagadeesh

On Tue, Feb 9, 2016 at 8:07 PM, Jussi Kukkonen <jussi.kukkonen@intel.com>
wrote:

> Hi again,
>
> Maybe this does make sense even with the downsides I mentioned earlier:
> testing the layout is a good idea (even if just using font metrics), and
> the build/install time/size of cantarell are reasonable. The test in
> question seems good to me and these patches produce correct results.
>
> A recipe review comment below.
>
> Jussi
>
>
> On 9 January 2016 at 16:32, Jagadeesh Krishnanjanappa <
> jkrishnanjanappa@mvista.com> wrote:
> >
> > 1. The Cantarell font typeface is designed as a
> >    contemporary Humanist sans serif, and was developed for
> >    on-screen reading; in particular, reading web pages on an
> >    HTC Dream mobile phone.
> >
> > 2. Pango test case (test-layout.test) requires cantarell-font
> >    typeface. This test case uses 'Cantarell 11' font type
> >
> > Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>
> > ---
> >  .../cantarell-fonts/cantarell-fonts_git.bb         | 25
> ++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >  create mode 100644 meta/recipes-graphics/cantarell-fonts/
> cantarell-fonts_git.bb
> >
> > diff --git a/meta/recipes-graphics/cantarell-fonts/
> cantarell-fonts_git.bb b/meta/recipes-graphics/cantarell-fonts/
> cantarell-fonts_git.bb
> > new file mode 100644
> > index 0000000..f55fef1
> > --- /dev/null
> > +++ b/meta/recipes-graphics/cantarell-fonts/cantarell-fonts_git.bb
> > @@ -0,0 +1,25 @@
> > +SUMMARY = "Cantarell, a Humanist sans-serif font family"
> > +
> > +DESCRIPTION = "The Cantarell font typeface is designed as a \
> > +               contemporary Humanist sans serif, and was developed for \
> > +               on-screen reading; in particular, reading web pages on
> an \
> > +               HTC Dream mobile phone."
> > +
> > +HOMEPAGE = "https://git.gnome.org/browse/cantarell-fonts/"
> > +SECTION = "fonts"
> > +LICENSE = "OFL-1.1"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=df91e3ffcab8cfb972a66bf11255188d"
> > +
> > +PV = "0.0.18.1+git${SRCPV}"
>
> We could go with 0.0.21 since that's now out (I realize you picked the
> newest release at the time -- sorry for extra work).
>
> > +PR = "r0"
>
> PR is not needed.
>
> > +
> > +SRCREV = "3e954528d06de1c7e5ba8ebf8b0cca9c68faa0c4"
> > +SRC_URI = "git://
> git.gnome.org/cantarell-fonts;protocol=git;branch=master"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +inherit autotools allarch fontcache
> > +
> > +PACKAGECONFIG ??= ""
> > +PACKAGECONFIG[fontforge] =
> "--enable-source-rebuild=yes,--enable-source-rebuild=no,fontforge-native"
> > +FILES_${PN} = "${datadir}/fonts ${datadir}/fontconfig"
> > --
> > 1.9.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 4790 bytes --]