[PATCH] systemd-serialgetty: fix a typo

[PATCH] systemd-serialgetty: fix a typo

[rongqing.li]

From: Roy Li <rongqing.li@windriver.com>

it should be SERIAL_CONSOLES, not SERIAL_CONSOLE

Signed-off-by: Roy Li <rongqing.li@windriver.com>
---
 meta/recipes-core/systemd/systemd-serialgetty.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/systemd/systemd-serialgetty.bb b/meta/recipes-core/systemd/systemd-serialgetty.bb
index 768b130..265dc6a 100644
--- a/meta/recipes-core/systemd/systemd-serialgetty.bb
+++ b/meta/recipes-core/systemd/systemd-serialgetty.bb
@@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=80
 
 PR = "r5"
 
-SERIAL_CONSOLE ?= "115200 ttyS0"
+SERIAL_CONSOLES ?= "115200 ttyS0"
 
 SRC_URI = "file://serial-getty@.service"
 
-- 
1.9.1

Re: [PATCH] systemd-serialgetty: fix a typo

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

On 15 February 2016 at 07:47, <rongqing.li@windriver.com> wrote:

> -SERIAL_CONSOLE ?= "115200 ttyS0"
> +SERIAL_CONSOLES ?= "115200 ttyS0"
>

bitbake.conf says:

SERIAL_CONSOLES ??= "${@d.getVar('SERIAL_CONSOLE', True).replace(' ', ';')}"

And the relevant commit introducing _CONSOLES says:

    Just define additional serial consoles like so:
    SERIAL_CONSOLES="115200;ttyS0 115200;ttyS1 ... 115200;ttySN"

So moving from CONSOLE to CONSOLES is more than just adding an S.

Anyway, surely the machine should be setting this if required?  Why does
systemd-serialgetty think that ttyS0 should be a serial console if the
machine doesn't say so?

Ross

[-- Attachment #2: Type: text/html, Size: 1596 bytes --]

Re: [PATCH] systemd-serialgetty: fix a typo

[Rongqing Li]

On 2016年02月15日 18:30, Burton, Ross wrote:
>
> On 15 February 2016 at 07:47, <rongqing.li@windriver.com
> <mailto:rongqing.li@windriver.com>> wrote:
>
>     -SERIAL_CONSOLE ?= "115200 ttyS0"
>     +SERIAL_CONSOLES ?= "115200 ttyS0"
>
>
> bitbake.conf says:
>
> SERIAL_CONSOLES ??= "${@d.getVar('SERIAL_CONSOLE', True).replace(' ', ';')}"
>
> And the relevant commit introducing _CONSOLES says:
>
>      Just define additional serial consoles like so:
>      SERIAL_CONSOLES="115200;ttyS0 115200;ttyS1 ... 115200;ttySN"
>
> So moving from CONSOLE to CONSOLES is more than just adding an S.

sorry, I am wrong

>
> Anyway, surely the machine should be setting this if required?  Why does
> systemd-serialgetty think that ttyS0 should be a serial console if the
> machine doesn't say so?
>

This is a issue, like qemux86, ttyS0 and ttyS1 will be used as console,
but ttyS1 is not a true device when execute "runqemu qemux86", and lead
to the blow error.


root@qemu0:~# systemctl status serial-getty@ttyS1
● serial-getty@ttyS1.service - Serial Getty on ttyS1
    Loaded: loaded (/lib/systemd/system/serial-getty@.service; enabled; 
vendor preset: enabled)
    Active: active (running) since Sat 2016-02-06 03:33:26 UTC; 1s ago
      Docs: man:agetty(8)
            man:systemd-getty-generator(8)
            http://0pointer.de/blog/projects/serial-console.html
  Main PID: 902 (agetty)
    CGroup: 
/system.slice/system-serial\x2dgetty.slice/serial-getty@ttyS1.service
            └─902 /sbin/agetty -8 -L --keep-baud ttyS1 115200 xterm

Feb 06 03:33:26 qemu0 systemd[1]: Started Serial Getty on ttyS1.
Feb 06 03:33:26 qemu0 agetty[902]: /dev/ttyS1: not a tty




the below commit sets ttyS1 as console, but runqemu has only ttyS0 device.


commit 2da3fee6b6d9f4dd4c4cb529f4ba393c20aa0f13
Author: Randy Witt <randy.e.witt@linux.intel.com>
Date:   Thu Aug 20 13:01:25 2015 -0700

     qemurunner: Use two serial ports and log console with a thread

     qemu can freeze and stop responding if the socket buffer connected 
to a tcp
     serial connection fills up. This happens of course when the reader of
     the serial data doesn't actually read it.

     This happened in the qemurunner code, because after checking for the
     "login:" sentinel, data was never again read from the serial 
connection.

     This patch solves the potential freeze by adding a thread to 
continuously
     read the data from the console and log it. So it also will give a 
full log
     of the console, rather than just up to the login prompt.

     To simplify this patch, another serial port was also added to use 
for the
     sole purpose of watching for the sentinel as well as being the 
interactive
     serial port. This will also prevent the possibility of lots of debug
     data on the console preventing the sentinel value from being seen 
due to
     interleaved text.

     Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com>
     Signed-off-by: Ross Burton <ross.burton@intel.com>






-Roy




> Ross
-- 
Best Reagrds,
Roy | RongQing Li

Re: [PATCH] systemd-serialgetty: fix a typo

[Rongqing Li]

On 2016年02月16日 10:00, Rongqing Li wrote:
>
>
> On 2016年02月15日 18:30, Burton, Ross wrote:
>>
>> On 15 February 2016 at 07:47, <rongqing.li@windriver.com
>> <mailto:rongqing.li@windriver.com>> wrote:
>>
>>     -SERIAL_CONSOLE ?= "115200 ttyS0"
>>     +SERIAL_CONSOLES ?= "115200 ttyS0"
>>
>>
>> bitbake.conf says:
>>
>> SERIAL_CONSOLES ??= "${@d.getVar('SERIAL_CONSOLE', True).replace(' ',
>> ';')}"
>>
>> And the relevant commit introducing _CONSOLES says:
>>
>>      Just define additional serial consoles like so:
>>      SERIAL_CONSOLES="115200;ttyS0 115200;ttyS1 ... 115200;ttySN"
>>
>> So moving from CONSOLE to CONSOLES is more than just adding an S.
>
> sorry, I am wrong
>
>>
>> Anyway, surely the machine should be setting this if required?  Why does
>> systemd-serialgetty think that ttyS0 should be a serial console if the
>> machine doesn't say so?
>>
>
> This is a issue, like qemux86, ttyS0 and ttyS1 will be used as console,
> but ttyS1 is not a true device when execute "runqemu qemux86", and lead
> to the blow error.

this is not issue, since it is fixed by

commit 6f2047a0e278d29876451b5af8b8de156db33ed0
Author: Randy Witt <randy.e.witt@linux.intel.com>
Date:   Mon Sep 28 15:38:23 2015 -0700

     runqemu-internal: Make sure two serial ports always exist

     Since inittab for qemu images now always tries to start getty on a
     second serial device, make sure that device exists.

     Otherwise the following message will be spammed:
         INIT: Id "S1" respawning too fast: disabled for 5 minutes

     [YOCTO #8374]

     (From OE-Core rev: 988369afed85281f3ed9b2f3eeb30f5408498bb9)

     Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com>
     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>


-Roy

>
>
> root@qemu0:~# systemctl status serial-getty@ttyS1
> ● serial-getty@ttyS1.service - Serial Getty on ttyS1
>     Loaded: loaded (/lib/systemd/system/serial-getty@.service; enabled;
> vendor preset: enabled)
>     Active: active (running) since Sat 2016-02-06 03:33:26 UTC; 1s ago
>       Docs: man:agetty(8)
>             man:systemd-getty-generator(8)
>             http://0pointer.de/blog/projects/serial-console.html
>   Main PID: 902 (agetty)
>     CGroup:
> /system.slice/system-serial\x2dgetty.slice/serial-getty@ttyS1.service
>             └─902 /sbin/agetty -8 -L --keep-baud ttyS1 115200 xterm
>
> Feb 06 03:33:26 qemu0 systemd[1]: Started Serial Getty on ttyS1.
> Feb 06 03:33:26 qemu0 agetty[902]: /dev/ttyS1: not a tty
>
>
>
>
> the below commit sets ttyS1 as console, but runqemu has only ttyS0 device.
>
>
> commit 2da3fee6b6d9f4dd4c4cb529f4ba393c20aa0f13
> Author: Randy Witt <randy.e.witt@linux.intel.com>
> Date:   Thu Aug 20 13:01:25 2015 -0700
>
>      qemurunner: Use two serial ports and log console with a thread
>
>      qemu can freeze and stop responding if the socket buffer connected
> to a tcp
>      serial connection fills up. This happens of course when the reader of
>      the serial data doesn't actually read it.
>
>      This happened in the qemurunner code, because after checking for the
>      "login:" sentinel, data was never again read from the serial
> connection.
>
>      This patch solves the potential freeze by adding a thread to
> continuously
>      read the data from the console and log it. So it also will give a
> full log
>      of the console, rather than just up to the login prompt.
>
>      To simplify this patch, another serial port was also added to use
> for the
>      sole purpose of watching for the sentinel as well as being the
> interactive
>      serial port. This will also prevent the possibility of lots of debug
>      data on the console preventing the sentinel value from being seen
> due to
>      interleaved text.
>
>      Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com>
>      Signed-off-by: Ross Burton <ross.burton@intel.com>
>
>
>
>
>
>
> -Roy
>
>
>
>
>> Ross

-- 
Best Reagrds,
Roy | RongQing Li