Re: [PATCH 3/3] populate_sdk_ext.bbclass: Add SDK_RECRDEP_TASKS variable

[Randy Witt <randy.e.witt@linux.intel.com>]

On 02/18/2016 02:57 PM, Richard Purdie wrote:
> On Thu, 2016-02-18 at 09:17 -0800, Randy Witt wrote:
>> Currently there isn't a way for the extensible sdk to know all the
>> tasks
>> that will need sstate for an image. This is because a layer can add
>> it's
>> on custom tasks that are required for an image to be generated.
>>
>> The extensible sdk solved this for poky by using recrdeptask and
>> specifying the tasks known to be required for the image as well as
>> for
>> building new recipes.
>>
>> So the SDK_RECRDEP_TASKS variable allows a user to specify additional
>> tasks that need to be pulled in.
>>
>> Signed-off-by: Randy Witt <randy.e.witt@linux.intel.com>
>> ---
>>   meta/classes/populate_sdk_ext.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/populate_sdk_ext.bbclass
>> b/meta/classes/populate_sdk_ext.bbclass
>> index 7c95301..5f90aea 100644
>> --- a/meta/classes/populate_sdk_ext.bbclass
>> +++ b/meta/classes/populate_sdk_ext.bbclass
>> @@ -359,7 +359,7 @@ addtask sdk_depends
>>   do_sdk_depends[dirs] = "${WORKDIR}"
>>   do_sdk_depends[depends] = "${@get_ext_sdk_depends(d)}"
>>   do_sdk_depends[recrdeptask] = "${@d.getVarFlag('do_populate_sdk',
>> 'recrdeptask', False)}"
>> -do_sdk_depends[recrdeptask] += "do_populate_lic do_package_qa
>> do_populate_sysroot do_deploy"
>> +do_sdk_depends[recrdeptask] += "do_populate_lic do_package_qa
>> do_populate_sysroot do_deploy ${SDK_RECRDEP_TASKS}"
>>   do_sdk_depends[rdepends] = "${@get_sdk_ext_rdepends(d)}"
>>
>>   def get_sdk_ext_rdepends(d):
>
> Doesn't this need a default value or it will throw parse failures?

Actually, it didn't generate parse errors. My guess is it just didn't expand it 
and put a bogus task in the list. So I'll send a v2.

>
> Cheers,
>
> Richard
>