[PATCH 0/2] Fixes for len(TMPDIR) == 410

[PATCH 0/2] Fixes for len(TMPDIR) == 410

[Robert Yang]

The following changes since commit b2dc5a68e74dafedf7960ef77ad3d73912ed7960:

  bdwgc: use github repo for source location (2016-04-05 11:48:09 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/long
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/long

Robert Yang (2):
  sanity.bbclass: fix a hardcode in check_path_length()
  wget: fix build when len(TMPDIR) == 410

 meta/classes/sanity.bbclass         | 2 +-
 meta/recipes-extended/wget/wget.inc | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.8.0

[PATCH 1/2] sanity.bbclass: fix a hardcode in check_path_length()

[Robert Yang]

* Fixed:
  410 -> limit

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/sanity.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
index 662f764..ac23517 100644
--- a/meta/classes/sanity.bbclass
+++ b/meta/classes/sanity.bbclass
@@ -334,7 +334,7 @@ def check_create_long_filename(filepath, pathname):
 
 def check_path_length(filepath, pathname, limit):
     if len(filepath) > limit:
-        return "The length of %s is longer than 410, this would cause unexpected errors, please use a shorter path.\n" % pathname
+        return "The length of %s is longer than %s, this would cause unexpected errors, please use a shorter path.\n" % (pathname, limit)
     return ""
 
 def get_filesystem_id(path):
-- 
2.8.0

[PATCH 2/2] wget: fix build when len(TMPDIR) == 410

[Robert Yang]

Fixed:
aclocal: error: cannot open [snip] |: Argument list too long

Set acpaths to fix the problem.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-extended/wget/wget.inc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta/recipes-extended/wget/wget.inc b/meta/recipes-extended/wget/wget.inc
index 049b898..dc381a6 100644
--- a/meta/recipes-extended/wget/wget.inc
+++ b/meta/recipes-extended/wget/wget.inc
@@ -22,3 +22,8 @@ BBCLASSEXTEND += "nativesdk"
 
 PACKAGECONFIG ??= ""
 PACKAGECONFIG[libuuid] = "--with-libuuid, --without-libuuid,util-linux"
+
+# Let aclocal use the relative path for the m4 file rather than
+# absolute, otherwise there might be an "Argument list too long" error
+# when it is built in a long/deep directory.
+acpaths = "-I ./m4"
-- 
2.8.0

Re: [PATCH 0/2] Fixes for len(TMPDIR) == 410

[Gary Thomas]

On 2016-04-06 11:30, Robert Yang wrote:
> The following changes since commit b2dc5a68e74dafedf7960ef77ad3d73912ed7960:
>
>    bdwgc: use github repo for source location (2016-04-05 11:48:09 +0100)
>
> are available in the git repository at:
>
>    git://git.openembedded.org/openembedded-core-contrib rbt/long
>    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/long
>
> Robert Yang (2):
>    sanity.bbclass: fix a hardcode in check_path_length()
>    wget: fix build when len(TMPDIR) == 410
>
>   meta/classes/sanity.bbclass         | 2 +-
>   meta/recipes-extended/wget/wget.inc | 5 +++++
>   2 files changed, 6 insertions(+), 1 deletion(-)
>

How are these patches related and what is magic about a path length of 410?
Are you sure that it might not be 569 on my system for example?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [PATCH 0/2] Fixes for len(TMPDIR) == 410

[Richard Purdie]

On Wed, 2016-04-06 at 11:38 +0200, Gary Thomas wrote:
> On 2016-04-06 11:30, Robert Yang wrote:
> > The following changes since commit
> > b2dc5a68e74dafedf7960ef77ad3d73912ed7960:
> > 
> >    bdwgc: use github repo for source location (2016-04-05 11:48:09
> > +0100)
> > 
> > are available in the git repository at:
> > 
> >    git://git.openembedded.org/openembedded-core-contrib rbt/long
> >    http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/
> > log/?h=rbt/long
> > 
> > Robert Yang (2):
> >    sanity.bbclass: fix a hardcode in check_path_length()
> >    wget: fix build when len(TMPDIR) == 410
> > 
> >   meta/classes/sanity.bbclass         | 2 +-
> >   meta/recipes-extended/wget/wget.inc | 5 +++++
> >   2 files changed, 6 insertions(+), 1 deletion(-)
> > 
> 
> How are these patches related and what is magic about a path length
> of 410?
> Are you sure that it might not be 569 on my system for example?

410 is the maximum we've ever managed to make work for the core
recipes. We're basically trying to ensure we don't get worse. In an
ideal world there wouldn't be any restrictions but that would take
significant resource investment for questionable return.

Cheers,

Richard