Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it

From: Andreas Oberritter <obi@opendreambox.org>
To: Khem Raj <raj.khem@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it
Date: Fri, 8 Apr 2016 03:25:15 +0200	[thread overview]
Message-ID: <5707087B.8040905@opendreambox.org> (raw)
In-Reply-To: <CAMKF1sqhKWWDBdzZ9gU_J8SWhNiBNXxw3oi6tuzyhbOrUQ4iSw@mail.gmail.com>

On 08.04.2016 03:10, Khem Raj wrote:
> 
> On Apr 7, 2016 4:46 PM, "Andreas Oberritter" <obi@opendreambox.org
> <mailto:obi@opendreambox.org>> wrote:
>>
>> On 07.04.2016 21:01, Khem Raj wrote:
>> >
>> >> On Apr 7, 2016, at 10:34 AM, Andreas Oberritter
> <obi@opendreambox.org <mailto:obi@opendreambox.org>> wrote:
>> >>
>> >> Hi Khem,
>> >>
>> >> On 07.04.2016 09:02, Khem Raj wrote:
>> >>> echo would fail if /sys is not mounted and boot would abort
>> >>
>> >> are you sure about the dependency between echo and sysfs? It seems
> quite
>> >> unlikely to me. I'd guess the real problem is mdev failing to start
>> >> without syses.
>> >
>> > real problem was missing mounting sysfs on /sys, but I wanted to
> keep the other
>> > way of setting it instead of echo
>>
>> Note that I was referring to your commit message.
>>
>> After a second look I see that you also mount /proc in your patch, and I
>> guess that's what you meant to describe. Please update the commit
>> message (and subject) to actually match your patch.
> 
> Whata not clear in patch subject

It doesn't mention /proc.

>>
>> Regards,
>> Andreas
>>
>>
>> >
>> >>
>> >> Regards,
>> >> Andreas
>> >>
>> >>
>> >>>
>> >>> Signed-off-by: Khem Raj <raj.khem@gmail.com
> <mailto:raj.khem@gmail.com>>
>> >>> ---
>> >>> meta/recipes-core/busybox/files/mdev | 4 +++-
>> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> >>>
>> >>> diff --git a/meta/recipes-core/busybox/files/mdev
> b/meta/recipes-core/busybox/files/mdev
>> >>> index 9625247..8c9c06e 100755
>> >>> --- a/meta/recipes-core/busybox/files/mdev
>> >>> +++ b/meta/recipes-core/busybox/files/mdev
>> >>> @@ -1,10 +1,12 @@
>> >>> #!/bin/sh
>> >>> -
>> >>> +mount -t proc proc /proc
>> >>> +mount -t sysfs sysfs /sys
>> >>> mount -t tmpfs tmpfs /dev  -o size=64k,mode=0755
>> >>> mkdir /dev/pts /dev/shm
>> >>> chmod 777 /dev/shm
>> >>> mount -t devpts devpts /dev/pts
>> >>> touch /dev/mdev.seq
>> >>> +#sysctl -w kernel.hotplug=/sbin/mdev
>> >>> echo "/sbin/mdev" > /proc/sys/kernel/hotplug
>> >>> mdev -s
>> >>>
>> >>>
>> >>
>> >> --
>> >> _______________________________________________
>> >> Openembedded-core mailing list
>> >> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
>> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>> >
>>
> 